- 23 Aug, 2019 2 commits
-
-
Sigurd Schneider authored
Change-Id: I9988ea2dfeccbfaa9e0197920703ab430a43acb7 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674026 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#63375}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ia8e5d51b12cc86734523860af88d4c3948e0f0c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660614 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#63371}
-
- 15 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I9cdea29db2b409d773a16e3d6c29ef4325257162 Reviewed-on: https://chromium-review.googlesource.com/c/1409437 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58815}
-
- 14 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Drive-by: Make label of checkboxes in disassembly view clickable. Notry: true Bug: v8:7327 Change-Id: I29478c5cb2bd4152df7943f9dfbba487f3b8bddb Reviewed-on: https://chromium-review.googlesource.com/c/1407053 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58782}
-
- 12 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
- 'let' instead of 'var', and prefer 'const' - Prefer for-of over indexed interation - Variable names should be 'camel-case' or all-caps snake-case. - Only one variable declaration per line Change-Id: I645dd2333d6d9a993f24c29121f5f156249f1b71 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405320 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58761}
-
Sigurd Schneider authored
Change-Id: I8e147bcb5d1e0b8e16874f0593a8ce4338dfc201 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58760}
-
Sigurd Schneider authored
- Ban T[] array syntax - Format arrow function arguments consistently Bug: v8:7327 Notry: true Change-Id: I072a352ec9009948392a6bb5dd4381d4993af7be Reviewed-on: https://chromium-review.googlesource.com/c/1405317 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58759}
-
- 09 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Change-Id: Iffd68156515948254e4ce38021c511596acc5788 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1400849 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58681}
-
- 07 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
This CL enables noImplicitReturns and noImplicitThis warnings in TypeScript, another step on the road to stricter types. Drive-by: Fix bug in search function. Change-Id: Iafb528b5f0e7ccc8774bc218fd0dcdb206a0de31 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396422 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58576}
-
- 04 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
This CL adds more TypeScript types and inserts some instanceof checks to ensure typing. The CL also selects es2018 as target and loads es6/es2018 libs for TypeScript types. This ensures that RegExp groups matching results are properly typed. Notry: true Bug: v8:7327 Change-Id: I1a59a1047188a49579c975149b336cc232c05eef Reviewed-on: https://chromium-review.googlesource.com/c/1396095Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58553}
-
Sigurd Schneider authored
...and fix all related issues. Change-Id: I3bd37ae038b9ea7c4305600958c1ae20e67e0f1f Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396092Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58552}
-
Sigurd Schneider authored
- Move helper functions to utils - Use let/const instead of var - Fix display bug when schedule view was initially selected Bug: v8:7327 Notry: true Change-Id: I7caf3dd17b725a4553d035293716f452b9999ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1396088 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58550}
-
- 21 Dec, 2018 3 commits
-
-
Sigurd Schneider authored
This CL makes both absolute address and opcode literal (byte sequence of the instruction) display optional, which improves readability. Additionally, jump offsets are parsed and can now once again be clicked. TBR=neis@chromium.org Bug: v8:7327 Notry: true Change-Id: I709f44540b32f6d4afabdd1e5eb27e932208e7fc Reviewed-on: https://chromium-review.googlesource.com/c/1388540 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58444}
-
Sigurd Schneider authored
Disassembly selections now work even if no origin node is associated with the disassembly code range that the user selects. TBR=neis@chromium.org Bug: v8:7327 Change-Id: Ib5bfcaded66deb65314fde7d3cb9ed2c3c4f6fe9 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1387492Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58423}
-
Sigurd Schneider authored
Bug: v8:7327 Notry: true Change-Id: Ia1c2164269d3d656b951d46debe42a811a6d9c89 Reviewed-on: https://chromium-review.googlesource.com/c/1386494Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58421}
-
- 20 Dec, 2018 1 commit
-
-
Sigurd Schneider authored
This is work towards making instructions in the sequence view selectable. For now, they are clickable and will select the corresponding instructions in the disassembly view. Bug: v8:7327 Notry: true Change-Id: I8850efeec7f94487bd80c11a7ad250a959062393 Reviewed-on: https://chromium-review.googlesource.com/c/1386112 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58397}
-
- 19 Dec, 2018 1 commit
-
-
Sigurd Schneider authored
This CL improves load times by up to 6x. This is achieved by not setting event handlers per-line, but setting one event handler on the container. Unfortunately, load times are dominated by the graph view, which needs to be addressed in another CL. Bug: v8:7327 Notry: true Change-Id: Ie9a999f4150617fd763b770fcacca6096f457880 Reviewed-on: https://chromium-review.googlesource.com/c/1384312Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58370}
-
- 22 Nov, 2018 1 commit
-
-
Sigurd Schneider authored
Notry: true Change-Id: I4de1f561682e8ad7fac0358c259efa44559c1389 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1347477Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57718}
-
- 06 Nov, 2018 1 commit
-
-
Sigurd Schneider authored
Notry: true Change-Id: Iacc8aadc62956cf5fab13c60a9eaa52318519d62 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1317813 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#57267}
-
- 11 Oct, 2018 1 commit
-
-
Sigurd Schneider authored
This will allow us to use ts-node to execute tests written in TypeScript. Bug: v8:7327 Change-Id: I0804db1f112448350c5e91135242e6ec6706d231 Reviewed-on: https://chromium-review.googlesource.com/c/1274086 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56564}
-
- 11 Jul, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: If2670e2b8e64a34f5de7855615e2288b6f2f3133 Reviewed-on: https://chromium-review.googlesource.com/1131193 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54371}
-
- 13 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: I8cd57abf612393852532a695663175dff8e3a199 Reviewed-on: https://chromium-review.googlesource.com/1098955 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53713}
-
- 11 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
- Improve typing by introducing PhaseView interface. - Recalculate scale extent after resizing. - Fix null sentinel which should have been undefined. Bug: v8:7327 Change-Id: I06881ac3f5681cb419b5da9c6b8aa3a6b2652088 Reviewed-on: https://chromium-review.googlesource.com/1090914Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53631}
-
- 29 May, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: I2be450c6498ce863d5e36acf02db643788e6c8bf Reviewed-on: https://chromium-review.googlesource.com/1068045 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53400}
-
- 22 May, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: I6d84e7ef500aecd83a77ed2ce3fed4e15b29b7ac Reviewed-on: https://chromium-review.googlesource.com/1065881 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53289}
-
- 16 May, 2018 1 commit
-
-
Sigurd Schneider authored
This CL adds support for inlined functions in Turbolizer. It is also a refactoring of the Turbolizer code-base. Most importantly, handling of source positions changed to exact source positions, and not code ranges. This improves selection interoperability between different phase views. A separate CL changes the Turbolizer JSON format to include inlining information. This Turbolizer update, however, is intended to be backwards compatible with the JSON format Turbolizer generated before the JSON format change. Bug: v8:7327 Change-Id: Ic67506a6f3a36fe98c012b1e76994972779c1fd2 Reviewed-on: https://chromium-review.googlesource.com/1032784 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53213}
-
- 15 May, 2017 1 commit
-
-
pierre.langlois authored
The output of disassemblers was changed to display instruction offsets as hexadecimal numbers instead of a decimal numbers. Reflect this change in turbolizer. BUG= Review-Url: https://codereview.chromium.org/2885453002 Cr-Commit-Position: refs/heads/master@{#45315}
-
- 14 Sep, 2016 1 commit
-
-
Alexander.Gilday2 authored
All events recorded are shown in separate columns simulatneously, using rectangles with heatmap-style colouring. Hovering over the shapes gives the event name, count, and percentage. BUG= Review-Url: https://codereview.chromium.org/2228553004 Cr-Commit-Position: refs/heads/master@{#39408}
-
- 10 Aug, 2016 2 commits
-
-
danno authored
Also convert CodeView to a class and fix a host of selection bugs in the process, as well as move the logic and data to "enrich" location with one type of location data with location data known globally to the whole graph in the selection broker. Review-Url: https://codereview.chromium.org/2230083004 Cr-Commit-Position: refs/heads/master@{#38544}
-
danno authored
Review-Url: https://codereview.chromium.org/2234523002 Cr-Commit-Position: refs/heads/master@{#38520}
-
- 28 Jul, 2016 1 commit
-
-
Alexander.Gilday2 authored
perf-turbo.py merges a perf data file and a turbofan trace file into a single json object which can then be piped to a file and uploaded to turbolizer to display the profiling data in the disassembly. With the changes, turbolizer now shows the event counts for instruction in percentage form and with heatmap-stype colouring. Multiple different events can be recorded at once with a new drop-down menu to select which event to view the counts of. The documentation has been updated with instructions. Using the script is optional and turbolizer retains previous functionality if a trace without profiling data is uploaded. BUG=None Review-Url: https://codereview.chromium.org/2174803002 Cr-Commit-Position: refs/heads/master@{#38124}
-
- 11 Jul, 2016 1 commit
-
-
Alexander.Gilday2 authored
This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler). Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker. Review-Url: https://codereview.chromium.org/2133663002 Cr-Commit-Position: refs/heads/master@{#37627}
-
- 19 May, 2016 1 commit
-
-
danno authored
Review-Url: https://codereview.chromium.org/729913004 Cr-Commit-Position: refs/heads/master@{#36351}
-