- 05 Jan, 2021 1 commit
-
-
Benedikt Meurer authored
Consistently use InspectorTest.runAsyncTestSuite() in wasm inspector tests to make tests easier to debug (they'll fail instead of timing out in case of errors). Bug: chromium:1162229, chromium:1071432 Change-Id: I7aada196f9e34071aa1bb059bb45f85f75226060 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609414 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71908}
-
- 16 Oct, 2020 1 commit
-
-
Clemens Backes authored
It makes inspector tests a lot more readable if the opcode of the pause location is being printed. Since we already have a list of all opcodes available in wasm-module-builder.js, we can just reuse that to build a reverse lookup map. This CL implements this for single-byte opcodes only, which is enough for all tests that we currently have. It will have to be extended for prefixed opcodes once that is being used. R=thibaudm@chromium.org, kimanh@chromium.org Change-Id: I085fea99d2f5f2dc6cc084448e5f7444cce5c78b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474789 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70578}
-
- 15 Oct, 2020 1 commit
-
-
Clemens Backes authored
Stepping always happens in Liftoff now, and always by byte offset. Thus remove the redundant "wasm-stepping-byte-offset" test, which was fully subsumed by "wasm-stepping-liftoff". Also, rename "wasm-stepping-liftoff" to "wasm-stepping". R=thibaudm@chromium.org Bug: chromium:1137710 Change-Id: Ifb68ce795ecdcbb1f85500dc4be4c2e64d15a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474116Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70528}
-
- 27 Mar, 2020 1 commit
-
-
Clemens Backes authored
This is a minor cosmetic fix. Wasm opcodes are bytes, hence they should always be printed as an even number of hexadecimal digits. Note that currently we only print a single byte anyway, but in the future we will want to extend this to correctly parse multi-byte opcodes. Those will also be printed as an even number of characters then. R=thibaudm@chromium.org Bug: v8:10351 Change-Id: I2423277b470d74c1c72cb619c2a43bb978423bc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2122025Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66883}
-
- 26 Mar, 2020 1 commit
-
-
Clemens Backes authored
We were sometimes stopping on a one-shot breakpoints in JS code even though the last user action was actually a resume. This CL fixes that clearing all stepping in JS whenever we hit a breakpoint in wasm. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: Ie5d12bb0c9e766bcbd5ad0aa225a8b14b4d608b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120588Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66869}
-
- 25 Mar, 2020 3 commits
-
-
Clemens Backes authored
Using the "logSourceLocation" function from protocol-test.js prints slightly better location information for wasm, and especially much better information for JS breakpoints. This helps understanding and debugging these tests. R=thibaudm@chromium.org Bug: v8:10351 Change-Id: I51c7d168d2cb19fb8469b4a2eb372c2b95650fcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120539Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66863}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10321 Change-Id: I318d46fa638c1d6f4d5d347e5aa0ad1faf02d5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120532 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66855}
-
Clemens Backes authored
A StepOver at a return (either explicit return instruction, or implicit return at the end of the function) should stop again in the caller frame. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: I313e6b612ac52e73b33ef07c6da1ced2aa0db600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110250Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66852}
-
- 24 Mar, 2020 1 commit
-
-
Clemens Backes authored
This fixes issues with replacing the return address of deeper (non-top) wasm frames, i.e. frames which are at a call position. The replaced address should also point after the call in the new code, so we don't execute the same call again. This is achieved by using slightly different encodings for breakpoint positions and other (wasm instruction) positions. Breakpoints set {is_instruction} to {false} in the source position table entry, whereas usual wasm instruction set it to {true}. Also, during stack walking for OSR, we remember whether we want to OSR to the position before the instruction (if it's the top frame), or after the call instruction (if it's deeper in the stack). We then use the {is_instruction} predicate to find the right location. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: I73212a7532c6ecf4c82bde76fe4059c8203e422c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116206Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66850}
-
- 19 Mar, 2020 1 commit
-
-
Clemens Backes authored
Update the "hook on function call" flag also in the wasm case, and slightly change the {IsStepping} logic to stop in any frame if the last step action was anything other than StepNext. In future CLs, this has to be extended further for StepOut and for StepOver at a return location. When that is done, we can also reenable more stepping in the test. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: Ib3aa8c2c2e137690140e5879a33e2bcc340821e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108035 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#66789}
-
- 17 Mar, 2020 1 commit
-
-
Thibaud Michaud authored
And fix a few issues revealed by this new test. Incidentally, the test uses removeBreakpoint which was still untested with Liftoff. But as expected this seems to work out of the box. R=clemensb@chromium.org Bug: v8:10321 Change-Id: Ifa4e867737d925ea8c6c9731575a32f3da3e16dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2106206 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66752}
-
- 13 Mar, 2020 2 commits
-
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10321 Change-Id: Ia082b842de8947ead3931943b3bc05903a0f9e29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2101002Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#66704}
-
Thibaud Michaud authored
Flood functions with breakpoints to prepare them for stepping. With a small modification to the runtime function, this already implements a basic step over functionality. We still cannot resume, step in or step out (including stepping over a return instruction). R=clemensb@chromium.org Bug: v8:10321 Change-Id: Ia4a6335d24c1a511c2f1fc9b48d728f327b3df56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2098732Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#66697}
-