1. 08 May, 2018 1 commit
  2. 06 Apr, 2018 1 commit
  3. 04 Apr, 2018 1 commit
    • Jungshik Shin's avatar
      Reland "Implement a new spec for timezone offset calculation" · 1d3a87bd
      Jungshik Shin authored
      This is a reland of dbdede01
      after a webkit layout test (geolocation-api/timestamp.html) was
      fixed by
      https://chromium-review.googlesource.com/c/chromium/src/+/994343 .
      
      Original change's description:
      > Implement a new spec for timezone offset calculation
      >
      > https://github.com/tc39/ecma262/pull/778 was recently merged
      > to Ecma 262.
      >
      > It changes the way to convert between "local time" and UTC in such
      > a way that it'd work for all timezones whether or not there has
      > been any change in the timezone offset of the standard time. For
      > instance, Europe/Moscow and some parts of US state of Indiana have
      > changed the standard (non-DST) timezone offset a few times. The
      > previous spec assumes that the the standard timezone offset is
      > constant, but the new spec take into account the offset change
      > history.
      >
      > In addition, it specifies a new way to calculate the timezone
      > offset during a timezone transition (either in and
      > out of DST or timezone offset shift).
      >
      > During a negative transition (e.g.  fall backward / getting
      > out of DST), repeated times are to be interpreted as if the
      > offset before the transition is in effect.
      >
      > During a positive transition (e.g. spring forward / getting
      > into DST), skipped times are to be treated similarly. That
      > is, they are to be interpreted as if the offset before the
      > transition is in effect.
      >
      > With icu-timezone-data, v8 is compliant to the new spec for the
      > past and the future as well as now whether or not the standard
      > timezone offset of a given timezone has changed over time
      > (e.g. Europe/Moscow, Pacific/Apia). With icu-timezone-data,
      > Australia/Lord_Howe (30 minute DST change) also works per spec.
      >
      > Without icu-timezone-data, it works only for timezones of which
      > the standard timezone offset is the same as the current offset
      > (e.g. most North American timezones other than parts of Indiana)
      > and of which the DST shift is an hour. For instance, it doesn't work
      > for Europe/Moscow in 2010 when the standard timezone offset was
      > +4h because the current (2018) standard timezone offset is +3h. Neither
      > does it for Lord Howe in Australia with the DST shift of 0.5 hr.
      >
      > This CL used to require one of the two ICU CLs below, but not
      > any more.
      >
      >   https://chromium-review.googlesource.com/c/chromium/deps/icu/+/572652
      >   https://chromium-review.googlesource.com/851265  (a proposed CL to the
      >   upstream ICU).
      >
      > Bug: v8:3547,chromium:417640,v8:5714
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Ib162295da5bee31b2390bd0918157014aebd3e33
      > Reviewed-on: https://chromium-review.googlesource.com/572148
      > Commit-Queue: Jungshik Shin <jshin@chromium.org>
      > Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52332}
      
      Bug: v8:3547, chromium:417640, v8:5714
      Change-Id: I47536c111143f75e3cfeecf5d9761c43a98a10f5
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/995971
      Commit-Queue: Jungshik Shin <jshin@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52372}
      1d3a87bd
  4. 03 Apr, 2018 2 commits
    • Clemens Hammacher's avatar
      Revert "Implement a new spec for timezone offset calculation" · 965edc0e
      Clemens Hammacher authored
      This reverts commit dbdede01.
      
      Reason for revert: Fails webkit_tests, blocks roll: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064
      
      Original change's description:
      > Implement a new spec for timezone offset calculation
      > 
      > https://github.com/tc39/ecma262/pull/778 was recently merged
      > to Ecma 262.
      > 
      > It changes the way to convert between "local time" and UTC in such
      > a way that it'd work for all timezones whether or not there has
      > been any change in the timezone offset of the standard time. For
      > instance, Europe/Moscow and some parts of US state of Indiana have
      > changed the standard (non-DST) timezone offset a few times. The
      > previous spec assumes that the the standard timezone offset is
      > constant, but the new spec take into account the offset change
      > history.
      > 
      > In addition, it specifies a new way to calculate the timezone
      > offset during a timezone transition (either in and
      > out of DST or timezone offset shift).
      > 
      > During a negative transition (e.g.  fall backward / getting
      > out of DST), repeated times are to be interpreted as if the
      > offset before the transition is in effect.
      > 
      > During a positive transition (e.g. spring forward / getting
      > into DST), skipped times are to be treated similarly. That
      > is, they are to be interpreted as if the offset before the
      > transition is in effect.
      > 
      > With icu-timezone-data, v8 is compliant to the new spec for the
      > past and the future as well as now whether or not the standard
      > timezone offset of a given timezone has changed over time
      > (e.g. Europe/Moscow, Pacific/Apia). With icu-timezone-data,
      > Australia/Lord_Howe (30 minute DST change) also works per spec.
      > 
      > Without icu-timezone-data, it works only for timezones of which
      > the standard timezone offset is the same as the current offset
      > (e.g. most North American timezones other than parts of Indiana)
      > and of which the DST shift is an hour. For instance, it doesn't work
      > for Europe/Moscow in 2010 when the standard timezone offset was
      > +4h because the current (2018) standard timezone offset is +3h. Neither
      > does it for Lord Howe in Australia with the DST shift of 0.5 hr.
      > 
      > This CL used to require one of the two ICU CLs below, but not
      > any more.
      > 
      >   https://chromium-review.googlesource.com/c/chromium/deps/icu/+/572652
      >   https://chromium-review.googlesource.com/851265  (a proposed CL to the
      >   upstream ICU).
      > 
      > Bug: v8:3547,chromium:417640,v8:5714
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Ib162295da5bee31b2390bd0918157014aebd3e33
      > Reviewed-on: https://chromium-review.googlesource.com/572148
      > Commit-Queue: Jungshik Shin <jshin@chromium.org>
      > Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52332}
      
      TBR=adamk@chromium.org,littledan@chromium.org,mlippautz@chromium.org,jshin@chromium.org
      
      Change-Id: I6b3bf4427c761b106280d565a3912cd8e25cf87e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:3547, chromium:417640, v8:5714
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/994192Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52338}
      965edc0e
    • Jungshik Shin's avatar
      Implement a new spec for timezone offset calculation · dbdede01
      Jungshik Shin authored
      https://github.com/tc39/ecma262/pull/778 was recently merged
      to Ecma 262.
      
      It changes the way to convert between "local time" and UTC in such
      a way that it'd work for all timezones whether or not there has
      been any change in the timezone offset of the standard time. For
      instance, Europe/Moscow and some parts of US state of Indiana have
      changed the standard (non-DST) timezone offset a few times. The
      previous spec assumes that the the standard timezone offset is
      constant, but the new spec take into account the offset change
      history.
      
      In addition, it specifies a new way to calculate the timezone
      offset during a timezone transition (either in and
      out of DST or timezone offset shift).
      
      During a negative transition (e.g.  fall backward / getting
      out of DST), repeated times are to be interpreted as if the
      offset before the transition is in effect.
      
      During a positive transition (e.g. spring forward / getting
      into DST), skipped times are to be treated similarly. That
      is, they are to be interpreted as if the offset before the
      transition is in effect.
      
      With icu-timezone-data, v8 is compliant to the new spec for the
      past and the future as well as now whether or not the standard
      timezone offset of a given timezone has changed over time
      (e.g. Europe/Moscow, Pacific/Apia). With icu-timezone-data,
      Australia/Lord_Howe (30 minute DST change) also works per spec.
      
      Without icu-timezone-data, it works only for timezones of which
      the standard timezone offset is the same as the current offset
      (e.g. most North American timezones other than parts of Indiana)
      and of which the DST shift is an hour. For instance, it doesn't work
      for Europe/Moscow in 2010 when the standard timezone offset was
      +4h because the current (2018) standard timezone offset is +3h. Neither
      does it for Lord Howe in Australia with the DST shift of 0.5 hr.
      
      This CL used to require one of the two ICU CLs below, but not
      any more.
      
        https://chromium-review.googlesource.com/c/chromium/deps/icu/+/572652
        https://chromium-review.googlesource.com/851265  (a proposed CL to the
        upstream ICU).
      
      Bug: v8:3547,chromium:417640,v8:5714
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Ib162295da5bee31b2390bd0918157014aebd3e33
      Reviewed-on: https://chromium-review.googlesource.com/572148
      Commit-Queue: Jungshik Shin <jshin@chromium.org>
      Reviewed-by: 's avatarDaniel Ehrenberg <littledan@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52332}
      dbdede01
  5. 28 Mar, 2018 3 commits
  6. 26 Mar, 2018 1 commit
  7. 01 Feb, 2018 1 commit
  8. 31 Jan, 2018 2 commits
  9. 30 Jan, 2018 3 commits
  10. 23 Jan, 2018 1 commit
  11. 15 Jan, 2018 1 commit
  12. 10 Jan, 2018 1 commit
  13. 04 Jan, 2018 2 commits
    • Michal Majewski's avatar
      [test] Check output on the worker process. · 9f7d440e
      Michal Majewski authored
      I added additional exception logging in the execution.py since
      errors in processing results were really difficult to debug.
      
      There is a problem on Windows with class serialization when
      it comes from dynamically loaded module. To fix it I moved all
      output processors to the tools/testrunner/outproc/ and import
      them in test/*/testcfg.py.
      
      Bug: v8:6917
      Change-Id: Ida604641d659b006e91faf1d56a37769ec47f5f3
      Reviewed-on: https://chromium-review.googlesource.com/842784
      Commit-Queue: Michał Majewski <majeski@google.com>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50361}
      9f7d440e
    • Michael Achenbach's avatar
      Revert "Revert "[test] Move has unexpected output to outproc."" · c1e9bc02
      Michael Achenbach authored
      This reverts commit 1685b5d2.
      
      Reason for revert: Was probably caused by infra change:
      https://crrev.com/c/845781
      
      Original change's description:
      > Revert "[test] Move has unexpected output to outproc."
      > 
      > This reverts commit 71605b3e.
      > 
      > Reason for revert: Seems to break static-initializers step:
      > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156
      > 
      > Original change's description:
      > > [test] Move has unexpected output to outproc.
      > > 
      > > Expected outcomes optimized to serialize [PASS] as None.
      > > 
      > > Keeping expected outcomes inside output processors should be
      > > optimized in the future. Few possible optimizations:
      > > - separate classes for tests that are expected to PASS - done as
      > > an example in mozilla test suite.
      > > - cache output processors inside testcase.
      > > - share output processors between copies of the same test - needs
      > > some updates to the create_variant to update outproc only if
      > > expected outcomes changed.
      > > 
      > > Bug: v8:6917
      > > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      > > Reviewed-on: https://chromium-review.googlesource.com/843025
      > > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#50347}
      > 
      > TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      > 
      > Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: v8:6917
      > Reviewed-on: https://chromium-review.googlesource.com/849572
      > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50348}
      
      TBR=bbudge@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      
      Change-Id: I7a522b6487de6e96985d223524533493eb9171f0
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6917
      Reviewed-on: https://chromium-review.googlesource.com/848975Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50350}
      c1e9bc02
  14. 03 Jan, 2018 2 commits
    • Bill Budge's avatar
      Revert "[test] Move has unexpected output to outproc." · 1685b5d2
      Bill Budge authored
      This reverts commit 71605b3e.
      
      Reason for revert: Seems to break static-initializers step:
      https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156
      
      Original change's description:
      > [test] Move has unexpected output to outproc.
      > 
      > Expected outcomes optimized to serialize [PASS] as None.
      > 
      > Keeping expected outcomes inside output processors should be
      > optimized in the future. Few possible optimizations:
      > - separate classes for tests that are expected to PASS - done as
      > an example in mozilla test suite.
      > - cache output processors inside testcase.
      > - share output processors between copies of the same test - needs
      > some updates to the create_variant to update outproc only if
      > expected outcomes changed.
      > 
      > Bug: v8:6917
      > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      > Reviewed-on: https://chromium-review.googlesource.com/843025
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50347}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      
      Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6917
      Reviewed-on: https://chromium-review.googlesource.com/849572Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50348}
      1685b5d2
    • Michal Majewski's avatar
      [test] Move has unexpected output to outproc. · 71605b3e
      Michal Majewski authored
      Expected outcomes optimized to serialize [PASS] as None.
      
      Keeping expected outcomes inside output processors should be
      optimized in the future. Few possible optimizations:
      - separate classes for tests that are expected to PASS - done as
      an example in mozilla test suite.
      - cache output processors inside testcase.
      - share output processors between copies of the same test - needs
      some updates to the create_variant to update outproc only if
      expected outcomes changed.
      
      Bug: v8:6917
      Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      Reviewed-on: https://chromium-review.googlesource.com/843025
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50347}
      71605b3e
  15. 21 Dec, 2017 1 commit
  16. 20 Dec, 2017 2 commits
  17. 19 Dec, 2017 1 commit
  18. 18 Dec, 2017 1 commit
    • Josh Wolfe's avatar
      Enable --harmony-function-tostring by default · c3dda0bb
      Josh Wolfe authored
      Update tests to work with new behavior.
      
      This feature is shipping in Firefox 54, so compatibility risk is low.
      
      R=littledan@chromium.org, adamk@chromium.org, caitp@igalia.com
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Bug: v8:4958
      Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
      Change-Id: Ib16d19468cf935f961d7bcd856ebbeb5692d3e61
      Reviewed-on: https://chromium-review.googlesource.com/546941
      Commit-Queue: Josh Wolfe <jwolfe@igalia.com>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50178}
      c3dda0bb
  19. 13 Dec, 2017 3 commits
  20. 20 Nov, 2017 1 commit
  21. 17 Nov, 2017 1 commit
  22. 16 Nov, 2017 1 commit
  23. 03 Nov, 2017 1 commit
  24. 30 Oct, 2017 1 commit
  25. 27 Oct, 2017 1 commit
  26. 05 Sep, 2017 1 commit
  27. 04 Sep, 2017 2 commits
  28. 02 Aug, 2017 1 commit