1. 28 Aug, 2020 1 commit
  2. 14 Apr, 2020 1 commit
  3. 18 Feb, 2020 1 commit
  4. 25 Nov, 2019 1 commit
  5. 15 Oct, 2019 1 commit
  6. 23 Jul, 2019 1 commit
  7. 07 Mar, 2019 1 commit
  8. 09 Jan, 2019 1 commit
  9. 12 Dec, 2018 1 commit
  10. 21 Aug, 2018 2 commits
    • Ben L. Titzer's avatar
      Reland "[asmjs] Properly validate asm.js heap sizes" · 438e7ec6
      Ben L. Titzer authored
      This is a reland of 5c309271
      (the CL was reverted because of a Chromium test that is now fixed)
      
      Original change's description:
      > Reland "[asmjs] Properly validate asm.js heap sizes"
      >
      > This is a reland of 5d69010e
      >
      > Original change's description:
      > > [asmjs] Properly validate asm.js heap sizes
      > >
      > > Enforce both engine limitations and spec (http://asmjs.org/spec/latest/)
      > > limitations on the size of asm.js heaps.
      > >
      > > R=clemensh@chromium.org
      > > CC=​mstarzinger@chromium.org
      > >
      > > Bug: chromium:873600
      > > Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd
      > > Reviewed-on: https://chromium-review.googlesource.com/1174411
      > > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#55163}
      >
      > Bug: chromium:873600
      > Change-Id: Id24070bda3aafb9e1a32af0732a1b18f633ef932
      > Reviewed-on: https://chromium-review.googlesource.com/1179681
      > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55193}
      
      Bug: chromium:873600
      Change-Id: I6eca2a89589070837b109278f964fc8e9a0fd6f1
      Reviewed-on: https://chromium-review.googlesource.com/1183081Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55249}
      438e7ec6
    • Aseem Garg's avatar
      Revert "Reland "[asmjs] Properly validate asm.js heap sizes"" · dd65e4b8
      Aseem Garg authored
      This reverts commit 5c309271.
      
      Reason for revert: Broke fast/workers/worker-shared-asm-buffer.html
      
      Original change's description:
      > Reland "[asmjs] Properly validate asm.js heap sizes"
      >
      > This is a reland of 5d69010e
      >
      > Original change's description:
      > > [asmjs] Properly validate asm.js heap sizes
      > >
      > > Enforce both engine limitations and spec (http://asmjs.org/spec/latest/)
      > > limitations on the size of asm.js heaps.
      > >
      > > R=clemensh@chromium.org
      > > CC=​mstarzinger@chromium.org
      > >
      > > Bug: chromium:873600
      > > Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd
      > > Reviewed-on: https://chromium-review.googlesource.com/1174411
      > > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#55163}
      >
      > Bug: chromium:873600
      > Change-Id: Id24070bda3aafb9e1a32af0732a1b18f633ef932
      > Reviewed-on: https://chromium-review.googlesource.com/1179681
      > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55193}
      
      TBR=mstarzinger@chromium.org,titzer@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:873600
      Change-Id: I5845c584c7ac399b9b7939f5fd50c09b7b2cc3d2
      Reviewed-on: https://chromium-review.googlesource.com/1182616
      Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
      Reviewed-by: 's avatarAseem Garg <aseemgarg@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55242}
      dd65e4b8
  11. 17 Aug, 2018 1 commit
  12. 16 Aug, 2018 2 commits
  13. 25 Sep, 2017 1 commit
  14. 04 Sep, 2017 1 commit
  15. 10 Aug, 2017 1 commit
  16. 02 Aug, 2017 1 commit
  17. 13 Jul, 2017 1 commit
  18. 10 Jul, 2017 1 commit
  19. 20 Jun, 2017 1 commit
    • Michael Starzinger's avatar
      [asm.js] Ensure coercion of imports is non-observable. · 21cbc914
      Michael Starzinger authored
      This makes sure that the coercion of global import values to numbers
      remains non-observable to JavaScript. It allows instantiation failures
      to fall back to JavaScript proper without accidentally causing some
      side-effect to happen twice. Also coercions might invalidate previous
      checks done during linking or throw exceptions.
      
      R=clemensh@chromium.org
      TEST=mjsunit/regress/regress-6431
      BUG=v8:6431
      
      Change-Id: Ibe2f7a336bc0fb25532d526746ecc802e04bbd5c
      Reviewed-on: https://chromium-review.googlesource.com/512544
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46051}
      21cbc914
  20. 01 Jun, 2017 1 commit
  21. 23 May, 2017 1 commit
  22. 12 May, 2017 1 commit
  23. 11 May, 2017 1 commit
  24. 10 May, 2017 2 commits
  25. 09 May, 2017 1 commit
  26. 05 May, 2017 1 commit
  27. 04 May, 2017 1 commit
  28. 03 May, 2017 1 commit
  29. 27 Apr, 2017 1 commit
  30. 26 Apr, 2017 2 commits
  31. 25 Apr, 2017 1 commit
  32. 21 Apr, 2017 1 commit
  33. 13 Apr, 2017 1 commit
    • Michael Starzinger's avatar
      [asm.js] Test and fix "|0" annotation of calls. · f0946038
      Michael Starzinger authored
      This fixes the validation of "|0" annotations of call sites that are
      used to indicate a "signed" return type of functions. We use lookahead
      during call validation and request deferred validation as part of the
      actual OR-expression. Special care has to be taken to get precedence
      levels of all involved operators right.
      
      R=clemensh@chromium.org
      TEST=mjsunit/asm/call-annotation
      BUG=v8:6183
      
      Change-Id: If0586f669e7cee26a13425b0fd9f41098e852d68
      Reviewed-on: https://chromium-review.googlesource.com/475871
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#44639}
      f0946038
  34. 11 Apr, 2017 1 commit
  35. 28 Mar, 2017 2 commits
    • bradnelson's avatar
      [wasm][asm.js] Fix and enable several asm.js tests with the new parser. · a84da1c3
      bradnelson authored
      Fix a few items broken during review of scanner + parser:
      * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit).
      * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO).
      
      Also fix:
      * Drop test based on constant expression evaluation in main parser
      * Support constant defined based on existing constant.
      * Type constants as signed.
      * Added a check that all used functions are defined eventually.
      * Zone allocate strings for simplicity (TODOs to refactor better).
      
      BUG=v8:6090
      BUG=v8:4203
      R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org
      
      Review-Url: https://codereview.chromium.org/2771183002
      Cr-Original-Commit-Position: refs/heads/master@{#44200}
      Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df
      Review-Url: https://codereview.chromium.org/2771183002
      Cr-Commit-Position: refs/heads/master@{#44203}
      a84da1c3
    • bradnelson's avatar
      Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new... · f8973f1c
      bradnelson authored
      Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (patchset #10 id:180001 of https://codereview.chromium.org/2771183002/ )
      
      Reason for revert:
      Fails on gc-stress.
      
      Original issue's description:
      > [wasm][asm.js] Fix and enable several asm.js tests with the new parser.
      >
      > Fix a few items broken during review of scanner + parser:
      > * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit).
      > * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO).
      >
      > Also fix:
      > * Drop test based on constant expression evaluation in main parser
      > * Support constant defined based on existing constant.
      > * Type constants as signed.
      > * Added a check that all used functions are defined eventually.
      > * Zone allocate strings for simplicity (TODOs to refactor better).
      >
      > BUG=v8:6090
      > BUG=v8:4203
      > R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org
      >
      > Review-Url: https://codereview.chromium.org/2771183002
      > Cr-Commit-Position: refs/heads/master@{#44200}
      > Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df
      
      TBR=clemensh@chromium.org,bradnelson@google.com,marja@chromium.org,mstarzinger@chromium.org,vogelheim@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:6090
      
      Review-Url: https://codereview.chromium.org/2782613002
      Cr-Commit-Position: refs/heads/master@{#44201}
      f8973f1c