- 18 Jun, 2021 2 commits
-
-
Igor Sheludko authored
In order to avoid unnecessary conversions to CodeT and back this CL: - makes compiler::CompileCWasmEntry() return CodeT, - makes Execution::CallWasm() accept CodeT. Bug: v8:11880 Change-Id: Ic4b7b5f476c6efcfca4bc116ecd45cdee9f0c6c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2971743Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75247}
-
Dan Elphick authored
The adding of base:: was mostly prepared using git grep and sed: git grep -l <pattern> | grep -v base/vector.h | \ xargs sed -i 's/\b<pattern>\b/base::<pattern>/ with lots of manual clean-ups due to the resulting v8::internal::base::Vectors. #includes were fixed using: git grep -l "src/utils/vector.h" | \ axargs sed -i 's!src/utils/vector.h!src/base/vector.h!' Bug: v8:11879 Change-Id: I3e6d622987fee4478089c40539724c19735bd625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968412Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75243}
-
- 02 Jun, 2021 1 commit
-
-
Jakob Kummerow authored
This instruction is a non-standard V8-only experiment for now, hidden behind the --experimental-wasm-gc-experiments flag. The motivation is to provide a way to set up non-canonicalized RTT hierarchies, to enable expressing the type system of Java-like languages in terms of WasmGC constructs. Bug: v8:7748 Change-Id: Idf1c18e9944c983f40f1e01b2032ee5fdc2fd81b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930478Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74920}
-
- 31 May, 2021 1 commit
-
-
Manos Koukoutos authored
This will be thrown during array allocations if the requested size is larger than kV8MaxWasmArrayLength. Additional changes: - In test-gc.cc, add the possibility to check against the trap message in CheckHasThrown. - Small reorganization of WasmGCTester in test-gc.cc. Bug: v8:7748 Change-Id: I6f74b525bd7087fcc66f43c451ef130df022b0f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922247Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74867}
-
- 27 May, 2021 1 commit
-
-
Manos Koukoutos authored
Changes: - Add --experimental-wasm-gc-experiments flag. - Add array.copy opcode. Implement it in decoding and code generation behind the new flag. - Add WasmCodeBuilder::BoundsCheckArrayCopy. Move BoundsCheckArray to the private section. - Add WasmArrayCopy and WasmArrayCopyWithChecks builtin. - Add WasmArrayCopy runtime function. - Add WasmArray::ElementSlot. - Always print two hex digits in CHECK_PROTOTYPE_OPCODE. - In test-gc, print the thrown-error message if the function should not throw. - In test-gc, add GetResultObject with one argument. Bug: v8:7748 Change-Id: I58f4d37e254154596cdef5e78482b55260dd3782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912729 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74806}
-
- 21 May, 2021 1 commit
-
-
Manos Koukoutos authored
Additional changes: - Clean up liftoff implementation of br_on_*. - Bundle operations everywhere based on operation rather than type. - Remove reference argument from WASM_BR_ON_* macros, to bring them in sync with WASM_BR_ON_CAST. - Add missing function decoding unittests for br_on_*. Bug: v8:7748 Change-Id: I5f5ebfac5b50b5a9a201acb435344d7471326242 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909857Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74709}
-
- 20 May, 2021 1 commit
-
-
Manos Koukoutos authored
This is a reland of 8f39a585 Changes compared to original: Change the type of arguments of WASM_I32V from byte to int for MSVC compatibility. Original change's description: > [wasm-gc] Implement br_on_cast_fail > > Bug: v8:7748 > Change-Id: I7894ad51ccf8ac41a5081c272a583a4ff25c1835 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900225 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74652} Bug: v8:7748 Change-Id: I39f39ff6979382f5618683a8e7754f56df4ec9e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905599Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74689}
-
- 19 May, 2021 2 commits
-
-
Sathya Gunasekaran authored
This reverts commit 8f39a585. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc/17874/blamelist Original change's description: > [wasm-gc] Implement br_on_cast_fail > > Bug: v8:7748 > Change-Id: I7894ad51ccf8ac41a5081c272a583a4ff25c1835 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900225 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74652} Bug: v8:7748 Change-Id: I90ca2d789e943cd00c2344e2d333c9175fcedee5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903482 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74658}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I7894ad51ccf8ac41a5081c272a583a4ff25c1835 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900225 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74652}
-
- 14 May, 2021 1 commit
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I9a4dad42f433ce0adf928461cf0db589df3d69e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897087 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74571}
-
- 15 Apr, 2021 1 commit
-
-
Manos Koukoutos authored
Changes: - Implement function subtyping in wasm-subtyping.cc. - Add Signature::Build(), which takes initializer lists for the return and parameter types. - Only throw kTrapFuncSigMismatch in call_indirect, change that trap's message. - Add a missing "return 0" in function-body-decoder-impl.h - Fix a faulty check in wasm-objects.cc. - Improve some comments. - Write tests. Improve readability of subtyping-unittest. Bug: v8:7748 Change-Id: I1caba09d5bd01cfd4d6125f300cd9c16af7aba99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2822633Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73972}
-
- 29 Mar, 2021 1 commit
-
-
Manos Koukoutos authored
Bug: v8:7748, v8:11602 Change-Id: I007e80de0114cc651c8eb2ec825fc130a4b386c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2790175Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73704}
-
- 24 Mar, 2021 1 commit
-
-
Andreas Haas authored
LiftoffCompiler::ProcessParameter assumed that by processing parameters in the order of their index, register parameters get processed first, and that for processing stack parameters it can already use all registers as temp registers. This is not true with reference type parameters, because registers always first get assigned to value type parameters even when there is a reference type parameter with a lower index. Because of this incorrect assumption register parameters were overwritten by reference type parameters on the stack that got processed first. With this CL, only those registers get used as temp registers for reference type parameters that are not used for parameters. CC=jkummerow@chromium.org, clemensb@chromium.org R=thibaudm@chromium.org Bug: v8:11596 Change-Id: I30ed7f073147df0bd81b9ef4d2b2a54d7badc937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784560 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73635}
-
- 17 Mar, 2021 1 commit
-
-
Manos Koukoutos authored
Changes: - Remove the restriction that ref.test, ref.cast and br_on_cast may only cast to subtypes of the cast object's type. Optimize unrelated type casts in the decoder. Add tests. - Generalize Unreachable() interface function to Trap(TrapReason). - Fix rtt.sub to be able to accept an rtt without depth. Modify related test accordingly. - Type local.tee according to the local's type as opposed to the value's type. Bug: v8:7748, v8:11541 Change-Id: I4d1846a2cfda891d32a9c1ed26781e4518d4cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756210Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73461}
-
- 10 Feb, 2021 1 commit
-
-
Manos Koukoutos authored
By disengaging it from 'let' which is not implemented in liftoff yet. Bug: v8:7748 Change-Id: I191695767bf8c6153f70d509dd13ff734fe75e01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2676631Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72620}
-
- 09 Feb, 2021 1 commit
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id84459c496f7e57b36c3acd13a91d39b7e9fb15f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2676630Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72594}
-
- 02 Feb, 2021 1 commit
-
-
Manos Koukoutos authored
Changes: - Rename ObjectReferenceKnowledgs::object_must_be_data_ref to reference_kind, introduce an enum to describe it. - In both compilers, remove the dynamic check whether the object is an array/struct. This is known statically. Instead, if we are checking for a function, just check for rtt equality and exit. - Remove is_data_ref_type(), replace it in the compilers with calls to has_signature(). - Restructure AllocateSubRtt() to handle function rtts properly. - Add a couple execution tests. Bug: v8:7748 Change-Id: I46fbbfe2f2a7d29b583de0d536d71c534b98322f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2661460Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72477}
-
- 01 Feb, 2021 2 commits
-
-
Manos Koukoutos authored
Changes: - Remove an obsolete TODO from wasm-module-builder. - Replace CHECK with gTest's EXPECT in unittests. - Remove setting of --experimental-wasm-liftoff-extern-ref in wasm-gc. - Test test-gc/JSAccess with Liftoff. - Remove useless #undef's from module-decoder-unittest. Change-Id: I11b4a3dde9683cc9c7d1eb89b1a63e1859505aad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659063 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72455}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I56a5e0a3e3141ef781a816656dc50d0d0a1573cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659258 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72452}
-
- 31 Jan, 2021 1 commit
-
-
Manos Koukoutos authored
br_on_* instructions need a precisely typed branch target, as opposed to being treated like regular br instructions. Bug: v8:7748 Change-Id: Iedace79faf59d61cf2ce5ac88e633e07b5a2a43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655507 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72450}
-
- 29 Jan, 2021 1 commit
-
-
Manos Koukoutos authored
The latest wasm-gc spec introduces classification functions {ref.as, ref.is, br_on}_{func, data, i31}, to cast values typed as anyref and eqref. Bug: v8:7748 Change-Id: I39c288e4a4c96466e64e490f164ccc76b00011ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655506 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72434}
-
- 28 Jan, 2021 4 commits
-
-
Manos Koukoutos authored
As per the latest wasm-gc spec, type checks are only allowed from subtypes of dataref and funcref. To cast from a more general type, specialized classification instructions need to be used (will come later). Bug: v8:7748 Change-Id: I29de48f445d652c5fc4e266d82e7d2e32cd7b6d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649262 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72408}
-
Manos Koukoutos authored
As per the latest wasm-gc spec, all immediate arguments are removed from ref.cast and ref.test. Bug: v8:7748 Change-Id: I5839103276c4c5d51f3fa82a21cf2447cbb8ecaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649261 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72405}
-
Manos Koukoutos authored
As per latest wasm-gc spec, the data heap type is a subtype of eq and a supertype of all array and struct types. The heap type expected for arrays and structs when interacting with JS changes from eq to data. Bug: v8:7748 Change-Id: Idd1670b9e47acc95c098559e674c629ea44ca49d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649044 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72399}
-
Manos Koukoutos authored
As per the latest wasm-gc spec, rtts now have optional depth, with (rtt n type) <: (rtt type) for every depth n. Liftoff compilation for type checks without depth are not supported yet. Bug: v8:7748 Change-Id: I4971875e6a42db6d333b61ca5e2996e875f39f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649043Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72395}
-
- 27 Jan, 2021 2 commits
-
-
Manos Koukoutos authored
According to the new wasm-gc spec, ref.cast should forward a null input without trapping. Bug: v8:7748 Change-Id: Ifee17f02a572e7028c14482bc94f0e1c7fc82a5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2647261 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72358}
-
Manos Koukoutos authored
This is a reland of b77deeca Changes compared to original: Add explicit narrowing casts in tests for MSVC. Original change's description: > [wasm-gc] Remove abstract rtts > > In the latest wasm-gc spec, rtts of abstract types are no longer > allowed. Consequently, canonical rtts of concrete types always have > a depth of 0. > > Changes: > - Change the immediate argument of rtts to a type index over a heap > type. Abstract it with TypeIndexImmediate in function body decoding. > This affects: > value_type.h, read_value_type(), decoding of relevant opcodes, > wasm subtyping, WasmInitExpr, consume_init_expr(), and > wasm-module-builder.cc. > - In function-body-decoder-impl.h, update rtt.canon to always produce > an rtt of depth 0. > - Pass a unit32_t type index over a HeapType to all rtt-related > utilities. > - Remove infrastructure for abstract-type rtts from the wasm compilers, > setup-heap-internal.cc, roots.h, and module-instantiate.cc. > - Remove ObjectReferenceKnowledge::rtt_is_i31. Remove related branches > from ref.test, ref.cast and br_on_cast implementations in the wasm > compilers. > - Remove unused 'parent' field from WasmTypeInfo. > - Make the parent argument optional in NewWasmTypeInfo, CreateStructMap, > and CreateArrayMap. > - Use more convenient arguments in IsHeapSubtypeOf. > - Update tests. > > Bug: v8:7748 > Change-Id: Ib45efe0741e6558c9b291fc8b4a75ae303146bdc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642248 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72321} Bug: v8:7748 Change-Id: I22b204b486fd185077cd6c7f15d492f5143f48fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650207 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72355}
-
- 26 Jan, 2021 2 commits
-
-
Clemens Backes authored
This reverts commit b77deeca. Reason for revert: MSVC compile fails: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc/16535/overview Original change's description: > [wasm-gc] Remove abstract rtts > > In the latest wasm-gc spec, rtts of abstract types are no longer > allowed. Consequently, canonical rtts of concrete types always have > a depth of 0. > > Changes: > - Change the immediate argument of rtts to a type index over a heap > type. Abstract it with TypeIndexImmediate in function body decoding. > This affects: > value_type.h, read_value_type(), decoding of relevant opcodes, > wasm subtyping, WasmInitExpr, consume_init_expr(), and > wasm-module-builder.cc. > - In function-body-decoder-impl.h, update rtt.canon to always produce > an rtt of depth 0. > - Pass a unit32_t type index over a HeapType to all rtt-related > utilities. > - Remove infrastructure for abstract-type rtts from the wasm compilers, > setup-heap-internal.cc, roots.h, and module-instantiate.cc. > - Remove ObjectReferenceKnowledge::rtt_is_i31. Remove related branches > from ref.test, ref.cast and br_on_cast implementations in the wasm > compilers. > - Remove unused 'parent' field from WasmTypeInfo. > - Make the parent argument optional in NewWasmTypeInfo, CreateStructMap, > and CreateArrayMap. > - Use more convenient arguments in IsHeapSubtypeOf. > - Update tests. > > Bug: v8:7748 > Change-Id: Ib45efe0741e6558c9b291fc8b4a75ae303146bdc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642248 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72321} TBR=ulan@chromium.org,jkummerow@chromium.org,manoskouk@chromium.org Change-Id: I2f0d97f1a34f7c81c5a97d7c37925cb84c66eea3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650206Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72322}
-
Manos Koukoutos authored
In the latest wasm-gc spec, rtts of abstract types are no longer allowed. Consequently, canonical rtts of concrete types always have a depth of 0. Changes: - Change the immediate argument of rtts to a type index over a heap type. Abstract it with TypeIndexImmediate in function body decoding. This affects: value_type.h, read_value_type(), decoding of relevant opcodes, wasm subtyping, WasmInitExpr, consume_init_expr(), and wasm-module-builder.cc. - In function-body-decoder-impl.h, update rtt.canon to always produce an rtt of depth 0. - Pass a unit32_t type index over a HeapType to all rtt-related utilities. - Remove infrastructure for abstract-type rtts from the wasm compilers, setup-heap-internal.cc, roots.h, and module-instantiate.cc. - Remove ObjectReferenceKnowledge::rtt_is_i31. Remove related branches from ref.test, ref.cast and br_on_cast implementations in the wasm compilers. - Remove unused 'parent' field from WasmTypeInfo. - Make the parent argument optional in NewWasmTypeInfo, CreateStructMap, and CreateArrayMap. - Use more convenient arguments in IsHeapSubtypeOf. - Update tests. Bug: v8:7748 Change-Id: Ib45efe0741e6558c9b291fc8b4a75ae303146bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642248 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72321}
-
- 25 Jan, 2021 1 commit
-
-
Manos Koukoutos authored
According to the latest wasm-gc spec, the type immediate for the argument's heap type is no longer required. This CL also adds a missing check that the rtt immediate is a subtype of the argument's type. Bug: v8:7742 Change-Id: I627002d1c4bdb4ca3f2181d2f4b659ce3e95cb2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642246 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72287}
-
- 22 Jan, 2021 1 commit
-
-
Jakob Kummerow authored
This implements support for the following instructions: ref.func, call_ref, return_call_ref Bug: v8:7748,v8:9495 Change-Id: If5bdc2b9bc2347de056de2917430b8d9dc901c53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632591 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72270}
-
- 12 Jan, 2021 1 commit
-
-
Manos Koukoutos authored
Changes: - Rename PassThrough -> Forward in function-body-decoder. - Introduce IsHeapSubtypeOf in subtyping. - Do not push a redundant bottom value in br_on_null, remove fallthrough. Also, improve code structure. - Update a couple of comments. Bug: v8:7748 Change-Id: I8d23cd3829c5504156ace595f8ac86c511c9f5e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2611250 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72034}
-
- 09 Jan, 2021 1 commit
-
-
Manos Koukoutos authored
Invoking Goto in graph-builder-interface from inside a 'let' can cause the number of locals between source and target ssa environment to be different. This CL addresses this bug and adds a few unit tests. Unfortunately, after this change we have to resort to always using copy-constructors for SsaEnv, which might cause slowdown in decoding. Bug: v8:9495 Change-Id: Idf5ace6c7563eff9d774d402f3a81e77959556ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2614062Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#71993}
-
- 08 Jan, 2021 1 commit
-
-
Jakob Kummerow authored
This is a reland of a3ce2f6d (No changes; was reverted because a dependency was reverted.) Original change's description: > [wasm-gc] Liftoff support part 5: i31 > > This implements support for i31.get_s and i31.get_u. > > Bug: v8:7748 > Change-Id: Icbfddbc2ff46b4eb6bf3edf7b3a794f9797361d4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595309 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71808} Bug: v8:7748 Change-Id: Id8e66cab285d2a36fcd712b92a522e83dea93193 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2617089Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71984}
-
- 17 Dec, 2020 4 commits
-
-
Clemens Backes authored
The opcodes were renamed long ago, but the macros were still using the old syntax. This CL was created using the following script (for WASM_GET_GLOBAL and WASM_SET_GLOBAL): ag -l WASM_GET_GLOBAL | xargs -L 1 sed -i 's/\bWASM_GET_GLOBAL\b/WASM_GLOBAL_GET/g' R=ahaas@chromium.org Bug: v8:11074 Change-Id: I3a9bd64f6e09ce97dae6d4132c224350dc079c0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2597576 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71836}
-
Clemens Backes authored
The opcodes were renamed long ago, but the macros were still using the old syntax. This CL was created using the following command (for WASM_GET_LOCAL, WASM_SET_LOCAL, and WASM_TEE_LOCAL): ag -l WASM_GET_LOCAL | xargs -L 1 sed -i 's/\bWASM_SET_LOCAL\b/WASM_LOCAL_SET/g' R=ahaas@chromium.org Bug: v8:11074 Change-Id: I0018bea185030be29344e66e59706fed183cc2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595446Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71835}
-
Jakob Kummerow authored
This is a reland of dc369749 Changes: relaxed --liftoff-only mode to still allow bailing out due to missing CPU support. Original change's description: > [wasm-gc] Liftoff support part 4: subtyping > > This adds support for the following instructions: > struct.new_default, rtt.sub, ref.test, ref.cast > > Bug: v8:7748 > Change-Id: I7423ddd7a83c80cb1e82c620780c27bec59ec762 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593341 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71805} Bug: v8:7748 Change-Id: If31fcee5e7e173d7c2a6e1c624f4ff04cec7fe9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596338 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71823}
-
Jakob Kummerow authored
This reverts commit a3ce2f6d. Reason for revert: speculative revert due to waterfall unhappiness (looks like bot weirdness though?) Original change's description: > [wasm-gc] Liftoff support part 5: i31 > > This implements support for i31.get_s and i31.get_u. > > Bug: v8:7748 > Change-Id: Icbfddbc2ff46b4eb6bf3edf7b3a794f9797361d4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595309 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71808} TBR=jkummerow@chromium.org,clemensb@chromium.org Change-Id: I5050f16fdaf355d178935f523a9bec516302d2a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596337Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71810}
-
- 16 Dec, 2020 2 commits
-
-
Jakob Kummerow authored
This implements support for i31.get_s and i31.get_u. Bug: v8:7748 Change-Id: Icbfddbc2ff46b4eb6bf3edf7b3a794f9797361d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595309 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71808}
-
Shu-yu Guo authored
This reverts commit dc369749. Reason for revert: nosse variant failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/33279/overview Original change's description: > [wasm-gc] Liftoff support part 4: subtyping > > This adds support for the following instructions: > struct.new_default, rtt.sub, ref.test, ref.cast > > Bug: v8:7748 > Change-Id: I7423ddd7a83c80cb1e82c620780c27bec59ec762 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593341 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71805} TBR=jkummerow@chromium.org,clemensb@chromium.org Change-Id: I06bb493852223aecf221c9149bc7b034b1fb13ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596497Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71806}
-