- 23 Jul, 2021 1 commit
-
-
Vicky Kontoura authored
This CL adds support for classes with methods. More specifically: - A new ValueSerializer is added and classes are serialized separetely from functions, although the common parts are handled in the same way and abstracted away. - The function prototype is serialized as an object and any missing information is set up again during deserialization. - FunctionFlagsToFunctionKinds() is updated to allow for more function kinds. - Context serialization is updated to support serializing BlockContexts and creating ScopeInfos of type CLASS_SCOPE. - Map serialization is updated to support properties with custom attributes. Bug: v8:11525, v8:11706 Change-Id: I16ca7cbc17b1811721081cda05124ce36073f9be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3006416 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75893}
-
- 18 Jun, 2021 1 commit
-
-
Dan Elphick authored
The adding of base:: was mostly prepared using git grep and sed: git grep -l <pattern> | grep -v base/vector.h | \ xargs sed -i 's/\b<pattern>\b/base::<pattern>/ with lots of manual clean-ups due to the resulting v8::internal::base::Vectors. #includes were fixed using: git grep -l "src/utils/vector.h" | \ axargs sed -i 's!src/utils/vector.h!src/base/vector.h!' Bug: v8:11879 Change-Id: I3e6d622987fee4478089c40539724c19735bd625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968412Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75243}
-
- 16 Jun, 2021 1 commit
-
-
Mike Stanton authored
In heap-refs.cc, GetOwnFastDataPropertyFromHeap() bottlenecks reading a fast property. To make it safe to use from the background thread we need to verify the object didn't shrink, and risk an out of heap bounds read. Bug: v8:7790 Change-Id: Idebbe0ffea089bf2a70aa7d611618430169082fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928185Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#75186}
-
- 12 Jun, 2021 1 commit
-
-
Marja Hölttä authored
Drive-by: Also add deferred function references. Bug: v8:11525 Change-Id: If546f2e6c5a991372f1b99dac149504941a24b3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951731 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75110}
-
- 11 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL fixes WebSnapshotDeserializer::DeserializeContexts(), so that the new FunctionContext is allocated after the ScopeInfo is set up. Bug: v8:11525, v8:11706 Change-Id: Idb14c0fa5b5d51827e9f208f54c82a94535343a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953292 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75099}
-
- 10 Jun, 2021 1 commit
-
-
Marja Hölttä authored
This allows forward references among objects as well as contexts referencing objects. Bug: v8:11525 Change-Id: I45fd132344c5e0125d8287c668eac444fe1f8802 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947408Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75069}
-
- 09 Jun, 2021 1 commit
-
-
Dan Elphick authored
By moving this out of counters.h, counters.h no longer needs to depend on isolate.h. Change-Id: Ic5272e3b3a729c0a438124dc5cdc1835817f3341 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2949098 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75055}
-
- 08 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
Currently, the serializer and deserializer assume that all top-level declarations to be serialized will be objects. This CL removes this assumption. Bug: v8:11525, v8:11706 Change-Id: I5acf5e7a3b73aba5ffc5b1d5eb9cb51b3804a4af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945178Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#75020}
-
- 07 Jun, 2021 2 commits
-
-
Camillo Bruni authored
- Add new Builtin enum - Move Builtins::Name:kXXX to Builtin::kXXX - Update existing code Follow CLs will unify the mix of using int builtin-ids and Builtins::Name to only use the new Builtin enum and changing it to an enum class. Change-Id: Ib39aa45a25696acdf147f46392901b1e051deaa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905592 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#74995}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I0ac9f252e0de16480036e3630edf7efefe8d8571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928501Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74968}
-
- 03 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL updates WebSnapshotSerializer::TakeSnapshot() to accept exports as a Local<PrimitiveArray>. Bug: v8:11525, v8:11706 Change-Id: Ie3a752ac7dbcc51fc4fb258eb44ce42d0cfc6a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930173Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74936}
-
- 02 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL fixes WebSnapshotDeserializer::DeserializeFunctions(), so that the new Script is created after both the SharedFunctionInfoTable and SharedFunctionInfo are allocated. Also, this CL re-enables mjsunit tests for web snapshots (disabled in https://chromium-review.googlesource.com/c/v8/v8/+/2931806). Bug: v8:11842, v8:11525, v8:11706 Change-Id: I13503eab3fa70b128ba1faae75eed62b6c5bb636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933145Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74923}
-
- 01 Jun, 2021 1 commit
-
-
Vicky Kontoura authored
This CL fixes the deserialization of the map for empty objects, so that the initial empty map is used. Bug: chromium:1213851, v8:11525, v8:11706 Change-Id: I37de0b147b9c89ead9c96f776e5fbf88da4630cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928192 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74880}
-
- 19 May, 2021 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I1c8e2346ed1581dc6b44e8df203d1ad0bcd1639a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2883357 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74664}
-
- 14 May, 2021 1 commit
-
-
Vicky Kontoura authored
This CL adds support for regular expressions. To serialize a regular expression, the pattern and flags are extracted and serialized as strings. Also, JSRegExp::StringFromFlags() is introduced to allow for transforming back from JSRegExp::Flags to the corresponding flag string. To verify that this implementation is on par with RegExp.prototype.flags, unittests are introduced under regexp/regexp-unittest.cc and RegExpBuiltinsAssembler::FlagsGetter() is updated to include a slow path that calls JSRegExp::StringFromFlags() through a runtime function. Bug: v8:11525, v8:11706 Change-Id: I9cad4c464129ba1cbf64672130d8410730d7d679 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878751 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74566}
-
- 30 Apr, 2021 1 commit
-
-
Vicky Kontoura authored
This CL adds support for oddballs false, true, null and undefined. Bug: v8:11525, v8:11706 Change-Id: I0dc870f05578c0eb9ff06bf2ccd2474e18464566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856843 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74304}
-
- 29 Apr, 2021 1 commit
-
-
Vicky Kontoura authored
This is a reland of 7dcc70b8 Original change's description: > [web snapshot] Support numbers > > This CL adds support for integer and double values in web snapshots. > > Bug: v8:11525, v8:11706 > Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 > Commit-Queue: Vicky Kontoura <vkont@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74259} Bug: v8:11525 Bug: v8:11706 Change-Id: Ia5912ab22db24559c6d0f028a8e744ec448e2250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859942Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74286}
-
- 28 Apr, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit 7dcc70b8. Reason for revert: Fails to compile on V8 Linux gcc https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20gcc/11474/overview Original change's description: > [web snapshot] Support numbers > > This CL adds support for integer and double values in web snapshots. > > Bug: v8:11525, v8:11706 > Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 > Commit-Queue: Vicky Kontoura <vkont@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74259} Bug: v8:11525 Bug: v8:11706 Change-Id: If107fb890c28a60c2d87859f634fdafeb73dc6c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857156 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74260}
-
Vicky Kontoura authored
This CL adds support for integer and double values in web snapshots. Bug: v8:11525, v8:11706 Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74259}
-
- 16 Apr, 2021 1 commit
-
-
Camillo Bruni authored
- This is a reland of d435eaa5 - Fix vtunedomain Original change's description: > [api] Add v8::Isolate::ThrowError helper > > Add a ThrowError helper to encourage throwing full Error objects > instead of just v8::Strings. > > Bug: v8:11195 > Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73958} Bug: v8:11195 Change-Id: I3cffaa4f122d74705476c3f8791b549f85d8c87b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826534Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73993}
-
- 14 Apr, 2021 2 commits
-
-
Maya Lekova authored
This reverts commit d435eaa5. Reason for revert: Breaks compilation on the vtunejit bot, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20vtunejit/41247/overview Original change's description: > [api] Add v8::Isolate::ThrowError helper > > Add a ThrowError helper to encourage throwing full Error objects > instead of just v8::Strings. > > Bug: v8:11195 > Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73958} Bug: v8:11195 Change-Id: I2773d8ca7d73e7952d274381e2e0a2e5733a83da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826533 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73959}
-
Camillo Bruni authored
Add a ThrowError helper to encourage throwing full Error objects instead of just v8::Strings. Bug: v8:11195 Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73958}
-
- 12 Apr, 2021 1 commit
-
-
Marja Hölttä authored
The de-duplication happens when 1) we have a JSFunction for an outer function and a JSFunction for its inner function in the snapshot and 2) we call the outer function again after deserializing Expectation: the created JSFunction for the inner function uses the SFI which was created when deserializing. Bug: v8:11525 Change-Id: I80933514873e857452585317248fa34913d8d8e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794438Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73900}
-
- 29 Mar, 2021 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I60566072f0af920fdf40ea5f1b80480910a224ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778298 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73705}
-
- 22 Mar, 2021 1 commit
-
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I9afd7095764fdb4b15c8a3492078073624b42a11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763869Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73569}
-
- 15 Mar, 2021 1 commit
-
-
Marja Hölttä authored
(Reland: removed the d8 changes, will land them separately.) The minimal implementation which does something useful. Initial machinery for serializing / deserializing objects and functions (only the very simple cases are supported). For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing Previous version: Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288 TBR=leszeks@chromium.org,syg@chromium.org,hpayer@chromium.org Bug: v8:11525 Change-Id: Ia61ed7de36f371d931eff68156ab467723915704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759510Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73401}
-
- 12 Mar, 2021 2 commits
-
-
Bill Budge authored
This reverts commit fb03b88e. Reason for revert: Very speculative revert to make Win64 ASAN bot green: https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20ASAN/17685 Original change's description: > [web snapshots] Web Snapshots Version 0.01 > > The minimal implementation which does something useful. Initial > machinery for serializing / deserializing objects and functions (only > the very simple cases are supported). > > For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing > > Bug: v8:11525 > > Change-Id: I73c4de11285c7912bf9870868d203d4b3d2b4e5f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73371} Bug: v8:11525 Change-Id: I8e1ea8666f2d4d6eac3575a364e0532167dd3316 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757891 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#73383}
-
Marja Hölttä authored
The minimal implementation which does something useful. Initial machinery for serializing / deserializing objects and functions (only the very simple cases are supported). For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing Bug: v8:11525 Change-Id: I73c4de11285c7912bf9870868d203d4b3d2b4e5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73371}
-