- 11 Apr, 2022 1 commit
-
-
Camillo Bruni authored
API logging has not been used in a while and we have valid alternatives: - Runtime call stats - Profiling - Timer events Together they make --log-api superfluous and we can remove it and reduce the number of branches when calling into the V8 API. Change-Id: Ie10f70b61ebdb82166270e7630ebcf20a27c4902 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574549Reviewed-by: Marja Hölttä <marja@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79904}
-
- 08 Apr, 2022 1 commit
-
-
Camillo Bruni authored
- Parse the condensed source position info support for jitted code - Add progress bar/circle to loader - Use temporary Array instead of concatenated strings in escapeField to reduce gc pressure - Use bound functions as event handlers in more places - Various timeline legend fixes: - Fix columns alignment when duration is present - Use fixed width to avoid breaking the UI - Correctly show total/percents for 'All' and 'Selection' entries - Improve usability of filtering buttons: added tooltips and fixed redrawing on filtering Bug: v8:10644 Change-Id: I1275b31b7b13a05d9d6283d3067c1032d2d4819c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574544Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79897}
-
- 04 Apr, 2022 1 commit
-
-
Camillo Bruni authored
- Add references from CodeLogEntry to DeoptLogEntry - Add simple basic blocks in the disassembly code view Bug: v8:10644 Change-Id: I15f3b56751d515b902185b08f9454be3951ffa48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3540142Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79754}
-
- 29 Mar, 2022 1 commit
-
-
Camillo Bruni authored
- Always show the navigation buttons - Format code with fixed-width font - Limit the property-table height for more compact tooltips Bug: v8:10644 Change-Id: I0a0f30056455371bad12b2c679d184948c5b52de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3555772Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79652}
-
- 02 Mar, 2022 1 commit
-
-
Camillo Bruni authored
Profiler: - Track profiler tick durations - Various speedups due to low-level hacking Improve code-panel: - Better register highlighting - Added address navigation and highlighting - Removed obsolete inline source-view Improve script-panel: - Keep current source position focused when showing related entries - Better tool-tip with buttons to focus on grouped entries per source postion - Focus by default on other views when showing related entries Improve timeline-panel: - Initialise event handlers late to avoid errors - Lazy initialise chunks to avoid errors when zooming-in and trying to create tooltips at the same time Change-Id: I3f3c0fd51985aaa490d62f786ab52a4be1eed292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492521Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79329}
-
- 27 Oct, 2021 1 commit
-
-
Camillo Bruni authored
Log FeedbackVectors for optimised code and show them in the code-panel. Drive-by-fixes: - Fix off-by-one in SourcePositionIteration, making sure we always show the last element - Ensure we process all SourcePositions in SourcePositionIteration - Fix first load error in script-panel - Allow expanding all text with SHIFT-click Bug: v8:10644 Change-Id: Ic40a36ea82f0dfa2386c3196f27ca6978cf23643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245931Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77567}
-
- 29 Jun, 2021 1 commit
-
-
Camillo Bruni authored
Add common TimelineTrackStackedBase base class for TimelineTrackTick and TimelineTrackTimer for visualising stacked time ranges that only need rescaling when zooming in. Additional changes: - Highlight matching registers in disassembly - Simplify CodeLogEntry summary for script code - Show event for array items in the property-link-table Bug: v8:10644 Change-Id: I0b37274e12ba55f1c6251b90d39d996ffae7f37e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992716Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75437}
-
- 16 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Show related code object for Maps - Fix opening transition trees - Rename *LogEntry.prototype.codeLogEntry to .code - Show Arrays as dropdowns in tooltips - Avoid hiding the tooltip when clicking on the tooltip itself - Show links to code variants (bytecode/baseline/optimized) - Fix chunk offset calculation - Fix code for browsers that don't support navigator.scheduling.isInputPending Bug: v8:10644 Change-Id: I858dc410657d26d076214368814a52177b124f4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964592 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75169}
-
- 15 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Open and focus separate views for each log entry - Map.prototype.parent is now a getter - Fix SharedLibLogEntry tooltips - Store codeEntry in IcLogEntry for linking back to code objects - New property-link-table which is used in tooltip and code-panel - Ignore right-click events in the timeline-tracks Bug: v8:10644, v8:11835 Change-Id: Id2fe5002b776adf362b1580b96082c84790a6ef0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960804Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75150}
-
- 14 Jun, 2021 2 commits
-
-
Camillo Bruni authored
improve logEntry hit testing performance fixing flame graph rendering adding some comments adding flamechart highlighting Bug: v8:10644, v8:11835 Change-Id: I2ab2f63b9e8339c6c25bb7023772fc97dfc56c2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959615 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75130}
-
Leszek Swirski authored
Add a new LogEntry for sharedlib PCs Change-Id: I4f7fdca93a9905e41b73347df475dffcb84bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959620 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75125}
-
- 07 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Introduce proper TickLogEntry and use a separate Timeline object - Update the main rendering to use SVG for speed - Separate custom-elements: timeline-track-map and timeline-track-tick - Revamp flame-chart drawing - Enable map-transitions overlay - Use mouse position to infer current log-entry instead of individual event handlers - Fix first timelineLegend column header - Fixing scrollbar-color for FireFox Change-Id: I7c53c13366b3e4614b1c5592dfaa69d0654a3b5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944430 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74987}
-
- 31 May, 2021 1 commit
-
-
Camillo Bruni authored
This adds a first crude version of displaying a flamechart in the system-analyzer. - Basic function types are distinguishable by colors. - Tooltip information is available as well Bug: v8:11835 Change-Id: I87e092f749d4c16aa5017af39df8d2f7bd7e2edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928179 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74860}
-
- 25 May, 2021 1 commit
-
-
Camillo Bruni authored
Enable more complex tooltips with clickable links and references. - Use short filename for Script.name if they are unique - Use shared App.isClickable method - Remove various toStringLong methods - Rename CodeLogEntry.disassemble to .code - Add DOM.button helper Bug: v8:10644 Change-Id: I5d46ffd560b37278dc46b8347cb9ff0a7fdfa2ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2916373Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74746}
-
- 14 Dec, 2020 1 commit
-
-
Camillo Bruni authored
Associate DeoptLogEntry with both, the function's source position and the deopt location's source position. Also fixes the list-panel click handler to support all clickable entry types. Bug: v8:10644, v8:10754 Change-Id: If10272a926d5dad10b29322e237610900715b9dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584955 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71732}
-
- 09 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Display the source code in the code-panel - Add selection dropdown to code-panel - Add more filter propertyNames to CodeLogEntry - Rename list panel titles to "XXX List" - Add +10, +100 buttons for LazyTables - Add Color.darken Change-Id: Ia41c41c1d6cc949dfe766397ba6b72edc29797aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2578945Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71674}
-
- 08 Dec, 2020 1 commit
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I83801396fe683173349d14a7590828ec86587eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575122Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71655}
-
- 05 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Clean up entry selection code - Add source positions for code and deopt events - Fix log entry selection from script - Improve log parsing speed Bug: v8:10644 Change-Id: Ie466679132b8ce24506ecf75223118b32275f931 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569756 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71624}
-
- 02 Dec, 2020 3 commits
-
-
Camillo Bruni authored
- Don't print normalize transition for cached maps - Avoid printing two transitions in Map::CopyReplaceDescriptor - Harden processor.mjs existing existing broken logs by skipping double entries and avoiding mutliple edges to the same target map Bug: v8:10644 Change-Id: I561a0f888c8835a40a289baa50d65ff69e368bad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565123Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71565}
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I727f844f3796f37e92c8855e02d519abeee73dc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2566760 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71558}
-
Camillo Bruni authored
- Add FLAG_log_code_disassemble - Add code-disassamble log entries for Code and BytecodeArray - Add basic code-panel to system-analyzer Bug: v8:10644 Change-Id: I1abb339a42b55df01265d63d0f0d8c1ac2e041dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565517Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71556}
-
- 30 Nov, 2020 2 commits
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I24229cbbf6a3ffea0fd4c3b96ef6eaf1e780b6e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565136 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71505}
-
Camillo Bruni authored
Drive-by-fix: - better handle tooltip text Bug: v8:10644 Change-Id: Ibe20a1e0a0ebd298855afcbdc6f28e6fa4d1e64e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563660 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71479}
-
- 26 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- Add ToolTip helper that tracks scrolling target elements - Auto hide if the target scrolls out of view - ToolTip position depends on target position - Add basic tooltips for maps in the transition view, entries in timeline tracks and the source panel Drive-by-fix: - Move events.mjs to view/ folder - Add basic toString methods on various log entries - Add requestAnimationFrame update support for V8CustomElement Bug: v8:10644 Change-Id: I1059733cd094a986b715547b3d5747eefbc54bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551103 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71434}
-
- 10 Nov, 2020 1 commit
-
-
Camillo Bruni authored
This is mostly an auto-conversion done by several tools. - use let / const - use arrow functions - use template strings There are some additional manual rewrite required to modernize the code further. Change-Id: I63a7a43b05b14b33ad9941350d3d5f26aab10ba0 Bug: v8:10667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519564Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71080}
-
- 03 Nov, 2020 1 commit
-
-
Sathya Gunasekaran authored
This is a reland of 1ec8f1da Original change's description: > [presubmit] Add JS formatting for tools/system-analyzer > > Bug: v8:10670 > Change-Id: Ifb653ada003719faff261b6e5b2169db37cffdaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282522 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68909} Bug: v8:10670 Change-Id: I4903b3eb8ff39a76594324076f0840b06290044e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307229 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70938}
-
- 29 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Use initial color for TimelineTrack chunks - Use async functions for TimelineTrack setChunkBackgrounds - Introduce timeSelection setter on TimelinePanel - Propagate time selection down to the TimelinePanel - Avoid layout recalculation in TimelineTrack updateSelection drive-by-cleanups: - Add common event listeners only to top-level document - Use console.warn instead of console.error for better debugging in DevTools Bug: v8:10644 Change-Id: Ie4f80f1c6c3f4fa193f8ac01225e0fb76981551d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497175 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70886}
-
- 27 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Remove ic-processor.html since it's been fully integrated in the system-analyzer - Use new tools/system-analyzer/processor.mjs for command line ic-processor - Update tools landing page - Partially fix dependencies on web specific components in helper.mjs Bug: v8:10644 Change-Id: I0c99ff7c7859684e53aa3ab22489b1a8242e1a6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498606Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70799}
-
- 19 Oct, 2020 3 commits
-
-
Camillo Bruni authored
Drive-by-fix: - fix legend formatting - Fix color from type retrieval - Partially fix file location parsing in Processor Bug: v8:10644 Change-Id: I8d9ecc4923c9772de66da74e9440b293fcecc5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2465831 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70608}
-
Camillo Bruni authored
- Avoid private fields (using _xyz instead of #xyz) - Avoid static fields on classes These are temporary changes that eventually will be reverted once FireFox and Safari support it. Bug: v8:10644 Change-Id: I3d757251eaedef92751970d866882c3d912c7e3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464924 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70607}
-
Camillo Bruni authored
- Use *LogEntry in more places to avoid confusion with HTML Events - Move Processor.kProperties to IcLogEntry.getPropertyNames - Move timeline-track legend "All" entry to the end Bug: v8:10644 Change-Id: I5a9e833ad0570c39d3106955fa2ba00af53b7062 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2463241 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70606}
-
- 12 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- simplify CSS in index.css - fix start-page layout - reduce timeline-track height - fix timeline-track legend layout - fix scrollbar colors in dark theme Bug: v8:10644 Change-Id: If3bb7422e6866bac766e7851f489a42ecbcf1d78 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2463239 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70438}
-
- 23 Sep, 2020 1 commit
-
-
Camillo Bruni authored
- Create SourcePosition objects for Map and IC log entries - Display source code with markers for SourcePositions - Avoid some try-catches for a better debugging experience Bug: v8:10644 Change-Id: I559b0eaeaa1442986a00d2ef720d19ba85178509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424258Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70091}
-
- 02 Sep, 2020 1 commit
-
-
Zeynep Cankara authored
This CL unifies the map-processor and ic-processor into a single log processing pipeline. Unified processing pipeline prevents doing 2 pass over the data. Bug: v8:10644 Change-Id: Ic0221a9bb32901f43202390b98fded4830a50f70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2385496 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69676}
-