- 08 Mar, 2022 1 commit
-
-
Joyee Cheung authored
For background and reasoning, see https://docs.google.com/document/d/1jvSEvXFHRkxg4JX-j6ho3nRqAF8vZI2Ai7RI8AY54gM/edit This is the first step towards pulling the DefineNamedOwn operation out of StoreIC. Summary of the renamed identifiers: Bytecodes: - StaNamedProperty -> SetNamedProperty: calls StoreIC and emitted for normal named property sets like obj.x = 1. - StaNamedOwnProperty -> DefineNamedOwnProperty: calls DefineNamedOwnIC (previously StoreOwnIC), and emitted for initialization of named properties in object literals and named public class fields. - StaKeyedProperty -> SetKeyedProperty: calls KeyedStoreIC and emitted for keyed property sets like obj[x] = 1. - StaKeyedPropertyAsDefine -> DefineKeyedOwnProperty: calls DefineKeyedOwnIC (previously KeyedDefineOwnIC) and emitted for initialization of private class fields and computed public class fields. - StaDataPropertyInLiteral -> DefineKeyedOwnPropertyInLiteral: calls DefineKeyedOwnPropertyInLiteral runtime function (previously DefineDataPropertyInLiteral) and emitted for initialization of keyed properties in object literals and static class initializers. (note that previously the StoreDataPropertyInLiteral runtime function name was taken by object spreads and array literal creation instead) - LdaKeyedProperty -> GetKeyedProperty, LdaNamedProperty -> GetNamedProperty, LdaNamedPropertyFromSuper -> GetNamedPropertyFromSuper: we drop the Sta prefix for the property store operations since the accumulator use is implicit and to make the wording more natural, for symmetry the Lda prefix for the property load operations is also dropped. opcodes: - (JS)StoreNamed -> (JS)SetNamedProperty: implements set semantics for named properties, compiled from SetNamedProperty (previously StaNamedProperty) and lowers to StoreIC or Runtime::kSetNamedProperty - (JS)StoreNamedOwn -> (JS)DefineNamedOwnProperty: implements define semantics for initializing named own properties in object literal and public class fields, compiled from DefineNamedOwnProperty (previously StaNamedOwnProperty) and lowers to DefineNamedOwnIC (previously StoreOwnIC) - (JS)StoreProperty -> (JS)SetKeyedProperty: implements set semantics for keyed properties, only compiled from SetKeyedProperty(previously StaKeyedProperty) and lowers to KeyedStoreIC - (JS)DefineProperty -> (JS)DefineKeyedOwnProperty: implements define semantics for initialization of private class fields and computed public class fields, compiled from DefineKeyedOwnProperty (previously StaKeyedPropertyAsDefine) and calls DefineKeyedOwnIC (previously KeyedDefineOwnIC). - (JS)StoreDataPropertyInLiteral -> (JS)DefineKeyedOwnPropertyInLiteral: implements define semantics for initialization of keyed properties in object literals and static class initializers, compiled from DefineKeyedOwnPropertyInLiteral (previously StaDataPropertyInLiteral) and calls the DefineKeyedOwnPropertyInLiteral runtime function (previously DefineDataPropertyInLiteral). Runtime: - DefineDataPropertyInLiteral -> DefineKeyedOwnPropertyInLiteral: following the bytecode/opcodes change, this is used by DefineKeyedOwnPropertyInLiteral (previously StaDataPropertyInLiteral) for object and class literal initialization. - StoreDataPropertyInLiteral -> DefineKeyedOwnPropertyInLiteral_Simple: it's just a simplified version of DefineDataPropertyInLiteral that does not update feedback or perform function name configuration. This is used by object spread and array literal creation. Since we are renaming DefineDataPropertyInLiteral to DefineKeyedOwnPropertyInLiteral, rename this simplified version with a `_Simple` suffix. We can consider merging it into DefineKeyedOwnPropertyInLiteral in the future. See https://docs.google.com/document/d/1jvSEvXFHRkxg4JX-j6ho3nRqAF8vZI2Ai7RI8AY54gM/edit?disco=AAAAQQIz6mU - Other changes following the bytecode/IR changes IC: - StoreOwn -> DefineNamedOwn: used for initialization of named properties in object literals and named public class fields. - StoreOwnIC -> DefineNamedOwnIC - StoreMode::kStoreOwn -> StoreMode::kDefineNamedOwn - StoreICMode::kStoreOwn -> StoreICMode::kDefineNamedOwn - IsStoreOwn() -> IsDefineNamedOwn() - DefineOwn -> DefineKeyedOwn: IsDefineOwnIC() was already just IsDefineKeyedOwnIC(), and IsAnyDefineOwn() includes both named and keyed defines so we don't need an extra generic predicate. - StoreMode::kDefineOwn -> StoreMode::kDefineKeyedOwn - StoreICMode::kDefineOwn -> StoreICMode::kDefineKeyedOwn - IsDefineOwn() -> IsDefineKeyedOwn() - IsDefineOwnIC() -> IsDefineKeyedOwnIC() - Removing IsKeyedDefineOwnIC() as its now a duplicate of IsDefineKeyedOwnIC() - KeyedDefineOwnIC -> DefineKeyedOwnIC, KeyedDefineOwnGenericGenerator() -> DefineKeyedOwnGenericGenerator: make the ordering of terms more consistent - IsAnyStoreOwn() -> IsAnyDefineOwn(): this includes the renamed and DefineNamedOwn and DefineKeyedOwn. Also is_any_store_own() is removed since it's just a duplicate of this. - IsKeyedStoreOwn() -> IsDefineNamedOwn(): it's unclear where the "keyed" part came from, but it's only used when DefineNamedOwnIC (previously StoreOwnIC) reuses KeyedStoreIC, so rename it accordingly Interpreter & compiler: - BytecodeArrayBuilder: following bytecode changes - StoreNamedProperty -> SetNamedProperty - StoreNamedOwnProperty -> DefineNamedOwnProperty - StoreKeyedProperty -> SetKeyedProperty - DefineKeyedProperty -> DefineKeyedOwnProperty - StoreDataPropertyInLiteral -> DefineKeyedOwnPropertyInLiteral - FeedbackSlotKind: - kDefineOwnKeyed -> kDefineKeyedOwn: make the ordering of terms more consistent - kStoreOwnNamed -> kDefineNamedOwn: following the IC change - kStoreNamed{Sloppy|Strict} -> kSetNamed{Sloppy|Strict}: only used in StoreIC for set semantics - kStoreKeyed{Sloppy|Strict} -> kSetKeyed{Sloppy|Strict}: only used in KeyedStoreIC for set semantics - kStoreDataPropertyInLiteral -> kDefineKeyedOwnPropertyInLiteral: following the IC change - BytecodeGraphBuilder - StoreMode::kNormal, kOwn -> NamedStoreMode::kSet, kDefineOwn: this is only used by BytecodeGraphBuilder::BuildNamedStore() to tell the difference between SetNamedProperty and DefineNamedOwnProperty operations. Not changed: - StoreIC and KeyedStoreIC currently contain mixed logic for both Set and Define operations, and the paths are controlled by feedback. The plan is to refactor the hierarchy like this: ``` - StoreIC - DefineNamedOwnIC - SetNamedIC (there could also be a NamedStoreIC if that's helpful) - KeyedStoreIC - SetKeyedIC - DefineKeyedOwnIC - DefineKeyedOwnICLiteral (could be merged into DefineKeyedOwnIC) - StoreInArrayLiteralIC - ... ``` StoreIC and KeyedStoreIC would then contain helpers shared by their subclasses, therefore it still makes sense to keep the word "Store" in their names since they would be generic base classes for both set and define operations. - The Lda and Sta prefixes of bytecodes not involving object properties (e.g. Ldar, Star, LdaZero) are kept, since this patch focuses on property operations, and distinction between Set and Define might be less relevant or nonexistent for bytecodes not involving object properties. We could consider rename some of them in future patches if that's helpful though. Bug: v8:12548 Change-Id: Ia36997b02f59a87da3247f20e0560a7eb13077f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3481475Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#79409}
-
- 07 Feb, 2022 1 commit
-
-
Michael Achenbach authored
After https://crrev.com/c/3416191 there are too many mixed concerns in the clusterfuzz directory. We split it into js-fuzzer, foozzie and trials. Change-Id: I9a21ee83985e6113d77acba4583e99df88723c60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3443505 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#78981}
-
- 30 Sep, 2021 1 commit
-
-
Marja Hölttä authored
It's confusing that we have CSA_CHECK and CSA_ASSERT and it's not clear from the names that the former works in release mode and the latter only in debug mode. Renaming CSA_ASSERT to CSA_DCHECK makes it clear what it does. So now we have CSA_CHECK and CSA_DCHECK and they're not confusing. This also renames assert() in Torque to dcheck(). Bug: v8:12244 Change-Id: I6f25d431ebc6eec7ebe326b6b8ad3a0ac5e9a108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190104Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77160}
-
- 30 Aug, 2021 1 commit
-
-
Leszek Swirski authored
The log test checks for log positions, which may change when background serialization / background compilation are enabled. Fixed: v8:12117 Change-Id: I193c9c23e016fad1e3f06a9f377bb53db84a6988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3129421 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76573}
-
- 10 Aug, 2021 1 commit
-
-
Camillo Bruni authored
This test depends on the profiler which runs in a separate thread and there is not incentive to control exact timing here to get the same predictable results on every run. Bug: v8:12066 Change-Id: I2da8eac97f3e8bf5f2158063f14063a0e321e891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3084371Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#76192}
-
- 01 Jul, 2021 1 commit
-
-
Camillo Bruni authored
Start a local symbol server using the local-web-sever node package: ws --stack system-analyzer/lws-middleware.js lws-static cors The system-analyzer will then use it to symbolize profiles. Note: The symbol server will execute `nm` and `objdump` locally. Change-Id: Icff6e9f5af24f214f353c049f5cd13eedccf0f88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979591 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75501}
-
- 30 Jun, 2021 1 commit
-
-
Camillo Bruni authored
https://crrev.com/c/2972915 previously added more gitignore files to the repository. This left the repo dirty after running mjsunit tests due to lingering .log files. - Add test/mjsunit/tools/tmp dir to keep and ignore temporary log files without the need for a platform specific tmp dir - Use temporary logfiles with --logfile=+ for log-ci.js tests Change-Id: I1b1a47f45603d6c3027c6ca7050c78e8df0664ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992720Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75451}
-
- 17 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Add tests and fix Chunk calculations in Timeline class - Cache DOM nodes directly as properties in TimelineTrackBase - Keep track of last focused entry in timeline tracks and reuse it to position the tooltip when the view is locked Bug: v8:10644 Change-Id: I356dcf7eed220df89f6a7ff926f00f78b119160e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968943 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75224}
-
- 15 Jun, 2021 1 commit
-
-
Camillo Bruni authored
Long live --log-ic! Change-Id: I4d8cefd64cdbf693a868019deb2a864d43cbd2ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964393 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75159}
-
- 11 Jun, 2021 1 commit
-
-
Leszek Swirski authored
Use the Streams API for file Blobs, instead of FileReader, to allow large files to be loaded in chunks. Change-Id: I241e0daff3f9c3d491dde2f3e8e52ea2236f05be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953286 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75095}
-
- 02 Jun, 2021 2 commits
-
-
Camillo Bruni authored
os.system seems to be flaky on certain bots. Disabling this until we have a proper fix. Change-Id: I075542772ba8eb968c96942923f76b87a2f18d47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931809Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74910}
-
Camillo Bruni authored
This is a reland of ed7e4554: - fixing platform names for tickprocessor - UnixCppEntriesProvider => LinuxCppEntriesProvider - MacCppEntriesProvider => MacOSCppEntriesProvider Original change's description: > [mjsunit][tools][d8] Full roundtrip tickprocessor test > > - Add os.d8Path property > - Add os.name property > - Change tickprocssor test to use command line arguments for testing > various configurations > - Change tickprocessor test to create a temporary v8.log and read it > back in on linux only > - Rearrange code in tickprocessor.mjs to allow instantiating the > CppEntriesProvider directly > - Drop complete symbol-list for tickprocessor-test-large.log for better > code searching in V8 > > Change-Id: Ib56dd0a1ba5377282c84c4de6f17e2fd69ee8123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929120 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74892} Change-Id: I5e121ba11f407af50108a2712d27c32867a22eb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929382Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74902}
-
- 01 Jun, 2021 4 commits
-
-
Clemens Backes authored
This reverts commit ed7e4554. Reason for revert: new test fails on Mac: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64/40407/overview Original change's description: > [mjsunit][tools][d8] Full roundtrip tickprocessor test > > - Add os.d8Path property > - Add os.name property > - Change tickprocssor test to use command line arguments for testing > various configurations > - Change tickprocessor test to create a temporary v8.log and read it > back in on linux only > - Rearrange code in tickprocessor.mjs to allow instantiating the > CppEntriesProvider directly > - Drop complete symbol-list for tickprocessor-test-large.log for better > code searching in V8 > > Change-Id: Ib56dd0a1ba5377282c84c4de6f17e2fd69ee8123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929120 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74892} Change-Id: I7d7506b370f96365552a21fa767b1c5c608ebb1c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929380 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74894}
-
Camillo Bruni authored
- Add os.d8Path property - Add os.name property - Change tickprocssor test to use command line arguments for testing various configurations - Change tickprocessor test to create a temporary v8.log and read it back in on linux only - Rearrange code in tickprocessor.mjs to allow instantiating the CppEntriesProvider directly - Drop complete symbol-list for tickprocessor-test-large.log for better code searching in V8 Change-Id: Ib56dd0a1ba5377282c84c4de6f17e2fd69ee8123 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929120Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74892}
-
Camillo Bruni authored
- Add d8.file.read() and d8.file.execute() helpers - Change tools and tests to use new d8.file helper - Unify error throwing in v8::Shell::ReadFile Change-Id: I5ef4cb27f217508a367106f01e872a4059d5e399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928505 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74883}
-
Camillo Bruni authored
- Move readFile helper to LogReader.readFile - Add static BaseArgumentsProcessor.process helper - Move SourceMap handling to the TickProcessor - Always skip example file mjsunit/tools/tickprocessor-test-large.js - Run tickprocessor and dumpcpp tests only in release mode Change-Id: I635fb2d2839233219b058faf9710fd0f19880fd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929117Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74873}
-
- 23 Apr, 2021 1 commit
-
-
Camillo Bruni authored
Add missing resources to mjsunit/BUILD.gn and tickprocesser test. Bug: v8:11681 Change-Id: I7ae8391f94913e376c93a40dd1f0ba16bff8dcc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844655Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74143}
-
- 21 Apr, 2021 1 commit
-
-
Camillo Bruni authored
- Add filter to skip baseline handlers - Make profiler types more readable - Refactor tickprocessor test to use serialized symbols - Add large tickprocessor stress test with a complete V8 log Change-Id: Icc09c2eb8ea63c1805d793d2d47f79b0d5080b5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784686 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74094}
-
- 06 Apr, 2021 1 commit
-
-
Michael Achenbach authored
Bug: chromium:1042556, chromium:1186279 Change-Id: I77e9967891efad4ce151e231f7f6461be2922ba7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2802291 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73798}
-
- 30 Nov, 2020 2 commits
-
-
Camillo Bruni authored
- Timeline.selection is now a Timeline as well - Allow remove the current timeline-track selection by double-clicking outside-the selection - Update the timeline-track stats based on the current selection - Simplify DOM element creation methods - Add separate SelectionHandler class for timeline-track Bug: v8:10644 Change-Id: I4f15d6ab4f5ec6b7330e22769472ca3074b00edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565130 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71497}
-
Camillo Bruni authored
Attach SourcePositionInfo objects to existing code entries if we find code-source-info log entries. This improves fixes finding scripts for anonymous functions. Bug: v8:10644 Change-Id: I6fc1e029b17107cacce89dc74a67d4d448d9a979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562672 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71482}
-
- 27 Nov, 2020 1 commit
-
-
Camillo Bruni authored
Make Timeline.selectTimeRange run in O(log(n)) instead of O(n) comparisons. Drive-by-fix: - Use *Index for variable names in Timeline Bug: v8:10644 Change-Id: I65f3be9f259e6bebcec489526a54712daffd4d15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507714 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71461}
-
- 20 Nov, 2020 1 commit
-
-
Michael Achenbach authored
This is a reland of e26863df The test now works with the no-i18n case. Original change's description: > [foozzie] Suppress access to CurrentTimeValue > > This stubs out CurrentTimeValue for differential fuzzing as otherwise > the non-deterministic value leaks from Intl.DateTimeFormat format and > formatToParts. > > This also affects other date creations, like Date.now(), which is > already stubbed out on the JS side. We keep that code for > backwards-compatibility to keep bisection stable. > > Bug: chromium:1149050 > Change-Id: Ifd82844c9fb8ce7262b55da6cf9f88f544268942 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546685 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71294} Cq-Include-Trybots: luci.v8.try.triggered:v8_linux_noi18n_rel_ng_triggered Bug: chromium:1149050 Change-Id: I4a750b580495532ca0ffb125522f8f5958e4cad6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2552401 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71309}
-
- 19 Nov, 2020 2 commits
-
-
Ben Smith authored
This reverts commit e26863df. Reason for revert: Fails on noi18n bot, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/34852/overview Original change's description: > [foozzie] Suppress access to CurrentTimeValue > > This stubs out CurrentTimeValue for differential fuzzing as otherwise > the non-deterministic value leaks from Intl.DateTimeFormat format and > formatToParts. > > This also affects other date creations, like Date.now(), which is > already stubbed out on the JS side. We keep that code for > backwards-compatibility to keep bisection stable. > > Bug: chromium:1149050 > Change-Id: Ifd82844c9fb8ce7262b55da6cf9f88f544268942 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546685 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71294} TBR=machenbach@chromium.org,cbruni@chromium.org,clemensb@chromium.org Change-Id: I958ca723de826ab427d27f5121f96618cf50c832 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1149050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551314Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#71298}
-
Michael Achenbach authored
This stubs out CurrentTimeValue for differential fuzzing as otherwise the non-deterministic value leaks from Intl.DateTimeFormat format and formatToParts. This also affects other date creations, like Date.now(), which is already stubbed out on the JS side. We keep that code for backwards-compatibility to keep bisection stable. Bug: chromium:1149050 Change-Id: Ifd82844c9fb8ce7262b55da6cf9f88f544268942 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546685Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71294}
-
- 04 Nov, 2020 1 commit
-
-
Camillo Bruni authored
Convert Profile, CodeMap and their helpers to ES6 classes. Code cleanup will happen in a separate step. Bug: v8:10667 Change-Id: Icfb28f6d9ef7f00efba93b347fdf210a9af36a49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509591 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70969}
-
- 27 Oct, 2020 1 commit
-
-
Camillo Bruni authored
Add simple log file test with processor.mjs, mostly focusing on parsing the log file correctly. Change-Id: Ie8db569b65ecd526ef4474a64d4019f00707d159 Bug: v8:10668 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484515 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#70806}
-
- 19 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Use *LogEntry in more places to avoid confusion with HTML Events - Move Processor.kProperties to IcLogEntry.getPropertyNames - Move timeline-track legend "All" entry to the end Bug: v8:10644 Change-Id: I5a9e833ad0570c39d3106955fa2ba00af53b7062 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2463241 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70606}
-
- 29 Sep, 2020 1 commit
-
-
Camillo Bruni authored
Allocating the log string causes allocation differences. Skipping test for now. Drive-by-fix: remove two more console.log from test Bug: v8:10966, v8:10668 Change-Id: Ifb93393fb82a983e779246ea728b1f6caf650426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436457 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70197}
-
- 28 Sep, 2020 4 commits
-
-
Camillo Bruni authored
Bug: v8:10668 Change-Id: I51f81a66408a4b262f9ac7e6421609c5e485f779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435107 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70174}
-
Camillo Bruni authored
Remove debug code that fails with predictable tests. Bug: chromium:1130673 Change-Id: Ie0009a3b18979057b08c25d22c58c7542dd1db6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435678Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70167}
-
Camillo Bruni authored
This changes all tools to use ES6 modules and proper imports. Step 1: Add converted .mjs files (*this CL*) Step 2: Update node-ci build to use new .mjs files Step 3: Remove outdated .js files Bug: v8:10667, v8:10933 Change-Id: I3e92e66f896d8a9cacaf6d421f8d2c86fb3bc444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431045 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70163}
-
Camillo Bruni authored
The tool has been outdated for a while and replaced by profview for most use-cases. The last version is still hosted under https://v8.github.io/tools/v8.4/profviz/profviz.html Bug: v8:9260, v8:10667 Change-Id: I54888640a627ee8e4d8ad2ab63bd91e04e6fb98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434335Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70159}
-
- 24 Sep, 2020 1 commit
-
-
Camillo Bruni authored
Bug: chromium:1130673 Change-Id: I78ae388daa1c4c2b594981bdadd201c2dfb39eb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426618Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70116}
-
- 23 Sep, 2020 1 commit
-
-
Camillo Bruni authored
Avoid --log-all which activates profiling timers that have issues on certain bots. --log-code is good enough to test whether logging works. Bug: v8:10937 Change-Id: I3284801f7b423480756abb0f3c33980a9776575d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424349Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70093}
-
- 22 Sep, 2020 4 commits
-
-
Camillo Bruni authored
This is a reland of 21bb43cc The build failures seems to be an infra flake. Original change's description: > [log][d8] Only use d8.log.getAndStop on temporary log file > > We run tests in parallel which can cause multiple tests to write to > the shared v8.log file. This obviously breaks the simple assertions in > mjsunit/tools/log.js. > > - Use temporary files for log testing with --logfile='+' > > - Change the symbol from '&' to '+' for using temporary files for > logging with --logfile > > - Enable skipped log tests again. > > Bug: v8:10937, chromium:1129854, chromium:1130196 > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70071} Bug: v8:10937 Bug: chromium:1129854 Bug: chromium:1130196 Change-Id: I2ccf7528f35057ef668aa211142e0f1073fc1fc3 Tbr: verwaest@chromium.org, victorgomes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424257Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70076}
-
Francis McCabe authored
This reverts commit 21bb43cc. Reason for revert: See broken build: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20builder/49882 Original change's description: > [log][d8] Only use d8.log.getAndStop on temporary log file > > We run tests in parallel which can cause multiple tests to write to > the shared v8.log file. This obviously breaks the simple assertions in > mjsunit/tools/log.js. > > - Use temporary files for log testing with --logfile='+' > > - Change the symbol from '&' to '+' for using temporary files for > logging with --logfile > > - Enable skipped log tests again. > > Bug: v8:10937, chromium:1129854, chromium:1130196 > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70071} TBR=cbruni@chromium.org,verwaest@chromium.org,victorgomes@chromium.org Change-Id: I5de61792c283139b2a898334e28e1f7b2d7c08f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10937 Bug: chromium:1129854 Bug: chromium:1130196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424625Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70072}
-
Camillo Bruni authored
We run tests in parallel which can cause multiple tests to write to the shared v8.log file. This obviously breaks the simple assertions in mjsunit/tools/log.js. - Use temporary files for log testing with --logfile='+' - Change the symbol from '&' to '+' for using temporary files for logging with --logfile - Enable skipped log tests again. Bug: v8:10937, chromium:1129854, chromium:1130196 Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70071}
-
Marja Hölttä authored
It's inherently timing-dependent, leading to false positives. Bug: chromium:1127612, v8:10239 Change-Id: Ibf6f3cb07f520a404daf8e860a0c2e5f2319529e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423707 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70046}
-
- 18 Sep, 2020 1 commit
-
-
Camillo Bruni authored
The new helper function allows us to write tests for log parsing without the need of first generating a log file. This makes it easier guard against errors when the log format changes. - add d8.log.getAndStop helper - add basic log test - fix test that regresses due to changed gc timing Bug: v8:10668 Change-Id: Ie57171fa98fe90428b89c26289d55fcbf2a70615 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403245Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69987}
-