- 16 Mar, 2015 3 commits
-
-
svenpanne authored
Fix the resulting warnings by renaming things apart. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/1009373002 Cr-Commit-Position: refs/heads/master@{#27219}
-
mstarzinger authored
Revert of Remove kind field from StackHandler. (patchset #4 id:60001 of https://codereview.chromium.org/1002203002/) Reason for revert: Layout test failure in inspector/sources/debugger/debugger-pause-on-promise-rejection.html Original issue's description: > Remove kind field from StackHandler. > > This makes the Isolate::Throw logic not depend on a prediction of > whether an exception is caught or uncaught. Such a prediction is > inherently undecidable because a finally block can decide between > consuming or re-throwing an exception depending on arbitray control > flow. > > There still is a conservative prediction mechanism in place that > components like the debugger or tracing can use for reporting. > > With this change we can get rid of the StackHandler::kind field, a > pre-requisite to do table-based lookups of exception handlers. > > R=yangguo@chromium.org > > Committed: https://crrev.com/96f79568a926966ebcf0685bf9adc947f4e1fbff > Cr-Commit-Position: refs/heads/master@{#27210} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1009903002 Cr-Commit-Position: refs/heads/master@{#27215}
-
mstarzinger authored
This makes the Isolate::Throw logic not depend on a prediction of whether an exception is caught or uncaught. Such a prediction is inherently undecidable because a finally block can decide between consuming or re-throwing an exception depending on arbitray control flow. There still is a conservative prediction mechanism in place that components like the debugger or tracing can use for reporting. With this change we can get rid of the StackHandler::kind field, a pre-requisite to do table-based lookups of exception handlers. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1002203002 Cr-Commit-Position: refs/heads/master@{#27210}
-
- 13 Mar, 2015 1 commit
-
-
dslomov authored
We have been shipping harmony scoping for 2 Chrome releases now (M41 and M42). Time to remove the flag. R=rossberg@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1007783002 Cr-Commit-Position: refs/heads/master@{#27187}
-
- 12 Mar, 2015 2 commits
-
-
bmeurer authored
Basically recognize certain x < y ? x : y constructs and turn that into Float64Min/Float64Max operations, if the target machine supports that. On x86 we lower to (v)minsd/(v)maxsd. R=dcarney@chromium.org Review URL: https://codereview.chromium.org/998283002 Cr-Commit-Position: refs/heads/master@{#27160}
-
mstarzinger authored
This moves the decision whether to report a message or not to when the pending exception is propagated instead of trying to preserve the decision in a ThreadLocalTop field. R=titzer@chromium.org Review URL: https://codereview.chromium.org/998943003 Cr-Commit-Position: refs/heads/master@{#27150}
-
- 11 Mar, 2015 2 commits
-
-
svenpanne authored
Combined the various lists, the only slightly ugly thing is now the distinction between intrinsics returning pairs and the rest, but that's no big deal. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/989273003 Cr-Commit-Position: refs/heads/master@{#27135}
-
mstarzinger authored
This removes the separate tracking of the pending message script, because that script is already stored in the message object and duplicating it in the ThreadLocalTop makes it more brittle. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/995013005 Cr-Commit-Position: refs/heads/master@{#27127}
-
- 10 Mar, 2015 4 commits
-
-
mstarzinger authored
This reduces the size of the StackHandler by yet another word. We no longer need to keep track of the frame pointer, as the stack walk will be able to recalculate it. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/991893003 Cr-Commit-Position: refs/heads/master@{#27115}
-
arv authored
The prototype of a class constructor function is read only. When we set computed property names we were ignoring this and we were overriding the property. Since the prototype is the only possible own read only property on the constructor function object we special case this so we do not have to check this for every property in the class literal. BUG=v8:3945 LOG=N R=mstarzinger@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/985643003 Cr-Commit-Position: refs/heads/master@{#27106}
-
mstarzinger authored
This reduces the size of the StackHandler by one word. We no longer need to keep track of the code object, as the stack walk finds it. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/985803002 Cr-Commit-Position: refs/heads/master@{#27103}
-
bmeurer authored
Provide an intrinsic %MathFloor / %_MathFloor that is used to optimize both Math.ceil and Math.floor, and use the JS inlining mechanism to inline Math.ceil into TurboFan code. Although we need to touch code outside of TurboFan to make this work, this does not affect the way we handle Math.ceil and/or Math.floor in CrankShaft, because for CrankShaft the old-style builtin function id based inlining still kicks in first. Once this solution is stabilized, we can use it for Math.floor as well. And once that is settled, we can establish it as the unified way to inline builtins, and get rid of the specialized builtin function id based inlining at some point. Note that "builtin" applies to basically every piece of internal JavaScript/intrinsics based code, so this also applies to the yet to be defined JavaScript based code stubs and handlers. BUG=v8:3953 LOG=n R=yangguo@chromium.org,svenpanne@chromium.org Review URL: https://codereview.chromium.org/990963003 Cr-Commit-Position: refs/heads/master@{#27086}
-
- 06 Mar, 2015 2 commits
-
-
svenpanne authored
This involved renaming apart a few more intrinsics. In the long run, we want to clean up redundant intrinsics which just delegate. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/984963002 Cr-Commit-Position: refs/heads/master@{#27043}
-
svenpanne authored
BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/978123003 Cr-Commit-Position: refs/heads/master@{#27039}
-
- 05 Mar, 2015 6 commits
-
-
yangguo authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/979003003 Cr-Commit-Position: refs/heads/master@{#27031}
-
yangguo authored
Internal references are absolute addresses into the instruction stream. Turn them into relative addresses when serializing and back when deserializing to keep them valid. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/976623002 Cr-Commit-Position: refs/heads/master@{#27020}
-
mstarzinger authored
This extends the stack unwinding logic to respect optimized frames and perform a lookup in the handler table to find handlers. It also contains fixes to the API call stubs to allow a stack walk while promoting scheduled exceptions. R=jarin@chromium.org TEST=cctest/test-run-jsexceptions Review URL: https://codereview.chromium.org/969533004 Cr-Commit-Position: refs/heads/master@{#27016}
-
rossberg authored
R=dslomov@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/976053002 Cr-Commit-Position: refs/heads/master@{#27014}
-
svenpanne authored
This way, every function in those lists has one C++ implementation called Runtime_##name. The previous distinction was confusing. Review URL: https://codereview.chromium.org/983623002 Cr-Commit-Position: refs/heads/master@{#27010}
-
bmeurer authored
This adds support for the double bits intrinsics to TurboFan, and is a first step towards fast Math functions inlined into TurboFan code or even compiled by themselves with TurboFan. Review URL: https://codereview.chromium.org/974313002 Cr-Commit-Position: refs/heads/master@{#27006}
-
- 04 Mar, 2015 1 commit
-
-
yangguo authored
We now have BreakLocation::Iterator to iterate via RelocIterator, and create a BreakLocation when we are done iterating. The reloc info is stored in BreakLocation in a GC-safe way and instantiated on demand. R=ulan@chromium.org BUG=v8:3924 LOG=N Review URL: https://codereview.chromium.org/967323002 Cr-Commit-Position: refs/heads/master@{#26983}
-
- 03 Mar, 2015 8 commits
-
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 Cr-Commit-Position: refs/heads/master@{#26963} Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43 Cr-Commit-Position: refs/heads/master@{#26966} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26972}
-
dslomov authored
Revert of Implement subclassing Arrays. (patchset #8 id:130001 of https://codereview.chromium.org/975463002/) Reason for revert: Arm compilation again. Aaaarrrrrghhhhhh!!! Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} > > Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43 > Cr-Commit-Position: refs/heads/master@{#26966} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/976693002 Cr-Commit-Position: refs/heads/master@{#26969}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 Cr-Commit-Position: refs/heads/master@{#26963} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26966}
-
dslomov authored
Revert of Implement subclassing Arrays. (patchset #7 id:110001 of https://codereview.chromium.org/975463002/) Reason for revert: Arm buildre complains again (why v8_linux_arm_dbg does not complain?) Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/974963002 Cr-Commit-Position: refs/heads/master@{#26965}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26963}
-
mvstanton authored
Revert of Implement subclassing Arrays. (patchset #6 id:90001 of https://codereview.chromium.org/975463002/) Reason for revert: ARM build failure... Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} TBR=arv@chromium.org,rossberg@chromium.org,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/975693002 Cr-Commit-Position: refs/heads/master@{#26961}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26960}
-
mstarzinger authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/960273002 Cr-Commit-Position: refs/heads/master@{#26957}
-
- 02 Mar, 2015 1 commit
-
-
Toon Verwaest authored
BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/969733003 Cr-Commit-Position: refs/heads/master@{#26941}
-
- 28 Feb, 2015 1 commit
-
-
dslomov authored
R=rossberg@chromium.org,arv@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/87f3e08e72510ee5544e82bb7ad39b2b5f001ad3 Cr-Commit-Position: refs/heads/master@{#26925} Review URL: https://codereview.chromium.org/962263002 Cr-Commit-Position: refs/heads/master@{#26931}
-
- 27 Feb, 2015 4 commits
-
-
dslomov authored
Revert of Disallow subclassing Arrays. (patchset #3 id:40001 of https://codereview.chromium.org/962263002/) Reason for revert: Fails on nosnap build Original issue's description: > Disallow subclassing Arrays. > > R=rossberg@chromium.org,arv@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/87f3e08e72510ee5544e82bb7ad39b2b5f001ad3 > Cr-Commit-Position: refs/heads/master@{#26925} TBR=arv@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/965053002 Cr-Commit-Position: refs/heads/master@{#26930}
-
dslomov authored
R=rossberg@chromium.org,arv@chromium.org BUG=v8:3930 LOG=Y Review URL: https://codereview.chromium.org/962263002 Cr-Commit-Position: refs/heads/master@{#26925}
-
loislo authored
Save Unknown position as zero in RelocInfo. Remove copy constructor of SourcePosition because it is trivial. Mechanical replace int raw_position with SourcePosition position. BUG=452067 LOG=n Review URL: https://codereview.chromium.org/959203002 Cr-Commit-Position: refs/heads/master@{#26916}
-
bmeurer authored
Review URL: https://codereview.chromium.org/926553004 Cr-Commit-Position: refs/heads/master@{#26907}
-
- 25 Feb, 2015 3 commits
-
-
arv authored
We don't need this since this case is now a SyntaxError. BUG=None LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/957823002 Cr-Commit-Position: refs/heads/master@{#26864}
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/945313003 Cr-Commit-Position: refs/heads/master@{#26862}
-
bmeurer authored
R=dcarney@chromium.org Review URL: https://codereview.chromium.org/946423003 Cr-Commit-Position: refs/heads/master@{#26846}
-
- 24 Feb, 2015 1 commit
-
-
jkummerow authored
Review URL: https://codereview.chromium.org/950283002 Cr-Commit-Position: refs/heads/master@{#26835}
-
- 23 Feb, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/892383003 Cr-Commit-Position: refs/heads/master@{#26796}
-