1. 18 Oct, 2020 1 commit
    • Dmitry Gozman's avatar
      [inspector] Prepend isolateId to remoteObjectId · 66725a53
      Dmitry Gozman authored
      This changes remoteObjectId format from
      "{injectedScriptId:123,id:456}" to "<isolateId>.<contextId>.<id>".
      
      Prepending isolateId fixes the problem that
      remote object ids clash between processes. This is especially
      troubling during cross-process navigation in Chromium, see bug.
      
      We also stop producing and parsing unnecessary json for object ids.
      
      Drive-by: fixed some tests dumping object ids. Most tests avoid
      dumping unstable values like ids, but there were few that still did.
      
      BUG=chromium:1137143
      
      Change-Id: Ia019757fb95704ccb718d3ea6cc54bde1a133382
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461731
      Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70592}
      66725a53
  2. 27 Dec, 2018 1 commit
  3. 22 Oct, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      inspector: generate custom preview using native code · 66daabcc
      Alexey Kozyatinskiy authored
      Full custom preview generation is moved to custom-preview file
      including frontend part. New custom preview implementation returns
      body getter function instead of bind function, formatter and config
      objects. Body getter function calls formatter.body(object, config)
      and returns json ML.
      
      R=dgozman@chromium.org
      
      Bug: chromium:595206
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I14ff3d8abb4a47d2bbc2e6eaa1835fc362ac7369
      Reviewed-on: https://chromium-review.googlesource.com/c/1292686
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56872}
      66daabcc