- 21 Mar, 2016 1 commit
-
-
bradnelson authored
Add missing conversions from other types to f32 in fround. Restrict fround() to only float, double, signed, unsigned (no unions / intish). Restrict Bitwise operations to intish, particularly |0, when not applied to a foreign function. Adding more exhaustive tests of stdlib Math, move to a separate file. Adding tests of interesting values for the stdlib asm.js functions. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=test-asm-validator,asm-wasm R=titzer@chromium.org,rossberg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1804243003 Cr-Commit-Position: refs/heads/master@{#34967}
-
- 14 Mar, 2016 1 commit
-
-
bradnelson authored
The rules for handling foreign functions were interfering with handling of standard functions (such as fround). Adding more tests around abs() BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=test-asm-validator,asm-wasm R=titzer@chromium.org,rossberg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1794303002 Cr-Commit-Position: refs/heads/master@{#34756}
-
- 10 Mar, 2016 2 commits
-
-
titzer authored
R=mstarzinger@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1782613003 Cr-Commit-Position: refs/heads/master@{#34682}
-
jfb authored
This will require an equivalent sexpr-wasm change. See: https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#high-level-structure R=titzer@chromium.org, binji@chronium.org Review URL: https://codereview.chromium.org/1765843002 Cr-Commit-Position: refs/heads/master@{#34668}
-
- 09 Mar, 2016 6 commits
-
-
titzer authored
R=binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1783593002 Cr-Commit-Position: refs/heads/master@{#34641}
-
binji authored
BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/1776923005 Cr-Commit-Position: refs/heads/master@{#34639}
-
binji authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1781523002 Cr-Commit-Position: refs/heads/master@{#34637}
-
titzer authored
R=binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1775123003 Cr-Commit-Position: refs/heads/master@{#34635}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1775353003 Cr-Commit-Position: refs/heads/master@{#34621}
-
titzer authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1778863002 Cr-Commit-Position: refs/heads/master@{#34617}
-
- 08 Mar, 2016 3 commits
-
-
binji authored
This CL modifies the following to be LEB128: * Function table indices * Import table signature indices * Export table function indices * Function signature param count * br/br_if break depth * br_table target count * block/loop expression count Still to do: * Import/export names (LEB128 count + inline data) * Data segments (LEB128 offset + size + inline data) * Function header stuff (should seperate into function sig and body sections) * Memory access alignment + offset (still discussing) BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/1775873002 Cr-Commit-Position: refs/heads/master@{#34603}
-
titzer authored
R=binji@chromium.org,dschuff@chromium.org BUG= Review URL: https://codereview.chromium.org/1780483002 Cr-Commit-Position: refs/heads/master@{#34600}
-
titzer authored
R=ahaas@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1770383002 Cr-Commit-Position: refs/heads/master@{#34587}
-
- 07 Mar, 2016 9 commits
-
-
titzer authored
R=dschuff@chromium.org BUG= Review URL: https://codereview.chromium.org/1767203002 Cr-Commit-Position: refs/heads/master@{#34565}
-
titzer authored
Local declarations were previously encoded as an optional set of 4 uint16 values as part of the function declaration. This CL implements the current design of moving these declarations to a list of pairs of (type, count) that is part of the body. R=bradnelson@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1763433002 Cr-Commit-Position: refs/heads/master@{#34564}
-
titzer authored
R=ahaas@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1770913002 Cr-Commit-Position: refs/heads/master@{#34559}
-
Ben L. Titzer authored
TBR=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/1769873002 . Cr-Commit-Position: refs/heads/master@{#34525}
-
Ben L. Titzer authored
TBR=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/1772593002 . Cr-Commit-Position: refs/heads/master@{#34524}
-
machenbach authored
Reland of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1768963002/ ) Reason for revert: Fix landed in head. Original issue's description: > Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1774463002/ ) > > Reason for revert: > [Sheriff] Problem is not fixed: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8799 > > Original issue's description: > > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > > > This is a reland of https://codereview.chromium.org/1762203002/ > > > > R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org > > BUG= > > > > Committed: https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 > > Cr-Commit-Position: refs/heads/master@{#34519} > > TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1769863002 Cr-Commit-Position: refs/heads/master@{#34523}
-
machenbach authored
Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1774463002/ ) Reason for revert: [Sheriff] Problem is not fixed: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8799 Original issue's description: > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > This is a reland of https://codereview.chromium.org/1762203002/ > > R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org > BUG= > > Committed: https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 > Cr-Commit-Position: refs/heads/master@{#34519} TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1768963002 Cr-Commit-Position: refs/heads/master@{#34522}
-
Ben L. Titzer authored
Cr-Commit-Position: refs/heads/master@{#34521}
-
titzer authored
This is a reland of https://codereview.chromium.org/1762203002/ R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org BUG= Review URL: https://codereview.chromium.org/1774463002 Cr-Commit-Position: refs/heads/master@{#34519}
-
- 05 Mar, 2016 2 commits
-
-
adamk authored
Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #2 id:20001 of https://codereview.chromium.org/1762203002/ ) Reason for revert: New test test-wasm-module-builder fails on Linux - shared bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8793 Original issue's description: > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > R=binji@chromium.org,seththompson@chromium.org > BUG= > > Committed: https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc > Cr-Commit-Position: refs/heads/master@{#34513} TBR=binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1771553002 Cr-Commit-Position: refs/heads/master@{#34514}
-
titzer authored
R=binji@chromium.org,seththompson@chromium.org BUG= Review URL: https://codereview.chromium.org/1762203002 Cr-Commit-Position: refs/heads/master@{#34513}
-
- 04 Mar, 2016 1 commit
-
-
bradnelson authored
Frames entering of inside wasm don't have a function or context argument. Adding distinct wasm frame and function types to express this. Fixes a GC issue on several embenchen wasm tests, reenabling them. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/wasm/embenchen R=titzer@chromium.org,aseemgarg@chromium.org,jfb@chromium.org,yangguo@chromium.org LOG=N Review URL: https://codereview.chromium.org/1764603003 Cr-Commit-Position: refs/heads/master@{#34476}
-
- 03 Mar, 2016 4 commits
-
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1758893002 Cr-Commit-Position: refs/heads/master@{#34466}
-
weiliang.lin authored
BUG= Review URL: https://codereview.chromium.org/1755013003 Cr-Commit-Position: refs/heads/master@{#34455}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org,yangguo@chromium.org LOG=N Review URL: https://codereview.chromium.org/1729833002 Cr-Commit-Position: refs/heads/master@{#34452}
-
dtc-v8 authored
BUG= Review URL: https://codereview.chromium.org/1597163002 Cr-Commit-Position: refs/heads/master@{#34450}
-
- 01 Mar, 2016 2 commits
-
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1749233002 Cr-Commit-Position: refs/heads/master@{#34404}
-
aseemgarg authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,bradnelson@chromium.org LOG=N Review URL: https://codereview.chromium.org/1750153002 Cr-Commit-Position: refs/heads/master@{#34375}
-
- 28 Feb, 2016 2 commits
-
-
titzer authored
R=bradnelson@chromium.org, binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1741393002 Cr-Commit-Position: refs/heads/master@{#34350}
-
titzer authored
R=binji@chromium.org,jfb@chromium.org BUG= Review URL: https://codereview.chromium.org/1740373002 Cr-Commit-Position: refs/heads/master@{#34346}
-
- 27 Feb, 2016 2 commits
-
-
titzer authored
R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Review URL: https://codereview.chromium.org/1742073002 Cr-Commit-Position: refs/heads/master@{#34345}
-
titzer authored
R=binji@chromium.org,jfb@chromium.org BUG= Review URL: https://codereview.chromium.org/1744713003 Cr-Commit-Position: refs/heads/master@{#34342}
-
- 24 Feb, 2016 1 commit
-
-
bradnelson authored
We previously supported use of bitwise operations to convert from intish to int, but use of kAsmInt in some places and kAsmIntQ in others prevents this from working with heap accesses. Switch to use kAsmIntQ where appropriate (even though intish_ != 0 in principle captures the superset of these cases), as it's more conservative (and uses types.h better). BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1731603002 Cr-Commit-Position: refs/heads/master@{#34233}
-
- 23 Feb, 2016 4 commits
-
-
bradnelson authored
This allows expressions like: (x + y) & -1 [intish] & [signed] The previous conversion condition was too strict (intended to forbid non-int expression conversion). Expressing in a different way. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1717213002 Cr-Commit-Position: refs/heads/master@{#34228}
-
jfb authored
For now WasmFrame doesn't summarize the wasm frames. That'll require adding the metadata in wasm-compiler similar to DeoptimizationInputData. Teach the basic backtrace to iterate over stack frames instead of JS frames. Update the wasm stack test. `git cl format` touches random lines in files I touch. R=titzer@chromium.org TEST=d8 --test --expose-wasm test/mjsunit/mjsunit.js test/mjsunit/wasm/stack.js Originally landed in: https://codereview.chromium.org/1712003003/ Reverted in: https://codereview.chromium.org/1730673002/ This patch puts the JSFunction on the C++ stack. Review URL: https://codereview.chromium.org/1724063002 Cr-Commit-Position: refs/heads/master@{#34225}
-
bradnelson authored
Now that register validation is working again, re-enable for asm->wasm embenchen tests. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1724043002 Cr-Commit-Position: refs/heads/master@{#34223}
-
bradnelson authored
asm.js permits both: int * constant constant * int It does not, however, allow intishes in multiplies. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm,test-asm-validator R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1718083004 Cr-Commit-Position: refs/heads/master@{#34222}
-