Commits · 110a5fdae4bf1f678372d43d81f4aa6c96dbaa16 · Linshizhi / V8

24 Jul, 2014 30 commits

Revert "Tests that the GC doesn't mistake non-pointer constant pool entries as pointers." · 110a5fda

machenbach@chromium.org authored Jul 24, 2014

This reverts commit r22608 for breaking win and arm64, ConstantPoolExtended and ConstantPoolSmall.

BUG=
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/415773010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

110a5fda

Tests that the GC doesn't mistake non-pointer constant pool entries as pointers. · 59ee2de9

rmcilroy@chromium.org authored Jul 24, 2014

Adds a test for ConstantPoolArray to ensure that the GC
doesn't mistake non-pointer entries as pointers and try
to modify them during scavenge operations.

Also adds asserts to ConstantPoolArray::set(int, *Object) to
ensure we don't add new-space pointers in constant pool
array.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/396803009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22608 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

59ee2de9

Use result of SetOwnPropertyIgnoreAttributes in accessors · ffd668f9

verwaest@chromium.org authored Jul 24, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/415133003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ffd668f9

Fix issue with setters and their holders in accessors.cc · 77a37e44

verwaest@chromium.org authored Jul 24, 2014

BUG=3462
LOG=Y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/417793002

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22606 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77a37e44

Add event statistics to GCTracer. · fc8a3bee

ernstm@chromium.org authored Jul 24, 2014

- Add method to GCTracer to compute mean and max of the last few
  Scavenger, Mark Compactor and Incremental Marking events.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/410413005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22605 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc8a3bee

Add a histogram timer around low memory notifications from API · b6182bd7

jochen@chromium.org authored Jul 24, 2014

BUG=397026
R=hpayer@chromium.org, ernstm@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/416853002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22604 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6182bd7

Stage for-of · d409898d

yangguo@chromium.org authored Jul 24, 2014

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417923004

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22603 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d409898d

For-of on null or undefined is an error · 029b8a23

yangguo@chromium.org authored Jul 24, 2014

The latest ES6 draft changed the behavior of for-of on null / undefined,
which for once is a simplification.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/416033002

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22602 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

029b8a23

Revert 22595: "Keep new arrays allocated with 'new Array(N)' in fast mode" · b5a51482

danno@chromium.org authored Jul 24, 2014

Due to failures in mjsunit/array-functions-prototype-misc

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/417953004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b5a51482

Move GCTracer to separate files. · 70e2a040

ernstm@chromium.org authored Jul 24, 2014

- No functional changes.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/416543003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70e2a040

SKIP migration tests to improve unit test time (2x) · 29338fa1

danno@chromium.org authored Jul 24, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/416003004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

29338fa1

Revert r22597 (which should have been called: "Tests that the GC doesn't... · 7cd5dbb9

rmcilroy@chromium.org authored Jul 24, 2014

Revert r22597 (which should have been called: "Tests that the GC doesn't mistake non-pointer constant pool entries as poitners.")

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/413173002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22598 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7cd5dbb9

Use heap iterator in store buffer when page was swept precisely. · 48f44b65

rmcilroy@chromium.org authored Jul 24, 2014

BUG=
R=rmcilroy@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22592

Review URL: https://codereview.chromium.org/413693002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22597 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

48f44b65

Flag for serialization when compiling code stubs if --serialize-toplevel. · 28112133

yangguo@chromium.org authored Jul 24, 2014

R=mvstanton@chromium.org
BUG=v8:3465
LOG=N

Review URL: https://codereview.chromium.org/419503002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28112133

Keep new arrays allocated with 'new Array(N)' in fast mode · ac89b178

danno@chromium.org authored Jul 24, 2014

Also explicit length setting with a.length = N should remain in fast mode.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/397593008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22595 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac89b178

Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder · 37df96f9

verwaest@chromium.org authored Jul 24, 2014

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/415953005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

37df96f9

re-land: Track history of events in GCTracer. · 9523e0ac

ernstm@chromium.org authored Jul 24, 2014

- track incremental marking stats directly on GCTracer.
- add simple ring buffer class.
- track last 10 scavenges and mark-compacts in ring buffers on GCTracer.
- various clean-ups.

This is a re-land of https://codereview.chromium.org/391413006/ with
 - int instead of size_t in ring buffer unit test.
 - git cl format

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/411293002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22593 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9523e0ac

Use heap iterator in store buffer when page was swept precisely. · a5b923ec

hpayer@chromium.org authored Jul 24, 2014

BUG=
R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/413693002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22592 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a5b923ec

Introduce more debug events for promises. · 63fb5381

yangguo@chromium.org authored Jul 24, 2014

BUG=v8:3093
LOG=Y
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/393283007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22591 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

63fb5381

Skip test on mips. · 55d8d2f0

machenbach@chromium.org authored Jul 24, 2014

PASS/FAIL is not enough as the test result is CRASH.

R=yangguo@chromium.org
TBR=yangguo@chromium.org
BUG=v8:3457
LOG=n

Review URL: https://codereview.chromium.org/415773005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22590 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55d8d2f0

Extend the interceptor setter ASSERT to support the JSGlobalProxy case. · b6f61b14

verwaest@chromium.org authored Jul 24, 2014

BUG=v8:3463
LOG=n
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/415973004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22589 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6f61b14

Partially revert "Unflake and speedup JsNative*Sample cpu profile tests" · 4c345d38

machenbach@chromium.org authored Jul 24, 2014

This reverts the test expectations of commit r22345. Several cpu profiler flakes were happening lately.

BUG=v8:2999
LOG=n
R=bmeurer@chromium.org
TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/418843002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22588 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4c345d38

X87: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers · f6c6f15e

verwaest@chromium.org authored Jul 24, 2014

port r22551.

original commit message:
  Always use the LoadStubCompiler for Load handlers, also for keyedload handlers

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/412903003

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22587 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f6c6f15e

X87: Only to the relevant checks in LoadFunctionPrototype · 24c2a018

verwaest@chromium.org authored Jul 24, 2014

port r22550.

original commit message:
  Only to the relevant checks in LoadFunctionPrototype

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/410223002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22586 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

24c2a018

X87: Move function prototype handling into a special handler rather than IC · f135cfa2

verwaest@chromium.org authored Jul 24, 2014

port r22526.

original commit message:
  Move function prototype handling into a special handler rather than IC

  Adjust hydrogen handling of function.prototype to be based on map feedback.
  Handle non-instance prototype loading using an IC rather than in the hydrogen
  instruction. In the future, remove the special instruction and replace by multiple
  hydrogen instructions.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/410203002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f135cfa2

Move gc notifications from V8 to Isolate and make idle hint mandatory · cb8105e2

jochen@chromium.org authored Jul 24, 2014

Embedders should use e.g. isolate->IdleNotification(1000) instead
of v8::V8::IdleNotification()

BUG=397026
R=hpayer@chromium.org, ernstm@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/412163003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb8105e2

Add and move DisallowHeapAllocation scope. · 464d45fc

yangguo@chromium.org authored Jul 24, 2014

The move is necessary since Heap::ReserveSpace called from
DeserializePartial may allocate.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/413663003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22583 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

464d45fc

Ignore test on mips. · 7fa03f87

machenbach@chromium.org authored Jul 24, 2014

R=yangguo@chromium.org
TBR=yangguo@chromium.org
BUG=v8:3457
LOG=n

Review URL: https://codereview.chromium.org/413983004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22582 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7fa03f87

Fix automatic tagging. · c218c20e

machenbach@chromium.org authored Jul 24, 2014

BUG=
TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/417973002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22580 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c218c20e

[Auto-roll] Bump up version to 3.28.36.0 · 3c231fb4

machenbach@chromium.org authored Jul 24, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/411273004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3c231fb4

23 Jul, 2014 10 commits

Fix ArrayLengthSetter to not throw on non-extensible receivers. · 67987790

verwaest@chromium.org authored Jul 23, 2014

BUG=v8:3460
LOG=n
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/411983003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

67987790

The accessors should get the value from the holder and not from this. · 45824023

verwaest@chromium.org authored Jul 23, 2014

These are all data properties and if they get invoked it means that
they should just return the value of the property from the holder.

BUG=v8:3461
LOG=Y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/410923003

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22575 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45824023

Whitespace change to trigger bots. · 0151837e

machenbach@chromium.org authored Jul 23, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/417593004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22574 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0151837e

Minor clarifications and simplifications as well as additional checks. · 61e1994f

neis@chromium.org authored Jul 23, 2014

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417553003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22573 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

61e1994f

Revert "Track history of events in GCTracer." · ea1be613

machenbach@chromium.org authored Jul 23, 2014

This reverts commit 22567 for breaking win64 compile.

BUG=
TBR=ernstm@chromium.org

Review URL: https://codereview.chromium.org/414743002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22572 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea1be613

[Auto-roll] Bump up version to 3.28.34.0 · 5169bcb9

machenbach@chromium.org authored Jul 23, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/411003002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22571 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5169bcb9

MIPS: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers. · e4a5fa31

balazs.kilvady@imgtec.com authored Jul 23, 2014

Port r22551 (0cc23b1)

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/415623002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22570 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e4a5fa31

Revert "Minor clarifications and simplifications as well as additional checks." · e999cf28

neis@chromium.org authored Jul 23, 2014

This reverts commit d32eacbdea3fc0c119da06abe95b07a83c67aa48.

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/410083005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e999cf28

Minor clarifications and simplifications as well as additional checks. · 6c67275f

neis@chromium.org authored Jul 23, 2014

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/409743004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22568 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c67275f

Track history of events in GCTracer. · 462cca2e

ernstm@chromium.org authored Jul 23, 2014

- track incremental marking stats directly on GCTracer.
- add simple ring buffer class.
- track last 10 scavenges and mark-compacts in ring buffers on GCTracer.
- various clean-ups.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/391413006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22567 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

462cca2e