1. 06 May, 2020 1 commit
  2. 26 Sep, 2019 1 commit
  3. 11 Sep, 2019 1 commit
  4. 30 Jul, 2019 1 commit
    • Joyee Cheung's avatar
      [class] parse private accessors · a6dd7f1c
      Joyee Cheung authored
      This patch adds:
      
      - VariableMode::kPrivateMethod
      - VariableMode::kPrivateSetterOnly
      - VariableMode::kPrivateGetterOnly
      - VariableMode::kPrivateGetterAndSetter
      
      And replace the previous RequiresBrandCheckFlag by inferring
      whether the brand check is required from these VariableModes.
      It is then possible to check duplicate non-complementary
      accessors in the parsers and throw early errors, and allow
      complementary accessors to be associated with the same
      private name variable.
      
      This patch also adds the following AssignType:
      
      - PRIVATE_METHOD
      - PRIVATE_GETTER_ONLY
      - PRIVATE_SETTER_ONLY
      - PRIVATE_GETTER_AND_SETTER
      
      corresponding to the new VariableModes so that it's possible
      to generate specialized code for different type of
      private accessor declarations.
      
      Design doc: https://docs.google.com/document/d/10W4begYfs7lmldSqBoQBBt_BKamgT8igqxF9u50RGrI/edit
      
      Bug: v8:8330
      Change-Id: I0fb61b1be248630d1eadd74fb16d7d64a421f4c4
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695204
      Commit-Queue: Joyee Cheung <joyee@igalia.com>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62988}
      a6dd7f1c
  5. 12 Jul, 2019 1 commit
  6. 18 Jun, 2019 1 commit
  7. 23 May, 2019 1 commit
  8. 22 May, 2019 1 commit
  9. 11 Apr, 2019 1 commit
  10. 28 Mar, 2019 1 commit
  11. 28 Jan, 2019 1 commit
  12. 21 Sep, 2018 1 commit
  13. 18 Jun, 2018 1 commit
  14. 15 Jun, 2018 2 commits
    • Yang Guo's avatar
      Revert "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather... · 23b8d2fd
      Yang Guo authored
      Revert "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes."
      
      This reverts commit 9e27d473.
      
      Reason for revert: Layout Test failures: https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064/24123
      
      Original change's description:
      > [debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes.
      > 
      > This CL also bottlenecks all current scope handling in the ScopeIterator, and cleans up frame handling in debug-frames and the deoptimizer.
      > 
      > Change-Id: I061922a356ce17794262f8d77d5d7c824558fc50
      > Reviewed-on: https://chromium-review.googlesource.com/1095094
      > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53741}
      
      TBR=yangguo@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,verwaest@chromium.org
      
      Change-Id: I892856056258e3c68b36409b8b2d69e7686fc385
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/1102377
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53756}
      23b8d2fd
    • Toon Verwaest's avatar
      Reland "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather... · 4936efb0
      Toon Verwaest authored
      Reland "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes."
      
      This is a reland of 9e27d473
      
      Original change's description:
      > [debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes.
      > 
      > This CL also bottlenecks all current scope handling in the ScopeIterator, and cleans up frame handling in debug-frames and the deoptimizer.
      > 
      > Change-Id: I061922a356ce17794262f8d77d5d7c824558fc50
      > Reviewed-on: https://chromium-review.googlesource.com/1095094
      > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53741}
      
      Change-Id: I05262fef66d852876b9bb2869339053629c9b51d
      Reviewed-on: https://chromium-review.googlesource.com/1102297Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53751}
      4936efb0
  15. 14 Jun, 2018 2 commits
  16. 03 Jun, 2018 1 commit
  17. 23 Jan, 2018 1 commit
  18. 29 Nov, 2017 1 commit
  19. 17 Nov, 2017 1 commit
  20. 31 Oct, 2017 1 commit
    • Mythri's avatar
      [TurboFan] Remove a check on nesting levels inlining heuristics · 5b38c7fc
      Mythri authored
      We have a check on maximum number of levels that can be inlined. This
      in some cases causes performance cliffs, when we cannot inline a small
      function because it has exceeded the number of levels. This cl removes
      that check. The intuition is that, having gone down several levels in
      a particular line stopping inlining that chain and exploring a new
      call site may not be beneficial. This cl also introduces a absolute
      limit on the number of nodes that can be inlined (including the small
      functions).
      
      Bug: v8:6871, chromium:779509
      Change-Id: Id29639ff2fd85b84d8746da3fb78a82d4e9852e8
      Reviewed-on: https://chromium-review.googlesource.com/743727Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49050}
      5b38c7fc
  21. 30 Oct, 2017 1 commit
    • Michael Stanton's avatar
      Revert "[TurboFan] Remove maximum inlining levels check from inlining heuristics" · f585415a
      Michael Stanton authored
      This reverts commit ecd3a2ea.
      
      Reason for revert: Bug 779509, a crash with chrome.
      
      Original change's description:
      > [TurboFan] Remove maximum inlining levels check from inlining heuristics
      > 
      > We have a check on maximum number of levels that can be inlined. This
      > in some cases causes performance cliffs, when we cannot inline a small
      > function because it has exceeded the number of levels. This cl removes
      > that check. The intuition is that, having gone down several levels in
      > a particular line stopping inlining that chain and exploring a new
      > call site may not be beneficial.
      > 
      > Bug: v8:6871
      > Change-Id: I120056db38e78ce48dff010b6cf994259238582a
      > Reviewed-on: https://chromium-review.googlesource.com/741705
      > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49009}
      
      TBR=mythria@chromium.org,bmeurer@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:6871
      Change-Id: I4766f911cb326c224af110be5c0dd7a44362a880
      Reviewed-on: https://chromium-review.googlesource.com/743785Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49037}
      f585415a
  22. 27 Oct, 2017 1 commit
  23. 13 Oct, 2017 1 commit
  24. 25 Sep, 2017 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Fix (D)CHECK macros in src/{debug,inspector} · 8d38c15e
      Clemens Hammacher authored
      Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an
      embedded comparison. This gives better error messages and also does the
      right comparison for signed/unsigned mismatches.
      
      This will allow us to reenable the readability/check cpplint check.
      
      R=yangguo@chromium.org
      
      Bug: v8:6837
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112
      Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48138}
      8d38c15e
  25. 01 Sep, 2017 1 commit
  26. 31 Aug, 2017 1 commit
  27. 29 Aug, 2017 1 commit
  28. 18 Aug, 2017 1 commit
    • Ben L. Titzer's avatar
      [frames] Unpack FrameSummary early in FrameInspector. · 5b0c1c65
      Ben L. Titzer authored
      This CL is a precursor to the callback-based enumeration of frame summaries.
      It removes the reliance of FrameInspector on having a cached copy of the
      FrameSummary, instead unpacking it to instance variables so that clients
      of FrameInspector do not need to get information from two sources
      (the FrameSummary and the FrameInspector itself).
      
      R=yangguo@chromium.org
      
      Bug: 
      Change-Id: Ib388566c2e1a1147ee0a581323932982a29ae4ff
      Reviewed-on: https://chromium-review.googlesource.com/618334
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47420}
      5b0c1c65
  29. 17 Jul, 2017 1 commit
  30. 20 Jan, 2017 1 commit
    • clemensh's avatar
      [wasm] Implement frame inspection for interpreted frames · 09525c8f
      clemensh authored
      Frame inspection is currently limited to locations of execution.
      Further details like local variables or stack content will follow later.
      
      The FrameInspector now stores a pointer to the interpreted wasm frame,
      and redirects certain requests there, just as for deoptimized frames.
      Hitting breakpoints is now also supported for wasm frames.
      
      R=yangguo@chromium.org, titzer@chromium.org
      BUG=v8:5822
      
      Review-Url: https://codereview.chromium.org/2629823003
      Cr-Commit-Position: refs/heads/master@{#42551}
      09525c8f
  31. 12 Jan, 2017 1 commit
    • clemensh's avatar
      Refactor FrameSummary for JS and Wasm frames · df5417ae
      clemensh authored
      Wasm frames can be either compiled or interpreted. For interpreted wasm
      frames, there is only one physical stack frame representing an
      arbitrary stack of interpreted functions. Hence the physical stack
      frame needs to provide a summary of the underlying functions.
      Summaries were tailored for JavaScript frames before. Now they are
      universal.
      
      The refactored FrameSummaries are now also used in the FrameInspector,
      and from the StackFrame objects themselves, to avoid code duplication.
      
      All dispatch is implemented "manually", making the FrameSummary still
      stack-allocatable.
      
      BUG=v8:5822
      R=yangguo@chromium.org, titzer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2619353006
      Cr-Commit-Position: refs/heads/master@{#42279}
      df5417ae
  32. 08 Dec, 2016 1 commit
  33. 13 Oct, 2016 1 commit
    • clemensh's avatar
      [wasm] Stack inspection support for asm.js frames · e902b69d
      clemensh authored
      This CL fixes the debugger interface to provide correct (high-level)
      information for asm.js frames.
      It moves the computation of the source position from the FrameInspector
      to the individual StackFrame implementations, such that we can easily
      specualize it for certain frame types, and can potentially reuse this
      in other locations.
      
      Also, we are finalizing the setup of the wasm module earlier, before
      executing the start function. This is required for correct stack traces
      during the execution of the start function.
      
      R=titzer@chromium.org, yangguo@chromium.org
      BUG=v8:4203
      
      Review-Url: https://codereview.chromium.org/2413693003
      Cr-Commit-Position: refs/heads/master@{#40268}
      e902b69d
  34. 29 Jun, 2016 3 commits
  35. 14 Jun, 2016 1 commit
  36. 13 Jun, 2016 1 commit