1. 06 Feb, 2019 1 commit
    • Tamer Tas's avatar
      Reland "Reland "[test] refactor testsuite configuration"" · df630e67
      Tamer Tas authored
      This is a reland of 81eec150
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      >
      > This is a reland of 7f92ad0a
      >
      > Original change's description:
      > > [test] refactor testsuite configuration
      > >
      > > Every testsuite configuration consist of at least 30% code duplication.
      > >
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > >
      > > This CL removes all the duplication by refactoring the common functionality.
      > >
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > >
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > >
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      Bug: v8:8174, v8:8790
      Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857
      Reviewed-on: https://chromium-review.googlesource.com/c/1454724
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59387}
      df630e67
  2. 05 Feb, 2019 4 commits
    • Tamer Tas's avatar
      Revert "Reland "[test] refactor testsuite configuration"" · ea4412ad
      Tamer Tas authored
      This reverts commit 81eec150.
      
      Reason for revert: windows mozilla test failures
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      > 
      > This is a reland of 7f92ad0a
      > 
      > Original change's description:
      > > [test] refactor testsuite configuration
      > > 
      > > Every testsuite configuration consist of at least 30% code duplication.
      > > 
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > > 
      > > This CL removes all the duplication by refactoring the common functionality.
      > > 
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > > 
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > > 
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org
      
      Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59370}
      ea4412ad
    • Tamer Tas's avatar
      Reland "[test] refactor testsuite configuration" · 81eec150
      Tamer Tas authored
      This is a reland of 7f92ad0a
      
      Original change's description:
      > [test] refactor testsuite configuration
      > 
      > Every testsuite configuration consist of at least 30% code duplication.
      > 
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      > 
      > This CL removes all the duplication by refactoring the common functionality.
      > 
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      > 
      > R=machenbach@chromium.org
      > CC=yangguo@chromium.org,sergiyb@chromium.org
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      Bug: v8:8174, v8:8769
      Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59369}
      81eec150
    • Tamer Tas's avatar
      Revert "[test] refactor testsuite configuration" · 97068800
      Tamer Tas authored
      This reverts commit 7f92ad0a.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148
      
      Original change's description:
      > [test] refactor testsuite configuration
      >
      > Every testsuite configuration consist of at least 30% code duplication.
      >
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      >
      > This CL removes all the duplication by refactoring the common functionality.
      >
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      >
      > R=​machenbach@chromium.org
      > CC=​yangguo@chromium.org,sergiyb@chromium.org
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org
      
      Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454599
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59362}
      97068800
    • Tamer Tas's avatar
      [test] refactor testsuite configuration · 7f92ad0a
      Tamer Tas authored
      Every testsuite configuration consist of at least 30% code duplication.
      
      The code age ranges from 10 years old to 5 years old. Implementing anything that
      touches the testsuite code becomes a technical fight to the death.
      
      This CL removes all the duplication by refactoring the common functionality.
      
      This CL contains structural changes without any logical changes % small bug
      fixes.
      
      R=machenbach@chromium.org
      CC=yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8769
      Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59361}
      7f92ad0a
  3. 29 Aug, 2018 1 commit
  4. 01 Feb, 2018 1 commit
  5. 31 Jan, 2018 2 commits
  6. 30 Jan, 2018 2 commits
  7. 04 Jan, 2018 2 commits
    • Michal Majewski's avatar
      [test] Check output on the worker process. · 9f7d440e
      Michal Majewski authored
      I added additional exception logging in the execution.py since
      errors in processing results were really difficult to debug.
      
      There is a problem on Windows with class serialization when
      it comes from dynamically loaded module. To fix it I moved all
      output processors to the tools/testrunner/outproc/ and import
      them in test/*/testcfg.py.
      
      Bug: v8:6917
      Change-Id: Ida604641d659b006e91faf1d56a37769ec47f5f3
      Reviewed-on: https://chromium-review.googlesource.com/842784
      Commit-Queue: Michał Majewski <majeski@google.com>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50361}
      9f7d440e
    • Michael Achenbach's avatar
      Revert "Revert "[test] Move has unexpected output to outproc."" · c1e9bc02
      Michael Achenbach authored
      This reverts commit 1685b5d2.
      
      Reason for revert: Was probably caused by infra change:
      https://crrev.com/c/845781
      
      Original change's description:
      > Revert "[test] Move has unexpected output to outproc."
      > 
      > This reverts commit 71605b3e.
      > 
      > Reason for revert: Seems to break static-initializers step:
      > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156
      > 
      > Original change's description:
      > > [test] Move has unexpected output to outproc.
      > > 
      > > Expected outcomes optimized to serialize [PASS] as None.
      > > 
      > > Keeping expected outcomes inside output processors should be
      > > optimized in the future. Few possible optimizations:
      > > - separate classes for tests that are expected to PASS - done as
      > > an example in mozilla test suite.
      > > - cache output processors inside testcase.
      > > - share output processors between copies of the same test - needs
      > > some updates to the create_variant to update outproc only if
      > > expected outcomes changed.
      > > 
      > > Bug: v8:6917
      > > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      > > Reviewed-on: https://chromium-review.googlesource.com/843025
      > > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#50347}
      > 
      > TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      > 
      > Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: v8:6917
      > Reviewed-on: https://chromium-review.googlesource.com/849572
      > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50348}
      
      TBR=bbudge@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      
      Change-Id: I7a522b6487de6e96985d223524533493eb9171f0
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6917
      Reviewed-on: https://chromium-review.googlesource.com/848975Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50350}
      c1e9bc02
  8. 03 Jan, 2018 2 commits
    • Bill Budge's avatar
      Revert "[test] Move has unexpected output to outproc." · 1685b5d2
      Bill Budge authored
      This reverts commit 71605b3e.
      
      Reason for revert: Seems to break static-initializers step:
      https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156
      
      Original change's description:
      > [test] Move has unexpected output to outproc.
      > 
      > Expected outcomes optimized to serialize [PASS] as None.
      > 
      > Keeping expected outcomes inside output processors should be
      > optimized in the future. Few possible optimizations:
      > - separate classes for tests that are expected to PASS - done as
      > an example in mozilla test suite.
      > - cache output processors inside testcase.
      > - share output processors between copies of the same test - needs
      > some updates to the create_variant to update outproc only if
      > expected outcomes changed.
      > 
      > Bug: v8:6917
      > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      > Reviewed-on: https://chromium-review.googlesource.com/843025
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50347}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      
      Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6917
      Reviewed-on: https://chromium-review.googlesource.com/849572Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50348}
      1685b5d2
    • Michal Majewski's avatar
      [test] Move has unexpected output to outproc. · 71605b3e
      Michal Majewski authored
      Expected outcomes optimized to serialize [PASS] as None.
      
      Keeping expected outcomes inside output processors should be
      optimized in the future. Few possible optimizations:
      - separate classes for tests that are expected to PASS - done as
      an example in mozilla test suite.
      - cache output processors inside testcase.
      - share output processors between copies of the same test - needs
      some updates to the create_variant to update outproc only if
      expected outcomes changed.
      
      Bug: v8:6917
      Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      Reviewed-on: https://chromium-review.googlesource.com/843025
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50347}
      71605b3e
  9. 21 Dec, 2017 2 commits
  10. 18 Dec, 2017 1 commit
  11. 13 Dec, 2017 3 commits
  12. 12 Dec, 2017 1 commit
  13. 16 Nov, 2017 1 commit
  14. 10 Nov, 2017 1 commit
  15. 27 Oct, 2017 1 commit
  16. 12 Jul, 2016 1 commit
  17. 14 Mar, 2016 1 commit
    • littledan's avatar
      Make test262 test runner check for which exception is thrown · f3568ca4
      littledan authored
      test262 "negative" test expectations list which exception is thrown. The ES2017
      draft specification is very specific about which exception class is thrown
      from which path, and V8 works hard to be correct with respect to that spec.
      
      Previously, the test262 test runner would accept any nonzero status code,
      such as from a crash, or a FAIL printed out, for a negative test. This
      patch makes negative tests check for the right answer using a quick-and-dirty
      parsing of the exception printing from d8 to find the exception class.
      It invokes d8 in a way to get a status code of 0 from thrown exceptions
      so that 'negative' tests aren't actually implemented by negating the output.
      
      Amazingly, this didn't catch any test262 failures, but I verified the extra
      checking interactively by changing a negative test to expect a different type
      and saw it fail.
      
      BUG=v8:4803
      R=machenbach
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1766503002
      
      Cr-Commit-Position: refs/heads/master@{#34763}
      f3568ca4
  18. 17 Sep, 2015 3 commits
  19. 22 Dec, 2014 1 commit
  20. 27 Jun, 2013 1 commit
  21. 26 Jun, 2013 1 commit
  22. 18 Apr, 2013 1 commit
  23. 18 Jan, 2013 1 commit
  24. 22 Oct, 2012 1 commit
  25. 24 Sep, 2012 1 commit
  26. 10 Aug, 2012 1 commit
  27. 26 Jul, 2011 1 commit
  28. 31 May, 2011 1 commit
    • rossberg@chromium.org's avatar
      Implement set trap for proxies, and revamp class hierarchy in preparation: · 670f947a
      rossberg@chromium.org authored
      - Introduce a class JSReceiver, that is a common superclass of JSObject and
        JSProxy. Use JSReceiver where appropriate (probably lots of places that we
        still have to migrate, but we will find those later with proxy test suite).
      
      - Move appropriate methods to JSReceiver class (SetProperty,
        GetPropertyAttribute, Get/SetPrototype, Lookup, and so on).
      
      - Introduce new JSFunctionProxy subclass of JSProxy. Currently only a stub.
      
      - Overhaul enum InstanceType:
        * Introduce FIRST/LAST_SPEC_OBJECT_TYPE that ranges over all types that
          represent JS objects, and use that consistently to check language types.
        * Rename FIRST/LAST_JS_OBJECT_TYPE and FIRST/LAST_FUNCTION_CLASS_TYPE
          to FIRST/LAST_[NON]CALLABLE_SPEC_OBJECT_TYPE for clarity.
        * Eliminate the overlap over JS_REGEXP_TYPE.
        * Also replace FIRST_JS_OBJECT with FIRST_JS_RECEIVER, but only use it where
          we exclusively talk about the internal representation type.
        * Insert JS_PROXY and JS_FUNCTION_PROXY in the appropriate places.
      
      - Fix all checks concerning classification, especially for functions, to
        use the CALLABLE_SPEC_OBJECT range (that includes funciton proxies).
      
      - Handle proxies in SetProperty (that was the easiest part :) ).
      
      - A few simple test cases.
      
      R=kmillikin@chromium.org
      
      Review URL: http://codereview.chromium.org/6992072
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      670f947a