1. 20 Mar, 2018 1 commit
    • Michael Achenbach's avatar
      Reland "[build] Make separate snapshot for trusted variant" · f0940a63
      Michael Achenbach authored
      This is a reland of 40d66d8b
      
      The fix disambiguates duplicate symbols in the generated embedded
      builtins file.
      
      Original change's description:
      > [build] Make separate snapshot for trusted variant
      >
      > This enables side-by-side snapshots with and without untrusted-code
      > mitigations. It'll be the default in all V8 stand-alone builds
      > with external startup data. Internal snapshots are not supported.
      >
      > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be
      > bundled with V8 on swarming and the correct file is loaded dependent
      > on the --untrusted-code-mitigations runtime flag.
      >
      > Likewise we embed two snapshots for builtins.
      >
      > Side-by-side snapshots won't be supported in Chromium.
      >
      > Bug: v8:7441
      > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524
      > Reviewed-on: https://chromium-review.googlesource.com/960004
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52028}
      
      Bug: v8:7441
      Change-Id: I626171d4e07389f0453b4d0a698e2772fd37e8c5
      Reviewed-on: https://chromium-review.googlesource.com/968623
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52055}
      f0940a63
  2. 19 Mar, 2018 2 commits
    • Michael Achenbach's avatar
      Revert "[build] Make separate snapshot for trusted variant" · 7e7c04b6
      Michael Achenbach authored
      This reverts commit 40d66d8b.
      
      Reason for revert:
      https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/20910
      
      Original change's description:
      > [build] Make separate snapshot for trusted variant
      > 
      > This enables side-by-side snapshots with and without untrusted-code
      > mitigations. It'll be the default in all V8 stand-alone builds
      > with external startup data. Internal snapshots are not supported.
      > 
      > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be
      > bundled with V8 on swarming and the correct file is loaded dependent
      > on the --untrusted-code-mitigations runtime flag.
      > 
      > Likewise we embed two snapshots for builtins.
      > 
      > Side-by-side snapshots won't be supported in Chromium.
      > 
      > Bug: v8:7441
      > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524
      > Reviewed-on: https://chromium-review.googlesource.com/960004
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52028}
      
      TBR=rmcilroy@chromium.org,machenbach@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org
      
      Change-Id: I5b18f7aff7c05a17842fc68d785bb617eeca4a41
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7441
      Reviewed-on: https://chromium-review.googlesource.com/968622Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52029}
      7e7c04b6
    • Michael Achenbach's avatar
      [build] Make separate snapshot for trusted variant · 40d66d8b
      Michael Achenbach authored
      This enables side-by-side snapshots with and without untrusted-code
      mitigations. It'll be the default in all V8 stand-alone builds
      with external startup data. Internal snapshots are not supported.
      
      The files snapshot_blob.bin and snapshot_blob_trusted.bin will be
      bundled with V8 on swarming and the correct file is loaded dependent
      on the --untrusted-code-mitigations runtime flag.
      
      Likewise we embed two snapshots for builtins.
      
      Side-by-side snapshots won't be supported in Chromium.
      
      Bug: v8:7441
      Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524
      Reviewed-on: https://chromium-review.googlesource.com/960004
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52028}
      40d66d8b
  3. 07 Oct, 2016 1 commit
  4. 05 Oct, 2016 2 commits
    • adamk's avatar
      Revert of Reland "Turn libbase into a component" (patchset #1 id:1 of... · e75b9f6e
      adamk authored
      Revert of Reland "Turn libbase into a component" (patchset #1 id:1 of https://codereview.chromium.org/2395553002/ )
      
      Reason for revert:
      Speculative revert due to very strange-looking win/dbg failures
      which reference SignedDivisionByConstant:
      
      https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12736
      
      Original issue's description:
      > Reland "Turn libbase into a component"
      >
      > Original issue's description:
      > > Turn libbase into a component
      > >
      > > This is a precondition for turning libplatform into a component
      > >
      > > BUG=v8:5412
      > > R=jgruber@chromium.org,machenbach@chromium.org
      > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_
      > dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe
      > >
      > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104
      > > Cr-Commit-Position: refs/heads/master@{#39950}
      >
      > BUG=v8:5412
      > TBR=jgruber@chromium.org,machenbach@chromium.org
      > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng
      >
      > Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb
      > Cr-Commit-Position: refs/heads/master@{#39969}
      
      TBR=jgruber@chromium.org,machenbach@chromium.org,jochen@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5412
      
      Review-Url: https://codereview.chromium.org/2396933002
      Cr-Commit-Position: refs/heads/master@{#40009}
      e75b9f6e
    • jochen's avatar
      Reland "Turn libbase into a component" · 17cb5125
      jochen authored
      Original issue's description:
      > Turn libbase into a component
      >
      > This is a precondition for turning libplatform into a component
      >
      > BUG=v8:5412
      > R=jgruber@chromium.org,machenbach@chromium.org
      > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_
      dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe
      >
      > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104
      > Cr-Commit-Position: refs/heads/master@{#39950}
      
      BUG=v8:5412
      TBR=jgruber@chromium.org,machenbach@chromium.org
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng
      
      Review-Url: https://codereview.chromium.org/2395553002
      Cr-Commit-Position: refs/heads/master@{#39969}
      17cb5125
  5. 04 Oct, 2016 2 commits
  6. 08 Jun, 2016 1 commit
  7. 08 Apr, 2016 1 commit
  8. 24 Mar, 2016 2 commits
  9. 04 Feb, 2016 1 commit
  10. 07 Jan, 2016 1 commit
  11. 14 Aug, 2015 1 commit
    • vogelheim's avatar
      Rework startup-data-util. · c69e2eae
      vogelheim authored
      - Make the API look like v8::V8::InitializeICU.
        (That is: A static method call, not an object to be created on the stack.)
      - Fix path separator on Windows, by calling base::OS::isPathSeparator.
      - Move into API, so that it can be called by hello-world & friends.
      - Actually call it from hello-world and friends.
      
      R=jochen@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1292053002
      
      Cr-Commit-Position: refs/heads/master@{#30174}
      c69e2eae
  12. 07 May, 2015 1 commit
  13. 10 Feb, 2015 1 commit