- 20 Mar, 2018 1 commit
-
-
Michael Achenbach authored
This is a reland of 40d66d8b The fix disambiguates duplicate symbols in the generated embedded builtins file. Original change's description: > [build] Make separate snapshot for trusted variant > > This enables side-by-side snapshots with and without untrusted-code > mitigations. It'll be the default in all V8 stand-alone builds > with external startup data. Internal snapshots are not supported. > > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be > bundled with V8 on swarming and the correct file is loaded dependent > on the --untrusted-code-mitigations runtime flag. > > Likewise we embed two snapshots for builtins. > > Side-by-side snapshots won't be supported in Chromium. > > Bug: v8:7441 > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 > Reviewed-on: https://chromium-review.googlesource.com/960004 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52028} Bug: v8:7441 Change-Id: I626171d4e07389f0453b4d0a698e2772fd37e8c5 Reviewed-on: https://chromium-review.googlesource.com/968623 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52055}
-
- 19 Mar, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 40d66d8b. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/20910 Original change's description: > [build] Make separate snapshot for trusted variant > > This enables side-by-side snapshots with and without untrusted-code > mitigations. It'll be the default in all V8 stand-alone builds > with external startup data. Internal snapshots are not supported. > > The files snapshot_blob.bin and snapshot_blob_trusted.bin will be > bundled with V8 on swarming and the correct file is loaded dependent > on the --untrusted-code-mitigations runtime flag. > > Likewise we embed two snapshots for builtins. > > Side-by-side snapshots won't be supported in Chromium. > > Bug: v8:7441 > Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 > Reviewed-on: https://chromium-review.googlesource.com/960004 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52028} TBR=rmcilroy@chromium.org,machenbach@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: I5b18f7aff7c05a17842fc68d785bb617eeca4a41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7441 Reviewed-on: https://chromium-review.googlesource.com/968622Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52029}
-
Michael Achenbach authored
This enables side-by-side snapshots with and without untrusted-code mitigations. It'll be the default in all V8 stand-alone builds with external startup data. Internal snapshots are not supported. The files snapshot_blob.bin and snapshot_blob_trusted.bin will be bundled with V8 on swarming and the correct file is loaded dependent on the --untrusted-code-mitigations runtime flag. Likewise we embed two snapshots for builtins. Side-by-side snapshots won't be supported in Chromium. Bug: v8:7441 Change-Id: I2949ddfd5773649946b1c8e74751d48ad1d9c524 Reviewed-on: https://chromium-review.googlesource.com/960004 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52028}
-
- 07 Oct, 2016 1 commit
-
-
jochen authored
Reland of land "Turn libbase into a component" (patchset #1 id:1 of https://codereview.chromium.org/2396933002/ ) Reason for revert: let's see whether it sticks this time Original issue's description: > Revert of Reland "Turn libbase into a component" (patchset #1 id:1 of https://codereview.chromium.org/2395553002/ ) > > Reason for revert: > Speculative revert due to very strange-looking win/dbg failures > which reference SignedDivisionByConstant: > > https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12736 > > Original issue's description: > > Reland "Turn libbase into a component" > > > > Original issue's description: > > > Turn libbase into a component > > > > > > This is a precondition for turning libplatform into a component > > > > > > BUG=v8:5412 > > > R=jgruber@chromium.org,machenbach@chromium.org > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_ > > dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > > > > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > > > Cr-Commit-Position: refs/heads/master@{#39950} > > > > BUG=v8:5412 > > TBR=jgruber@chromium.org,machenbach@chromium.org > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng > > > > Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb > > Cr-Commit-Position: refs/heads/master@{#39969} > > TBR=jgruber@chromium.org,machenbach@chromium.org,jochen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5412 > > Committed: https://crrev.com/e75b9f6ed5da39e6c7a8d70cf48afbc9958afc85 > Cr-Commit-Position: refs/heads/master@{#40009} TBR=jgruber@chromium.org,machenbach@chromium.org,adamk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5412 Review-Url: https://codereview.chromium.org/2399323002 Cr-Commit-Position: refs/heads/master@{#40068}
-
- 05 Oct, 2016 2 commits
-
-
adamk authored
Revert of Reland "Turn libbase into a component" (patchset #1 id:1 of https://codereview.chromium.org/2395553002/ ) Reason for revert: Speculative revert due to very strange-looking win/dbg failures which reference SignedDivisionByConstant: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12736 Original issue's description: > Reland "Turn libbase into a component" > > Original issue's description: > > Turn libbase into a component > > > > This is a precondition for turning libplatform into a component > > > > BUG=v8:5412 > > R=jgruber@chromium.org,machenbach@chromium.org > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_ > dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > > Cr-Commit-Position: refs/heads/master@{#39950} > > BUG=v8:5412 > TBR=jgruber@chromium.org,machenbach@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng > > Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb > Cr-Commit-Position: refs/heads/master@{#39969} TBR=jgruber@chromium.org,machenbach@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5412 Review-Url: https://codereview.chromium.org/2396933002 Cr-Commit-Position: refs/heads/master@{#40009}
-
jochen authored
Original issue's description: > Turn libbase into a component > > This is a precondition for turning libplatform into a component > > BUG=v8:5412 > R=jgruber@chromium.org,machenbach@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_ dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > Cr-Commit-Position: refs/heads/master@{#39950} BUG=v8:5412 TBR=jgruber@chromium.org,machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng Review-Url: https://codereview.chromium.org/2395553002 Cr-Commit-Position: refs/heads/master@{#39969}
-
- 04 Oct, 2016 2 commits
-
-
machenbach authored
Revert of Turn libbase into a component (patchset #10 id:180001 of https://codereview.chromium.org/2381273002/ ) Reason for revert: Main suspect for roll block: https://codereview.chromium.org/2387403002/ Original issue's description: > Turn libbase into a component > > This is a precondition for turning libplatform into a component > > BUG=v8:5412 > R=jgruber@chromium.org,machenbach@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > Cr-Commit-Position: refs/heads/master@{#39950} TBR=jgruber@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5412 Review-Url: https://codereview.chromium.org/2393603002 Cr-Commit-Position: refs/heads/master@{#39960}
-
jochen authored
This is a precondition for turning libplatform into a component BUG=v8:5412 R=jgruber@chromium.org,machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2381273002 Cr-Commit-Position: refs/heads/master@{#39950}
-
- 08 Jun, 2016 1 commit
-
-
machenbach authored
This allows using icu data, bundled in the icudtl.dat file, to be loaded automatically from a default location side-by-side with the executable. The v8 stand-alone default is still to use statically linked ICU data, but this will be switched in a separate follow-up CL. BUG=chromium:616033 LOG=y Review-Url: https://codereview.chromium.org/2042253002 Cr-Commit-Position: refs/heads/master@{#36823}
-
- 08 Apr, 2016 1 commit
-
-
rmcilroy authored
Removes the seperate Ignition snapshot and build the Ignition bytecode handlers in the default snapshot. BUG=v8:4280 LOG=N Committed: https://crrev.com/1798f3fe84faff32ba44e09f6aed79245dd98d80 Cr-Commit-Position: refs/heads/master@{#35058} Review URL: https://codereview.chromium.org/1833643002 Cr-Commit-Position: refs/heads/master@{#35359}
-
- 24 Mar, 2016 2 commits
-
-
rmcilroy authored
Revert of [Interpreter] Remove separate Ignition snapshot. (patchset #2 id:20001 of https://codereview.chromium.org/1833643002/ ) Reason for revert: Makes nosnap bots timeout due to having to rebuild bytecode handlers. Original issue's description: > [Interpreter] Remove separate Ignition snapshot. > > Removes the seperate Ignition snapshot and build the Ignition bytecode > handlers in the default snapshot. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/1798f3fe84faff32ba44e09f6aed79245dd98d80 > Cr-Commit-Position: refs/heads/master@{#35058} TBR=machenbach@google.com,yangguo@chromium.org,mstarzinger@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review URL: https://codereview.chromium.org/1827143002 Cr-Commit-Position: refs/heads/master@{#35059}
-
rmcilroy authored
Removes the seperate Ignition snapshot and build the Ignition bytecode handlers in the default snapshot. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1833643002 Cr-Commit-Position: refs/heads/master@{#35058}
-
- 04 Feb, 2016 1 commit
-
-
machenbach authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1667673003 Cr-Commit-Position: refs/heads/master@{#33724}
-
- 07 Jan, 2016 1 commit
-
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1567733004 Cr-Commit-Position: refs/heads/master@{#33153}
-
- 14 Aug, 2015 1 commit
-
-
vogelheim authored
- Make the API look like v8::V8::InitializeICU. (That is: A static method call, not an object to be created on the stack.) - Fix path separator on Windows, by calling base::OS::isPathSeparator. - Move into API, so that it can be called by hello-world & friends. - Actually call it from hello-world and friends. R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1292053002 Cr-Commit-Position: refs/heads/master@{#30174}
-
- 07 May, 2015 1 commit
-
-
domenic authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1137473002 Cr-Commit-Position: refs/heads/master@{#28304}
-
- 10 Feb, 2015 1 commit
-
-
vogelheim authored
To do so, extract startup_data_util from d8 and use it those executables. BUG= Review URL: https://codereview.chromium.org/913703002 Cr-Commit-Position: refs/heads/master@{#26547}
-