1. 25 Oct, 2017 1 commit
  2. 29 May, 2017 1 commit
  3. 17 May, 2017 1 commit
    • Clemens Hammacher's avatar
      [wasm] Check for illegal br table count · 74519c43
      Clemens Hammacher authored
      The underlying issue is that TF Nodes cannot handle input counts
      outside the integer range. On an illegal br_table instruction, we
      generated a switch node with a control output count >kMaxInt.
      Operator::ControlOutputCount turned this into a negative integer later,
      leading to a failing DCHECK.
      Since such large numbers cannot occur in any valid wasm function anyway,
      we just add an additional check to the br table count. There is already
      a TODO in the code to change Operator::ControlOutputCount to size_t.
      
      R=ahaas@chromium.org
      BUG=chromium:722445
      
      Change-Id: I1975072226e073dee6c8da3b9fa9a050a4695917
      Reviewed-on: https://chromium-review.googlesource.com/505496Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#45365}
      74519c43
  4. 19 Oct, 2016 1 commit
  5. 09 Aug, 2016 1 commit
  6. 15 Jul, 2016 1 commit
    • bgeron's avatar
      [turbolizer] Show a label with a shorter parameter for some opcodes. · feb93dd6
      bgeron authored
      With this patch, every node in turbo-*.json has an opcode, a title, and
      a label. The label field is new; the opcode and title were already
      there. The title is for the mouseover text. The label is what will be
      displayed in the graph view, unless it's too long, in which case only
      the opcode will be displayed. (This is similar to the preexisting
      behaviour of putting titles in labels, except that the titles were
      rarely short enough to fit in a label.)
      
      With this patch, the labels generated are in practice the same as the
      titles we had before, except for LoadField and StoreField, which will be
      rendered as LoadField[[+432]] and StoreField[[+432]] (if 432 was the
      offset).
      
      This diff adds an overloadable method
      
          virtual void Operator1<T>::PrintParameter(ostream&, PrintVerbosity)
      
      for each type T to Operator1. Its default implementation just uses
      operator<<(ostream&, T const&) and adds square brackets around it, but
      it is overridden for FieldAccess to print "[+432]" in the example case.
      
      BUG=
      R=jarin,danno
      
      Review-Url: https://codereview.chromium.org/2093013002
      Cr-Commit-Position: refs/heads/master@{#37795}
      feb93dd6
  7. 17 Feb, 2015 1 commit
    • bmeurer's avatar
      [turbofan] Optimize certain chains of Branch into a Switch. · acd9c46c
      bmeurer authored
      This adds a new ControlFlowOptimizer that - for now - recognizes chains
      of Branches generated by the SwitchBuilder for a subset of javascript
      switches into Switch nodes. Those Switch nodes are then lowered to
      either table or lookup switches.
      
      Also rename Case to IfValue (and introduce IfDefault) for consistency.
      
      BUG=v8:3872
      LOG=n
      
      Review URL: https://codereview.chromium.org/931623002
      
      Cr-Commit-Position: refs/heads/master@{#26691}
      acd9c46c
  8. 09 Feb, 2015 1 commit
  9. 29 Oct, 2014 1 commit
  10. 07 Oct, 2014 1 commit
  11. 12 Sep, 2014 1 commit
  12. 02 Sep, 2014 1 commit