- 24 Aug, 2022 6 commits
-
-
Feng Yu authored
Bug: v8:12781 Change-Id: I1b0be6803d6a9f4ab7071bc3ae5abeb8f29ce9c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829753 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/main@{#82680}
-
Samuel Groß authored
All (most) accesses to start_of_evacuation_area_ must be atomic as that value may be written to from a background marking thread (when compaction is aborted). Further, when evacuating entries, the start_of_evacuation_area_ should not be reloaded during entry allocation as it may have been modified by another background thread. In that case, the method may end up allocating an evacuation entry _after_ the entry to be evacuated, which doesn't make sense. Drive-by: move some methods from external-pointer-table-inl.h into external-pointer-table.cc. Bug: v8:10391 Change-Id: Ia93cffb2cc311ef03d96d3a9ae6f0cf461cf2434 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849376Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#82679}
-
Samuel Groß authored
This CL introduces new FixedArray subclasses that behave like fixed-sized arrays of integers. Under the hood, these are just ByteArrays with integer element accessors. These new classes will be used in follow-up CLs which moves various integer arrays from the native heap onto the V8 heap. Bug: chromium:1335046 Change-Id: Ie7497b4464c1a037e4eaf49e8bf7ac4da62512de Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3838775Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#82678}
-
Samuel Groß authored
When a NativeContext is being serialized, the NativeContext's microtask_queue is set to nullptr as it is not included in the snapshot. However, when the sandbox is enabled, this will only set the pointer in the external pointer table to nullptr, but not the handle stored in the object. This then causes the deserialized object to briefly be invalid, before it's microtask queue handle is (re-)initialized. If a GC runs during that timeframe, it will see an invalid external pointer handle, which may cause DCHECK failures. To fix this, this CL now introduces a generic mechanism for clearing and restoring external pointer slots for serialization. Bug: v8:13218 Change-Id: I03c8779bbec0a42a0b66687e76c951b1887e6122 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850294Reviewed-by:
-
Iain Ireland authored
Post-early-errors, syntax errors can't be caught, so the testcase has to be modified so that we parse successfully (then overflow the stack). Bug: v8:13163 Change-Id: I894c65bb4712f557d697b028b220444ccf6bb09c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3818602 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/b3070c5..31c77cb Update TZ to 2022b (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/31c77cb R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I9c209d387e5f1f3f79084bfd89a19a6bf3907a67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852451 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82675}
-
- 23 Aug, 2022 34 commits
-
-
Milad Fa authored
Change-Id: I8545da4fa9eff1ff7de3779022fe2c34966951d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846853Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82674}
-
Michael Lippautz authored
No-Try: true Change-Id: Ica1a6a3d432392df8acee9acf7fc460d71ba8b10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3851542Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82673}
-
Leszek Swirski authored
This reverts commit e1f585ed. Reason for revert: GPU bot issues on roll (https://ci.chromium.org/ui/p/chromium/builders/try/linux_optional_gpu_tests_rel/87951/overview) Original change's description: > [sandbox] Sandboxify EmbedderDataSlots > > Bug: v8:10391 > Change-Id: If85a308a6f6ed1b17d86f87b4911c82d2327ea72 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757341 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82623} Bug: v8:10391, chromium:1355640 Change-Id: Iaba70796de18d5f3b3dc74cf068943093c0bf567 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850722Reviewed-by:
-
Michael Lippautz authored
This reverts commit 2115ba50. Reason for revert: Breaking Blink tests. Original change's description: > [cppgc-js] Allow overriding marking support > > Adds flags to allow overriding marking support. This adds > compatibility with EmbedderHeapTracer which allows for disabling > incremental marking support with `--no-incremental-marking-wrappers`. > > The corresponding CppHeap flags are > * `--cppheap-incremental-marking` > * `--cppheap-concurrent-marking` > > This allows embedders that use types that do not support incremental > and concurrent marking to switch from EmbedderHeapTracer to CppHeap. > > Bug: v8:13207 > Change-Id: I74bdf8ef4be3f6aed8d4d587ea4399546ba2fda4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840939 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82652} Bug: v8:13207 Change-Id: I9e0de0cacfab8489902fef1c371e36c2d45b80ec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850723 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Seth Brenith authored
This can save memory in cases where multiple frames use the same script, with sufficient time between loads that the script's top-level SharedFunctionInfo is no longer present in the compilation cache. Merging is relatively fast; it generally takes about one tenth as long as deserialization. Bug: v8:12808 Change-Id: I317a89b77fb218798dfc9dfd888e808b17d62fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845792Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#82670}
-
Darius M authored
Change-Id: I951bdf428a7429b3500757ae3fcfb029c814001a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845631Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#82669}
-
Feng Yu authored
Bug: v8:12781 Change-Id: I5b605db296c2a2813a44f05c74500cc1a0049f57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3832175 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
ishell@chromium.org authored
... when the code range is created. This key should be more helpful than the existing kCodeSpaceFirstPageAddress crash key, especially for the cases when snapshot does not contain Code objects and thus the code space is not created during Isolate initialization. The mid-term plan is to remove the latter in favour of the former since the default configuration does not imply creation of the code space. Bug: v8:11880 Change-Id: Icdea38723c7ed73605c2df6589ec01193571d55c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849038Reviewed-by:
-
ishell@chromium.org authored
Sparkplug generates a lot of code and the default limit of 128 MB also hurts non-pointer compression builds which is used by Node.js. This CL keeps the old limit only for pointer compression configurations without external code space because in this case the code range is allocated in the pointer compression cage and thus bigger code range steals the address space from the regular V8 heap. Bug: v8:12689 Change-Id: I3c68daf6cd5322d7e30249a054a7c6d6e38fb8c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850291 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Dominik Inführ authored
IsRunning() and IsMarking() are now equivalent. So IsRunning() can be removed in favor of IsMarking(). IsComplete() is also renamed to IsMarkingComplete(). Bug: v8:12775 Change-Id: Ife88be4d674af055590ba5178ec1e410f8fa89d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849833Reviewed-by:
-
Leszek Swirski authored
Now roll_merge_gerrit.py waits for a +1, and immediately submits. With auto-submit and rubber-stamper bot, this makes the script fully fire-and-forget. This also fixes the commit message update to include the change id. Bug: v8:12849 Change-Id: I63784bfc1b2a16dfcd308b11e67d9da9c2ff3f8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804249Reviewed-by:
Liviu Rau <liviurau@google.com> Commit-Queue: Liviu Rau <liviurau@google.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82664}
-
Leszek Swirski authored
Add a stack check to maglev function entry, and ensure that there is deopt info on the safepoint when there is a loop interrupt which can also stack check. These are somewhat hacky fixes for now, both of which do the minimal work to make OptimizedFrame::Summarize work. There are some TODOs on making this better, in particular not relying on lazy deopt info for said summarize. Cleaning this up will likely be part of a larger piece of work around exception support. Bug: v8:7700 Fixed: v8:13152, v8:13153, v8:13154, v8:13162 Change-Id: Ib9e4820200806a3f7d08fb8b069655525f90efb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3811285Reviewed-by:
-
ishell@chromium.org authored
... to globals.h. The latter is included into flags.h and thus the flag-defnitions.h can rely on those values to be defined. The xxx_BOOL macros that were used in #if expressions in flag-definitions.h are now explicitly checked for being defined. This change allows using the constants also in the globals.h header. Bug: v8:12689 Change-Id: I2498502284ab1e8dc8a3526229613ea1ce6624bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849377 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Samuel Groß authored
When compaction is aborted during marking, the start_of_evacuation_area_ value would previously be set to -1. This would, however, cause some DCHECK failures during sweeping, which expect this value to contain the (previous) start value. This is now fixed by just setting the top bits of the start_of_evacuation_area_ value when aborting compaction. During sweeping, these bits are cleared again and the DCHECKs work as expected. Bug: v8:10391, chromium:1355640 Change-Id: Id48ee71a3942b3e0b88e8e1667a8f9e109a68bb3 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849650 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is mostly to make fuzzers happy. Currently, adding --future changes user-observable behaviour if also --wasm-lazy-validation is passed, because --future implies --wasm-lazy-compilation. By implying --wasm-lazy-compilation from --wasm-lazy-validation, we make this independent of --future, and foozzie should be happy. R=jkummerow@chromium.org Bug: chromium:1355062 Change-Id: I47161c107de6ef00395a2a5e3284fc5ceae37d3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850483Reviewed-by:
-
Dominik Inführ authored
Delayed tasks were never used, so remove support for it. The only supported task type is therefore "normal", immediately scheduled tasks. Bug: v8:12775 Change-Id: Ifd659deae2b98f424d889e4253f79d9b031a82d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849831Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I0133eb2180952a25a056dce0efbc282bc05b2a1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849040 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Ryan Everett authored
Generate Tbz/Tbnz instead of (tst;bcc), and Cbz/Cbnz instead of (cmp;bcc), where possible. This improves Speedometer2 by 0.22% on a Neoverse-N1 machine. Change-Id: Ie86bae7189a7a4bd4975f946e7413225c9023316 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3833816 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82657}
-
Derek Gonyeo authored
Use the `fuchsia_component` and `fuchsia_package` GN templates from the Fuchsia SDK to package the `v8_unittests` test for Fuchsia. Give the `v8_unittests` their own dedicated `.cmx` file, instead of depending on `v8.cmx`. Bug: chromium:1256503 Change-Id: I22788359bed18eb643e288ee1a0c92c24c0dc3e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3819644Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Derek Gonyeo <dgonyeo@google.com> Cr-Commit-Position: refs/heads/main@{#82656}
-
Leon Bettscheider authored
This CL adjusts MarkingBarrier for MinorMC incremental marking. The MarkingBarrier will be activated in a follow-up CL that schedules MinorMC on a soft limit. Bug: v8:13012 Change-Id: I525f6f158c2d55074d66f51925a1d8220cd4e9b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3787874 Commit-Queue: Leon Bettscheider <bettscheider@google.com> Reviewed-by:
-
Victor Gomes authored
Add return register to the allocator. SetPendingMessage is a ValueNode and returns the previous pending message. This was not identified before, because we do not support exception handlers yet. Bug: v8:7700 Change-Id: Ia03ea609e85297198792816edda22d4f1c79708c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849652 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This is a reland of commit c3a5c5b1 The previous CL was writing into the wrong sets when invoking CollectSlots<OLD_TO_SHARED>(). Also move the NULL checks out of that condition to also check this for chunks in the young generation. Original change's description: > [heap] Ensure all old-to-shared slots are recorded > > This CL adds verification of the old-to-shared remembered set to > --verify-heap. During shared GCs client heaps will be scanned for > references into the shared heap, this CL will CHECK that every found > slot is contained in the old-to-shared remembered set. After this > gets a bit more stable, the full heap iteration can be dropped and we > can fully rely on the remembered set instead. > > Bug: v8:11708 > Change-Id: I0b5c4edfe3271306e4e7af7394472534113e1953 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3792605 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82578} Bug: v8:11708 Change-Id: I24b7787977f06708efb7a017dd1ec72f78d0ea13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3841570Reviewed-by:
-
Michael Lippautz authored
Adds flags to allow overriding marking support. This adds compatibility with EmbedderHeapTracer which allows for disabling incremental marking support with `--no-incremental-marking-wrappers`. The corresponding CppHeap flags are * `--cppheap-incremental-marking` * `--cppheap-concurrent-marking` This allows embedders that use types that do not support incremental and concurrent marking to switch from EmbedderHeapTracer to CppHeap. Bug: v8:13207 Change-Id: I74bdf8ef4be3f6aed8d4d587ea4399546ba2fda4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840939Reviewed-by:
-
Michael Lippautz authored
Publish all local worklists and don't ignore the one corresponding to the current context. Bug: chromium:1355679 Change-Id: I1944acd6258178d509610d3806c5aca047bbbbf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849651 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
wenqin.yang authored
There is somes flag errors in the comments, which clarify how to use pgo for builtin. Change-Id: I0c418aee57adb7c6774735d32fc63a143bee5c7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849654Reviewed-by:
-
Jakob Linke authored
This reverts commit c060af4d. Reason for revert: Fails with `v8_enable_verify_csa = true`: ``` # Fatal error in ../../src/compiler/machine-graph-verifier.cc, line 821 # TypeError: node #1503:Word32Equal uses node #1501:Load[kRepWord64] which doesn't have a compressed, tagged, or int32 representation. # Current block: id:187 <= id:154 <= id:183 <= id:93 <= id:144 # # Specify option --csa-trap-on-node=RegExpExecInternal,1503 for debugging. ``` Original change's description: > Fix CSA_CHECK failure on BE > > The load for external reference should be a full pointer load > instead of tagged size. > > Change-Id: I3460a26abea5053ba6daa5c6ed908cb93431654a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3842348 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/main@{#82625} Change-Id: Iaf9d0432157cba8c585377d33083a798c62e516c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3848171 Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82649}
-
Michael Lippautz authored
- Swap() was not necessary as all uses merely required Merge() - Remove unused empty Local ctor - Use refrence for backref as it's always supposed to be non-null Bug: v8:13193 Change-Id: Ide0a0de15185a67d028890371ae30528fd55a058 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846863Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82648}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/77d1e74..e8baf26 Link error when use as static library on windows. (#1470) (Pavel V. Sysolyatin) https://chromium.googlesource.com/external/github.com/google/benchmark/+/e8baf26 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I3d24d85c9f69c2ef17695056d0a44d7ebbe26c5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849647 Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Reviewed-by:
Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#82647}
-
Leszek Swirski authored
This reverts commit 40901824. Reason for revert: UBSan errors (https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/22822/overview) Original change's description: > [ext-code-space] Enable Code-less embedded builtins > > Bug: v8:11880, v8:12592 > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82642} Bug: v8:11880, v8:12592 Change-Id: Iaf0f87d2e5c1e1e3876d3edc6a82c8578eed81bb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846471 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82646}
-
Feng Yu authored
Bug: v8:12781 Change-Id: I649318b653d62ba484d6b2d96ee66e8fb30ad6b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829324Reviewed-by:
-
Jakob Linke authored
.. in OptimizedCompilationInfo. Bug: v8:7700 Change-Id: I1dcff9c798ae3e70ae5dd84d815f45f7303e39e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845083Reviewed-by:
-
Matthias Liedtke authored
This change adds support for new table element types besides the existing support for func and extern. The newly supported types are the generic types of the 'any' subtype hierarchy: any, eq, data and array. All these table types are also usable and accessible via JavaScript, causing implicit internalization and externalization of the elements on Table::get() and Table::set(). Bug: v8:7748 Change-Id: Ie85d8f5e1d70471360dd2fb8a39cd38efaac2c22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3838729Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
ishell@chromium.org authored
Bug: v8:11880, v8:12592 Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
wenqin.yang authored
We found there are redundant load context operations in some bytecode array. like this: LdaImmutableCurrentContextSlot [1] Star0 ...... (don’t edit accumulator) LdaImmutableCurrentContextSlot [1] Star1 Add r1 In that case, we could modify this bytecode array as: LdaImmutableCurrentContextSlot [1] Star0 ...... (don’t edit accumulator) Add r0 This CL will elide these redundant bytecodes (LdaImmutableCurrentContextSlot and Star1), because there is no side effect for loading context, and this context slot is immutable. Change-Id: Ia26f4b934d3bd1d48c50c0c4699ba7942939991c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3816221Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82641}
-
