1. 18 Jun, 2019 1 commit
  2. 12 Jun, 2019 2 commits
  3. 11 Jun, 2019 1 commit
  4. 03 Apr, 2019 1 commit
  5. 29 Mar, 2019 1 commit
  6. 08 Mar, 2019 1 commit
  7. 01 Mar, 2019 1 commit
  8. 03 Feb, 2019 1 commit
  9. 16 Jan, 2019 1 commit
  10. 08 Jan, 2019 1 commit
  11. 27 Dec, 2018 1 commit
  12. 21 Dec, 2018 1 commit
  13. 20 Dec, 2018 1 commit
  14. 13 Dec, 2018 1 commit
  15. 06 Dec, 2018 1 commit
    • Dmitry Gozman's avatar
      Revert "inspector: return [[StableObjectId]] as internal property" · 4401ac44
      Dmitry Gozman authored
      This reverts commit d9fbfeb8.
      
      Reason for revert: see bug.
      Bug: 906847
      
      Original change's description:
      > inspector: return [[StableObjectId]] as internal property
      > 
      > This property might be useful for fast '===' check.
      > 
      > R=​dgozman@chromium.org,yangguo@chromium.org
      > 
      > Bug: none
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
      > Reviewed-on: https://chromium-review.googlesource.com/1226411
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56095}
      
      TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: none
      Change-Id: I68c700b7b8fd0a015f099460c15665d74e4da183
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/1363558Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58077}
      4401ac44
  16. 21 Nov, 2018 1 commit
  17. 15 Nov, 2018 1 commit
  18. 05 Nov, 2018 1 commit
    • peterwmwong's avatar
      [builtins] Add Array.p.join fastpath for single element array. · 986aa36b
      peterwmwong authored
      This is resurrecting an optimization from the pre-torque version.
      Avoid allocating another sequential string for the result when there's only one
      element, just return the ToString-ed element.  This not only saves time writing
      to this destination string, but also reduce GC pressure.
      
      The System Health Memory Benchmark (load:media:google_images) exposed this missing
      optimization with a 15% regression in memory usage.  Very large external strings
      were being copied into V8's heap as sequential string.
      
      Bug: chromium:896612
      Change-Id: Ieb61906f64100cdc15bf96f3ebcccb1207f75356
      Reviewed-on: https://chromium-review.googlesource.com/c/1316620Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
      Cr-Commit-Position: refs/heads/master@{#57241}
      986aa36b
  19. 31 Oct, 2018 2 commits
    • Alexey Kozyatinskiy's avatar
      reland: inspector: move injected script source to native · ebd070ec
      Alexey Kozyatinskiy authored
      - introduced ValueMirror interface, this interface contains methods to generate
        different protocol entities,
      - introduced DebugPropertyIterator, this iterator iterates through object properties
        in the following order: exotic indices, enumerable strings, all other properties,
      - removed all injected script infra, e.g. closure compiler,
      
      R=dgozman@chromium.org
      TBR=yangguo@chromium.org
      
      Bug: chromium:595206
      Change-Id: I030fdb3a80074ca6edd4749f86b39b590776ae6f
      Reviewed-on: https://chromium-review.googlesource.com/c/1310056Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57181}
      ebd070ec
    • Aleksey Kozyatinskiy's avatar
      Revert "inspector: move injected script source to native" · fc5c8d7f
      Aleksey Kozyatinskiy authored
      This reverts commit 7e079c66.
      
      Reason for revert: native implementation should be ready for navigation.
      
      Original change's description:
      > inspector: move injected script source to native
      > 
      > - introduced ValueMirror interface, this interface contains methods to generate
      >   different protocol entities,
      > - introduced DebugPropertyIterator, this iterator iterates through object properties
      >   in the following order: exotic indices, enumerable strings, all other properties,
      > - removed all injected script infra, e.g. closure compiler,
      > 
      > R=​dgozman@chromium.org
      > TBR=yangguo@chromium.org
      > 
      > Bug: chromium:595206
      > Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1308353
      > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57150}
      
      TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org
      
      Change-Id: I8c5c61f4cfe5a66cd33eadd02ab4acec539cc3bb
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:595206
      Reviewed-on: https://chromium-review.googlesource.com/c/1310055Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57176}
      fc5c8d7f
  20. 30 Oct, 2018 3 commits
    • Alexey Kozyatinskiy's avatar
      inspector: move injected script source to native · 7e079c66
      Alexey Kozyatinskiy authored
      - introduced ValueMirror interface, this interface contains methods to generate
        different protocol entities,
      - introduced DebugPropertyIterator, this iterator iterates through object properties
        in the following order: exotic indices, enumerable strings, all other properties,
      - removed all injected script infra, e.g. closure compiler,
      
      R=dgozman@chromium.org
      TBR=yangguo@chromium.org
      
      Bug: chromium:595206
      Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2
      Reviewed-on: https://chromium-review.googlesource.com/c/1308353Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57150}
      7e079c66
    • Clemens Hammacher's avatar
      Revert "inspector: move injected script source to native" · 192bee6b
      Clemens Hammacher authored
      This reverts commit 34686abe.
      
      Reason for revert: Compile errors on several bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug%20builder/33299
      
      Original change's description:
      > inspector: move injected script source to native
      > 
      > - introduced ValueMirror interface, this interface contains methods to generate
      >   different protocol entities,
      > - introduced DebugPropertyIterator, this iterator iterates through object properties
      >   in the following order: exotic indices, enumerable strings, all other properties,
      > - removed all injected script infra, e.g. closure compiler,
      > 
      > R=​dgozman@chromium.org
      > TBR=yangguo@chromium.org
      > 
      > Bug: chromium:595206
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22
      > Reviewed-on: https://chromium-review.googlesource.com/c/1295550
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57142}
      
      TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org
      
      Change-Id: I6e4ccaf1d6b151fbc0ffe4f26daa584433321c77
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:595206
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/1307432Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57144}
      192bee6b
    • Alexey Kozyatinskiy's avatar
      inspector: move injected script source to native · 34686abe
      Alexey Kozyatinskiy authored
      - introduced ValueMirror interface, this interface contains methods to generate
        different protocol entities,
      - introduced DebugPropertyIterator, this iterator iterates through object properties
        in the following order: exotic indices, enumerable strings, all other properties,
      - removed all injected script infra, e.g. closure compiler,
      
      R=dgozman@chromium.org
      TBR=yangguo@chromium.org
      
      Bug: chromium:595206
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22
      Reviewed-on: https://chromium-review.googlesource.com/c/1295550
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57142}
      34686abe
  21. 22 Oct, 2018 2 commits
    • Alexey Kozyatinskiy's avatar
      inspector: generate custom preview using native code · 66daabcc
      Alexey Kozyatinskiy authored
      Full custom preview generation is moved to custom-preview file
      including frontend part. New custom preview implementation returns
      body getter function instead of bind function, formatter and config
      objects. Body getter function calls formatter.body(object, config)
      and returns json ML.
      
      R=dgozman@chromium.org
      
      Bug: chromium:595206
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I14ff3d8abb4a47d2bbc2e6eaa1835fc362ac7369
      Reviewed-on: https://chromium-review.googlesource.com/c/1292686
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56872}
      66daabcc
    • Alexey Kozyatinskiy's avatar
      inspector: add couple tests · c949f19b
      Alexey Kozyatinskiy authored
      Test to cover a lot of injected script source corner cases.
      
      R=dgozman@chromium.org
      
      Bug: chromium:595206
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Ia631de58c5a92b39ec3933c56cf7e3f108b9bd9e
      Reviewed-on: https://chromium-review.googlesource.com/c/1292688
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56863}
      c949f19b
  22. 01 Oct, 2018 1 commit
  23. 28 Sep, 2018 2 commits
  24. 20 Sep, 2018 1 commit
  25. 29 Aug, 2018 1 commit
  26. 05 Jul, 2018 1 commit
  27. 22 Jun, 2018 1 commit
  28. 04 Jun, 2018 1 commit
  29. 01 Jun, 2018 3 commits
    • Alexey Kozyatinskiy's avatar
      Reland "[inspector] added Runtime.installBinding method" · 5cb11a17
      Alexey Kozyatinskiy authored
      This is a reland of 49c4ac77
      
      Original change's description:
      > [inspector] added Runtime.installBinding method
      >
      > A lot of different clients use console.debug as a message channel from
      > page to protocol client. console.debug is a little slow and not
      > designed for this use case.
      >
      > This CL introduces new method: Runtime.installBinding. This method
      > installs binding function by given name on global object on each
      > inspected context including any context created later.
      > Binding function takes exactly one string argument. Each time when
      > binding function is called, Runtime.bindingCalled notification is
      > triggered and includes passed payload.
      >
      > Binding function survives page reload and reinstalled right after
      > console object is setup. So installed binding can be used inside
      > script added by Page.addScriptToEvaluateOnNewDocument so client may do
      > something like:
      > Runtime.installBinding({name: 'send'});
      > Page.addScriptToEvaluateOnNewDocument({source: 'console.debug = send'});
      > .. navigate page ..
      >
      > In microbenchmark this function is ~4.6 times faster then
      > console.debug.
      >
      > R=lushnikov@chromium.org,pfeldman@chromium.org
      >
      > Bug: none
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I3e0e231dde9d45116709d248f6e9e7ec7037e8e3
      > Reviewed-on: https://chromium-review.googlesource.com/1077662
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53462}
      
      TBR=dgozman@chromium.org
      
      Bug: none
      Change-Id: I58d053581a86f15338dea621498058b7b75c7c85
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/1081833Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53479}
      5cb11a17
    • Sergiy Byelozyorov's avatar
      Revert "[inspector] added Runtime.installBinding method" · 7bd8b1c0
      Sergiy Byelozyorov authored
      This reverts commit 49c4ac77.
      
      Reason for revert: breaks linux_chromium_rel_ng when rolling into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/107377
      
      Original change's description:
      > [inspector] added Runtime.installBinding method
      > 
      > A lot of different clients use console.debug as a message channel from
      > page to protocol client. console.debug is a little slow and not
      > designed for this use case.
      > 
      > This CL introduces new method: Runtime.installBinding. This method
      > installs binding function by given name on global object on each
      > inspected context including any context created later.
      > Binding function takes exactly one string argument. Each time when
      > binding function is called, Runtime.bindingCalled notification is
      > triggered and includes passed payload.
      > 
      > Binding function survives page reload and reinstalled right after
      > console object is setup. So installed binding can be used inside
      > script added by Page.addScriptToEvaluateOnNewDocument so client may do
      > something like:
      > Runtime.installBinding({name: 'send'});
      > Page.addScriptToEvaluateOnNewDocument({source: 'console.debug = send'});
      > .. navigate page ..
      > 
      > In microbenchmark this function is ~4.6 times faster then
      > console.debug.
      > 
      > R=​lushnikov@chromium.org,pfeldman@chromium.org
      > 
      > Bug: none
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I3e0e231dde9d45116709d248f6e9e7ec7037e8e3
      > Reviewed-on: https://chromium-review.googlesource.com/1077662
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53462}
      
      TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org
      
      Change-Id: I1ebafd42db01d8a6435d58386f2c667b92db12f1
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: none
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/1082311Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53470}
      7bd8b1c0
    • Hidy Han's avatar
      Expose Runtime.setAsyncCallStackDepth API for async stack collection. · f69527ee
      Hidy Han authored
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I4a29336a585bb690f915c876b3b07eb2601d027b
      Reviewed-on: https://chromium-review.googlesource.com/1080225
      Commit-Queue: Hidy Han <hidyhan@chromium.org>
      Reviewed-by: 's avatarPavel Feldman <pfeldman@chromium.org>
      Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53466}
      f69527ee
  30. 31 May, 2018 3 commits
    • Alexey Kozyatinskiy's avatar
      [inspector] added Runtime.installBinding method · 49c4ac77
      Alexey Kozyatinskiy authored
      A lot of different clients use console.debug as a message channel from
      page to protocol client. console.debug is a little slow and not
      designed for this use case.
      
      This CL introduces new method: Runtime.installBinding. This method
      installs binding function by given name on global object on each
      inspected context including any context created later.
      Binding function takes exactly one string argument. Each time when
      binding function is called, Runtime.bindingCalled notification is
      triggered and includes passed payload.
      
      Binding function survives page reload and reinstalled right after
      console object is setup. So installed binding can be used inside
      script added by Page.addScriptToEvaluateOnNewDocument so client may do
      something like:
      Runtime.installBinding({name: 'send'});
      Page.addScriptToEvaluateOnNewDocument({source: 'console.debug = send'});
      .. navigate page ..
      
      In microbenchmark this function is ~4.6 times faster then
      console.debug.
      
      R=lushnikov@chromium.org,pfeldman@chromium.org
      
      Bug: none
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I3e0e231dde9d45116709d248f6e9e7ec7037e8e3
      Reviewed-on: https://chromium-review.googlesource.com/1077662
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53462}
      49c4ac77
    • Sergiy Byelozyorov's avatar
      Revert "[inspector] RemoteObject.description should be empty for primitive type" · bbfe7f32
      Sergiy Byelozyorov authored
      This reverts commit 003159e7.
      
      Reason for revert: breaks roll into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/3140
      
      Original change's description:
      > [inspector] RemoteObject.description should be empty for primitive type
      > 
      > We currently report description field for numbers. On client side user
      > can calculate description as remoteObject.unserializableValue ||
      > (remoteObject.value + ''). Let's report description only for objects to
      > simplify value -> remoteObject logic a bit.
      > 
      > R=​dgozman@chromium.org
      > TBR=jgruber@chromium.org
      > 
      > Bug: chromium:595206
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc
      > Reviewed-on: https://chromium-review.googlesource.com/737485
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53453}
      
      TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org
      
      Change-Id: Ifc184e1ac158d9ea7034922a7250444448fac49f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:595206
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/1081207Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53461}
      bbfe7f32
    • Alexey Kozyatinskiy's avatar
      [inspector] RemoteObject.description should be empty for primitive type · 003159e7
      Alexey Kozyatinskiy authored
      We currently report description field for numbers. On client side user
      can calculate description as remoteObject.unserializableValue ||
      (remoteObject.value + ''). Let's report description only for objects to
      simplify value -> remoteObject logic a bit.
      
      R=dgozman@chromium.org
      TBR=jgruber@chromium.org
      
      Bug: chromium:595206
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc
      Reviewed-on: https://chromium-review.googlesource.com/737485
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarPavel Feldman <pfeldman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53453}
      003159e7