Commits · 0c614e2b48833e66d55fd4ad7152adf165626d2b · Linshizhi / V8

17 Apr, 2014 3 commits

Some MaybeHandles related cleanups. · 0c614e2b

yangguo@chromium.org authored Apr 17, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/240443005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20832 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0c614e2b

Track up to 5 stable maps as field type. · 779e87b8

bmeurer@chromium.org authored Apr 17, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/240813002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

779e87b8

Remove uses of MaybeObject in runtime.cc. · 556aea63

yangguo@chromium.org authored Apr 17, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/240253003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20828 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

556aea63

16 Apr, 2014 37 commits

Adjust memory limits. · ec73d3db

palfia@homejinni.com authored Apr 16, 2014

- Introduce new constant: kBootCodeSizeMultiplier to handle the code size differences across the platforms.

- Increase memory limits due to larger code size on MIPS.

BUG=
R=danno@chromium.org, plind44@gmail.com

Review URL: https://codereview.chromium.org/234153002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20825 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec73d3db

Revert "ES6: Add support for Map/Set forEach" · 91618cf1

adamk@chromium.org authored Apr 16, 2014

This reverts https://code.google.com/p/v8/source/detail?r=20823

It broke Windows builds. Will need to find a Windows try bot to figure
out why.

TBR=mstarzinger@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/238973011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20824 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91618cf1

ES6: Add support for Map/Set forEach · 7c300d1f

adamk@chromium.org authored Apr 16, 2014

This implements MapIterator and SetIterator which matches
the same constructs in the ES6 spec. However, these 2
iterators are not exposed to user code yet. They are only
used internally to implement Map.prototype.forEach and
Set.prototype.forEach.

Each iterator has a reference to the OrderedHashTable where
it directly accesses the hash table's entries.

The OrderedHashTable has a reference to the newest iterator
and each iterator has a reference to the next and previous
iterator, effectively creating a double linked list.

When the OrderedHashTable is mutated (or replaced) all the
iterators are updated.

When the iterator iterates passed the end of the data table
it closes itself. Closed iterators no longer have a
reference to the OrderedHashTable and they are removed from
the double linked list. In the case of Map/Set forEach, we
manually call Close on the iterator in case an exception was
thrown so that the iterator never reached the end.

At this point the OrderedHashTable keeps all the non finished
iterators alive but since the only thing we currently expose
is forEach there are no unfinished iterators outside a forEach
call. Once we expose the iterators to user code we will need
to make the references from the OrderedHashTable to the
iterators weak and have some mechanism to close an iterator
when it is garbage collected.

BUG=1793,2323
LOG=Y
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/240323003

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20823 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c300d1f

MIPS: Implement structural function and array types · 4635a125

plind44@gmail.com authored Apr 16, 2014

Port r20817 (e7a84c1)

Original commit message:
Just wanted to add two constructors to a datatype, how ugly can it get?

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/240463004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20822 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4635a125

Callers of Heap::AllocateStringFromOneByte() and Heap::AllocateStringFromUtf8() handlified. · fe3e5706

ishell@chromium.org authored Apr 16, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/239083005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20821 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe3e5706

Handlify HashTable and Dictionary growing. · 28285083

dslomov@chromium.org authored Apr 16, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/240023004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28285083

Implement structural function and array types · 28912cae

rossberg@chromium.org authored Apr 16, 2014

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Committed: https://code.google.com/p/v8/source/detail?r=20815

Committed: https://code.google.com/p/v8/source/detail?r=20818

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20819 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28912cae

Implement structural function and array types · 02687c79

rossberg@chromium.org authored Apr 16, 2014

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Committed: https://code.google.com/p/v8/source/detail?r=20815

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20818 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

02687c79

Implement structural function and array types · 926ec656

rossberg@chromium.org authored Apr 16, 2014

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Committed: https://code.google.com/p/v8/source/detail?r=20815

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

926ec656

Revert "Implement structural function and array types" · e3e81d85

rossberg@chromium.org authored Apr 16, 2014

TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/237963016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e3e81d85

Implement structural function and array types · 6782d9ce

rossberg@chromium.org authored Apr 16, 2014

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6782d9ce

Handlify and convert the remaining Script accesssors. · 3e49c601

ulan@chromium.org authored Apr 16, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/236313015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20814 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3e49c601

Reland r20772 "Handlifying clients of StringTable, step 1." · dd206283

ishell@chromium.org authored Apr 16, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/238263003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dd206283

Handlify callers of AllocateUninitializedFixedArray. · f70a26bc

yangguo@chromium.org authored Apr 16, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/235943015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f70a26bc

Handlify number-related allocators. · 3abbb03c

yangguo@chromium.org authored Apr 16, 2014

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/240293002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20811 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3abbb03c

Revert "Implement structural function and array types" · a947aeb3

rossberg@chromium.org authored Apr 16, 2014

TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/240143003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a947aeb3

Implement structural function and array types · 7de4c1c6

rossberg@chromium.org authored Apr 16, 2014

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7de4c1c6

Handlify six more allocators in from the Heap class. · e8ad0c3e

mstarzinger@chromium.org authored Apr 16, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/240263002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20808 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e8ad0c3e

Reland "Move functions from handles.cc to where they belong." · 7af55972

yangguo@chromium.org authored Apr 16, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/239113009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7af55972

ARM64: Fix native builds · 10bbd655

m.m.capewell@googlemail.com authored Apr 16, 2014

Rearrange sed lines to enable native builds for ARM64.

BUG=
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/238543009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10bbd655

Handlify Heap::AllocateAllocationSite. · 41f986e6

mstarzinger@chromium.org authored Apr 16, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/239993003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

41f986e6

Revert "Move functions from handles.cc to where they belong." · 0cba01c4

yangguo@chromium.org authored Apr 16, 2014

This reverts r20802 .

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/239543010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0cba01c4

Limit the lifetime of handles in Map::UpdateCodeCache. · deecd576

dslomov@chromium.org authored Apr 16, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/236313014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

deecd576

Move functions from handles.cc to where they belong. · 3b669576

yangguo@chromium.org authored Apr 16, 2014

R=mvstanton@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/237673014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b669576

Handlify CodeCache. · 35a30a5a

dslomov@chromium.org authored Apr 16, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/239203003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

35a30a5a

Removed Isolate::EnterDefaultIsolate. · 7976d95c

svenpanne@chromium.org authored Apr 16, 2014

BUG=359977
LOG=y
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/240213002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7976d95c

Handlify and convert Script accesssors to new API-style accessors. · de5f609d

ulan@chromium.org authored Apr 16, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/239223003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

de5f609d

Improve execution time of cctest/test-types. · e05b58f0

bmeurer@chromium.org authored Apr 16, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/239513009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e05b58f0

Fix unused variable warnings. · 5e02daca

yangguo@chromium.org authored Apr 16, 2014

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/238543008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5e02daca

Allow merging of monomorphic accesses to tracked fields. · 42c67d5f

bmeurer@chromium.org authored Apr 16, 2014

Also add stability dependency only on maps that can transition,
and delay adding the dependencies until we are actually using
them, either in a HLoadNamedField or an HCheckMaps.

TEST=mjsunit/field-type-tracking
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/239923004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

42c67d5f

Handlify code allocation. · 17b33fa1

yangguo@chromium.org authored Apr 16, 2014

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/235153003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20795 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

17b33fa1

LazyInstance should be thread safe by default. · 63802cdd

mvstanton@chromium.org authored Apr 16, 2014

The only ways we use this class require it, as multiple isolates can race
to initialize data structures. This showed up as intermittant failures on
nosnap build bots.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/238973004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

63802cdd

Move CopyReplaceDescriptors to private · 9da828a5

verwaest@chromium.org authored Apr 16, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/239203002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9da828a5

Introduce an abstraction to write to a field. · 10714e29

verwaest@chromium.org authored Apr 16, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/236063016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20792 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10714e29

Move property addition code from JSObject to Map · cf26c142

verwaest@chromium.org authored Apr 16, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/238543005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cf26c142

Clear invalid field maps in PropertyAccessInfo. · 63a477b2

bmeurer@chromium.org authored Apr 16, 2014

BUG=363956
TEST=mjsunit/regress/regress-363956
LOG=y
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/239623005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

63a477b2

Protect against API abuse. · 0422c426

svenpanne@chromium.org authored Apr 16, 2014

This makes Chrome's --single-process work again, but the real solution
is to pass an Isolate explicitly and fixing things on the Chrome side
=> follow-up CLs.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/239513006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0422c426