- 30 Aug, 2022 10 commits
-
-
Dominik Inführ authored
Add a flag for disabling FastForwardSchedule() during incremental marking. This CL disables "schedule fast forwarding" by default to experiment with this setup for a few days and to see whether this causes performance regressions. Bug: v8:12775 Change-Id: Id2c0a62f4b67b3a2379816581800cfb62361b40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865003 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82806}
-
Simon Zünd authored
This CL adjusts a DCHECK that verifies a bytecode offset when looking for the closest breakpoint given that offset. When we pause on function entry via interrupt, then the offset is kFunctionEntryBytecodeOffset (-1), which is still a valid offset. R=jarin@chromium.org Fixed: chromium:1357554 Change-Id: I5b25b58f02be0e605191c38e9d1d93e334664c63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862265 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#82805}
-
Frank Tang authored
PR https://github.com/tc39/proposal-temporal/pull/2266 Disallow arbitrary integers for the reference ISO year in PlainMonthDay Spec text: https://tc39.es/proposal-temporal/#sec-temporal-createtemporalmonthday Also add missed assertion of calling ISODateTimeWithinLimits Bug: v8:11544 Change-Id: Idd18428f3e6e6af53c2c207652688af269746782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855703Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82804}
-
ishell@chromium.org authored
This is a reland of commit 40901824 The reason for revert was regressions in `blink_gc:effective_size` buckets of `system_health.memory_desktop` benchmarks. See http://crbug/1356329#c51. Memory Perf Sheriffs: This CL shifts GC times which regresses `blink_gc:effective_size` but improves `v8:effective_size` bucket by a similar amount. The `private_footprint_size` metric stays neutral for the majority of the stories and for certain load stories it even improves. Original change's description: > [ext-code-space] Enable Code-less embedded builtins > > Bug: v8:11880, v8:12592 > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82642} Bug: v8:11880, v8:12592, chromium:1356329, chromium:1356763 Change-Id: Ia9150ecb1f16581e249e4e3e566be20ac4591e78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862503 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82803}
-
Frank Tang authored
Subtract timeZone.[[OffsetNanoseconds]] from epochNanoseconds before calling the IsValidEpochNanoseconds() for the case of 4. If timeZone.[[OffsetNanoseconds]] is not undefined Bug: v8:11544 Change-Id: Icea2d8390a9db01054956f8c57b47dc5a88446d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855980Reviewed-by:
-
Frank Tang authored
Validate fractionalSecondDigits after truncation https://github.com/tc39/proposal-temporal/pull/2297 Spec text: https://tc39.es/proposal-temporal/#sec-temporal-tosecondsstringprecision Bug: v8:11544 Change-Id: I648f087f4fa2cfd6245c7946cfa625a7c5e3b3b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855702 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7e25322..adc338f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2417ba3..6552f9b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b7ec673..bbb66d7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1eff359..ad4caa4 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ife992f3f909a23faa528e8ee1637b1213cc07fa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863152 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82800}
-
Igor Sheludko authored
Bug: v8:13235 Change-Id: Ic6509a74bb808de320734043a42c2da867c150a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858301Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82799}
-
Frank Tang authored
Disallow negative day lengths as round result PR https://github.com/tc39/proposal-temporal/pull/2261 Also fix the missing extraValues=<"day"> to GetTemporalUnit Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.round Bug: v8:11544 Change-Id: Ibc963d5d93dde30f29df707ef3b3ecea99cd4a60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855704Reviewed-by:
-
Frank Tang authored
https://github.com/tc39/proposal-temporal/pull/2225 Call ToTemporalOverflow in ToTemporalDate and ToTemporalDateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-totemporaldate https://tc39.es/proposal-temporal/#sec-temporal-totemporaldatetime Bug: v8:11544 Change-Id: I3d2846e2efc214ea5385be58cb49e319369b5900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855705Reviewed-by:
-
- 29 Aug, 2022 30 commits
-
-
Frank Tang authored
This reverts commit 6b682148. Reason for revert: Cause CHECK violation in https://bugs.chromium.org/p/chromium/issues/detail?id=1356838 Original change's description: > [intl] Return "UTC" instead of "Etc/UTC" or "Etc/GMT" as DefaultTimeZone > > Refactoring the code dealing with TimeZone Canonicalization. > Change CanonicalizeTimeZoneName from return MaybeHandle<String> to Handle<String> > Move TimeZoneId from JSDateTimeFormat to Intl and return Handle<String> instead of Handle<Object> > > > Bug: v8:13112 > Change-Id: I678b0e0d407e5e4e9dd8b7120c0e99e7e2d9c5ea > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3833435 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82505} Bug: v8:13112 Change-Id: If4df4bc19b5d1a02c51e2c944abaca8a25b76a1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863883Reviewed-by:
-
Shu-yu Guo authored
Shared values need to be kept alive while being conveyed across threads (i.e. by postMessage). Currently they are meant to be conveyed through the serializer/deserializer by the embedder via API. This both clunky and the embedder has no good choice for what to do, because the most natural choice is v8::Global and it is not designed to be threadsafe. This CL removes the API and transparently handles conveying shared values by using a wrapper around PersistentHandles called SharedValueConveyors. Any isolate can own the conveyor provided it outlives the receipt of the message by the receiving isolate. For simpler lifetime management, the shared isolate currently owns all conveyors. Bug: v8:12547 Change-Id: I8f71b2faa0f8a1973f8b97ffccf4f5ad230f4e16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857453Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82795}
-
Michael Lippautz authored
- Unify AIX and Starboard wrapping code. - Move all wrapping code into `platform/memory.h` Change-Id: I42c04dd1e982edff2db7bbfa9eecdbdd67f40714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858226Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82794}
-
Milad Fa authored
Port c2d46fe9 Original Commit Message: When a call_indirect fails because of a signature mismatch or a null target, the value stack generated for debug doesn't contain the target index anymore, which makes it hard for users to understand the error. Keep the index on the stack, and ensure that the index is not modified until we generate the debug info. Previously, the index was shifted in-place to compute various offsets. Instead, use scaled loads to compute the offset directly in the load instruction. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I6ab0b5bfcac991f6e26a97bb2513556aa67dcf94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858300Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#82793}
-
Jakob Kummerow authored
The string and view creating instructions string.new*, string.const, string.concat, and string.as_* should all return non-nullable reference types. See https://github.com/WebAssembly/stringref/issues/42 Bug: v8:12868 Change-Id: I2a39aadd339a49b4aa2d145492cba85e6ab14b71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858236 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#82792}
-
Victor Gomes authored
We follow Chromium and only download the image qemu.x64 Change-Id: I13e06c5646e889af2acfac8c8e9cb971a7a36c56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858299 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82791}
-
Milad Fa authored
Port 8a56da44 Original Commit Message: ... so that the offset fits into the maximum offset for load byte instruction for arm/arm64 (Ldrb) in order to produce smaller code. Update code generation so that the loading of the flag value is combined with the comparison operation where possible. Additionally, this CL moves the Isolate::is_profiling flag to the IsolateData so that it can be loaded directly via roots register which removes one indirection. The fields moved in the IsolateData: - is_marking_flag and is_minor_marking_flag (checked by write barriers) - is_profiling (checked on API callbacks/getter calls) - stack_is_iterable (not super hot, checked during deoptimization). the field size expectations clear. R=ishell@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ibafb23e9a035caffe6921a304a3d318b54732167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862227Reviewed-by:
-
Leszek Swirski authored
Accidentally tried to print the colour '-1' if there was no line colour set yet but the current colour had changed. Bug: v8:7700 Change-Id: Iba3cbe51fd0e31e389e614d0a42e59147a51b902 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859355 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82789}
-
Shu-yu Guo authored
Change-Id: I98f9808c139cb0f04efae2d732e9ed60e6d2d78b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3278678 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220812.1.1..version:9.20220826.3.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ae771c8..1eff359 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I653b89dccbef92c384cad109aa7e00df9c96c08d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3860485 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82787}
-
Feng Yu authored
Bug: v8:12781 Change-Id: I19de9ab655e3e4b7ad45cde7f9bc659741d856a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858928Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Feng Yu <f3n67u@gmail.com> Cr-Commit-Position: refs/heads/main@{#82786}
-
Victor Gomes authored
System images are checked-out via the SDK update script, these fixed images are outdated and not used anymore. Change-Id: I4563e04bd252667a01470363f47bbae2ef17d5c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859354Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82785}
-
Victor Gomes authored
Bug: chromium:1357478 Change-Id: I6c412efa9ecc57fd8fbd47a5753c7731558df3b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859353Reviewed-by:
-
Milad Fa authored
Intermittent issues were fixed here: crrev.com/c/3840820 Change-Id: If0e7acc57053ecfa188ca2c858029da7fdf4ff27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859519 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Junliang Yan authored
This is a reland of commit c060af4d Use LoadFullTagged function instead to avoid test failing with v8_enable_verify_csa=true. Original change's description: > Fix CSA_CHECK failure on BE > > The load for external reference should be a full pointer load > instead of tagged size. > > Change-Id: I3460a26abea5053ba6daa5c6ed908cb93431654a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3842348 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/main@{#82625} Change-Id: I85817634ce2de099a9fbd350defb57789cce9678 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857442 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Camillo Bruni authored
Change-Id: I8570c748a9e4e509b0f609fcbb6aa37a3a986971 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862267Reviewed-by:
-
Thibaud Michaud authored
When a call_indirect fails because of a signature mismatch or a null target, the value stack generated for debug doesn't contain the target index anymore, which makes it hard for users to understand the error. Keep the index on the stack, and ensure that the index is not modified until we generate the debug info. Previously, the index was shifted in-place to compute various offsets. Instead, use scaled loads to compute the offset directly in the load instruction. R=clemensb@chromium.org Bug: chromium:1350384 Change-Id: Iad5359ec80deef25a69ac119119a0b5ca559a336 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854309Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#82780}
-
Samuel Groß authored
Bug: chromium:1355990 Change-Id: I1a822ce7b476baf5866070b11b65c464800d3b7b Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859849 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Jakob Linke authored
Bump the limit to give TF enough time to finish compiling. The `keep_going` limit is fairly ugly, but it lets us test the real (=concurrent) pipeline. Bug: v8:7700 Fixed: v8:13176 Change-Id: Iba97111d752c8a4894e99ab57e8f42abcc8c29bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862204 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Samuel Groß authored
This CL adds lightweight checking to the ExternalPointerTable GC algorithm to detect double initialization of external pointer fields. These are forbidden as they interfere with the table compaction algorithm. Bug: v8:10391 Change-Id: Id69fdcce883aa86f8e2c456a0fe7a1f011719464 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858228Reviewed-by:
-
Anton Bikineev authored
Read of size 2 at 0x7eef001a3666 by main thread (mutexes: write M0): 0: LoadEncoded 1: IsMarked<(cppgc::internal::AccessMode)0> 2: operator() 3: DrainWorklistWithPredicate 4: DrainWorklistWithBytesAndTimeDeadline Previous atomic write of size 2 at 0x7eef001a3666 by thread T8: 0: __cxx_atomic_compare_exchange_strong<unsigned short> 1: compare_exchange_strong 2: TryMarkAtomic 3: MarkNoPush Change-Id: I0708516382ea860c877ff76ee02216f6f27c9d04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858239 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Samuel Groß authored
For code pointers, the sandbox will require a custom, lightweight CFI mechanism (likely based on the external pointer table). Simply turning all code pointers into ExternalPointers is not sufficient. This CL therefore turns code pointers back into raw pointers for now so that they don't block the external pointer table rollout. Bug: v8:10391 Change-Id: Ib2ba246be546bbf19fcd0f4ae20f4e9a2cf2e099 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859348Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=jkummerow@chromium.org Bug: v8:12887 Change-Id: Ieccf35730f69bcefa3740227f15e05686080d122 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3843517 Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Jakob Linke authored
This is the normal state on the main branch, let's not emit this warning on every build. Bug: v8:10470 Change-Id: I29744ea7f67881570fa12c249b12f00d2313289c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859851 Commit-Queue: Jakob Linke <jgruber@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Adopt v8.dev page structure and styling - Use v8.dev-style navigation tabs Change-Id: I036be991af57939ea260ab236ddb61875fda86db No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856261 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... so that the offset fits into the maximum offset for load byte instruction for arm/arm64 (Ldrb) in order to produce smaller code. Update code generation so that the loading of the flag value is combined with the comparison operation where possible. Additionally, this CL moves the Isolate::is_profiling flag to the IsolateData so that it can be loaded directly via roots register which removes one indirection. The fields moved in the IsolateData: - is_marking_flag and is_minor_marking_flag (checked by write barriers) - is_profiling (checked on API callbacks/getter calls) - stack_is_iterable (not super hot, checked during deoptimization). Drive-by: this CL defines the bool fields as uint8_t in order to make the field size expectations clear. Bug: v8:11880 Change-Id: I80c292c6ec919861684152b6062225aa0fda2d3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856580Reviewed-by:
-
Camillo authored
This limits the number of DECHECK failures in fuzzing builds that have no side-effects or security implications. Bug: chromium:1355059 Change-Id: I909934c62711439f1edd95492b93ee0c582a495d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859751 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:12191, v8:13231 Change-Id: I0104f54ce5cdc022f22800d4aeec68aac481219d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856573Reviewed-by:
-
Clemens Backes authored
The API was deprecated in v10.6 (https://crrev.com/c/3789510). Remove now, in v10.7. R=mlippautz@chromium.org Bug: v8:12899 Change-Id: I21d79cdd357315daf9684d9cdd6c1f1be088ad6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852490Reviewed-by:
-
Samuel Groß authored
This is a reland of commit eca383c9 More DCHECK failures have been fixed with https://crrev.com/c/3857423 Original change's description: > Reland "[sandbox] Sandboxify EmbedderDataSlots" > > This is a reland of commit e1f585ed > > ExternalPointerTable issues have been fixed in > https://crrev.com/c/3849650 and https://crrev.com/c/3849376 > > Original change's description: > > [sandbox] Sandboxify EmbedderDataSlots > > > > Bug: v8:10391 > > Change-Id: If85a308a6f6ed1b17d86f87b4911c82d2327ea72 > > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757341 > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > Commit-Queue: Samuel Groß <saelo@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#82623} > > Bug: v8:10391 > Change-Id: If77f6c10e81c30c2dfa6b33c788bc4a36e4da135 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852602 > Commit-Queue: Samuel Groß <saelo@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82686} Bug: v8:10391 Change-Id: Id982c022e50004e903851b160d30fc8767280e5b Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854679Reviewed-by:
-
