- 12 Dec, 2016 1 commit
-
-
dgozman authored
This is to improve the performance of common operation of extracting contextId or contextGroupId out of Context. BUG=none Review-Url: https://codereview.chromium.org/2558913004 Cr-Commit-Position: refs/heads/master@{#41657}
-
- 26 Oct, 2016 1 commit
-
-
rob authored
BUG=657568 TEST=Manually, see bug report Review-Url: https://codereview.chromium.org/2432163004 Cr-Commit-Position: refs/heads/master@{#40605}
-
- 20 Oct, 2016 1 commit
-
-
hablich authored
Revert of [inspector] align console implementation with spec (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428473003/ ) Reason for revert: Breaks roll: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164610 See https://chromiumcodereview.appspot.com/2434733002/ for more context Original issue's description: > [inspector] align console implementation with spec > > console should be non enumerable. > > BUG=chromium:656826 > R=dgozman@chromium.org TBR=dgozman@chromium.org,kozyatinskiy@chromium.org NOTRY=true BUG=chromium:656826 Review-Url: https://chromiumcodereview.appspot.com/2435013002 Cr-Commit-Position: refs/heads/master@{#40464}
-
- 19 Oct, 2016 1 commit
-
-
kozyatinskiy authored
console should be non enumerable. BUG=chromium:656826 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428473003 Cr-Commit-Position: refs/heads/master@{#40414}
-
- 14 Oct, 2016 1 commit
-
-
kozyatinskiy authored
Inspected context is created in V8InspectorImpl::contextCreated method and destroyed in V8InspectorImpl::contextDestroyed. Both methods takes valid v8::Local<v8::Context> handle to the same context, it means that context is created before InspectedContext constructor and is always destroyed after InspectedContext destructor therefore context weak callback in inspected context should be never called. It's possible only if inspector client doesn't call contextDestroyed which is considered an error. Therefore CHECK(false) is added into context weak callback to be sure that v8::Context always survives inspected context. BUG=chromium:652548 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2413583002 Cr-Commit-Position: refs/heads/master@{#40290}
-
- 21 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2338413003 Cr-Commit-Position: refs/heads/master@{#39608}
-
- 06 Sep, 2016 1 commit
-
-
dgozman authored
- inspector becomes a dependency of v8_base; - generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>; - added v8_enable_inspector_override to be used in embedders (gn only); - combined public headers into v8-inspector.h and v8-inspector-protocol.h. BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2292053003 Cr-Commit-Position: refs/heads/master@{#39226}
-
- 01 Sep, 2016 1 commit
-
-
dgozman authored
Attempt #2, formatted and disabled lint for src/inspector. BUG=chromium:635948 NOPRESUBMIT=true (for grammar check in license code) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39107}
-
- 31 Aug, 2016 2 commits
-
-
machenbach authored
Revert of [inspector] Initial import of v8_inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2292573002/ ) Reason for revert: Presubmit Original issue's description: > [inspector] Initial import of v8_inspector. > > BUG=chromium:635948 > NOPRESUBMIT=true (for code style) > > Committed: https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee > Cr-Commit-Position: refs/heads/master@{#39057} TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2300823002 Cr-Commit-Position: refs/heads/master@{#39058}
-
dgozman authored
BUG=chromium:635948 NOPRESUBMIT=true (for code style) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39057}
-