1. 19 Feb, 2020 1 commit
  2. 29 Nov, 2019 3 commits
    • Sigurd Schneider's avatar
      Reland "[exceptions] Don't re-request interrupt in InvokeWithTryCatch" · b9df6e1c
      Sigurd Schneider authored
      This is a reland of 4ed9d48f
      
      CompileRun leads to undefined behavior if the compile fails;
      CompileRunChecked can be used to assert that the compile must
      succeed. I've removed the attempt to compile and rely on a
      simpler check in the tests now.
      
      Original change's description:
      > [exceptions] Don't re-request interrupt in InvokeWithTryCatch
      >
      > This CL changes InvokeWithTryCatch to not re-request the terminate
      > execution interrupt, but instead schedule the termination exception.
      > This ensures that leaving the outermost TryCatch scope will clear
      > the exception, and no interrupt remains.
      >
      > Previously, the interrupt request could remain and prevent further
      > JavaScript execution even after the TryCatch scope was left.
      >
      > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
      > Bug: chromium:1014415
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65255}
      
      Tbr: yangguo@chromium.org, verwaest@chromium.org
      Bug: chromium:1014415
      Change-Id: I29444c4b7ea5a158865f54d4608f374914f7b133
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943151Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65258}
      b9df6e1c
    • Leszek Swirski's avatar
      Revert "[exceptions] Don't re-request interrupt in InvokeWithTryCatch" · 48367856
      Leszek Swirski authored
      This reverts commit 4ed9d48f.
      
      Reason for revert: UBSan failure https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/9084
      
      Original change's description:
      > [exceptions] Don't re-request interrupt in InvokeWithTryCatch
      > 
      > This CL changes InvokeWithTryCatch to not re-request the terminate
      > execution interrupt, but instead schedule the termination exception.
      > This ensures that leaving the outermost TryCatch scope will clear
      > the exception, and no interrupt remains.
      > 
      > Previously, the interrupt request could remain and prevent further
      > JavaScript execution even after the TryCatch scope was left.
      > 
      > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
      > Bug: chromium:1014415
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
      > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65255}
      
      TBR=yangguo@chromium.org,sigurds@chromium.org,verwaest@chromium.org
      
      Change-Id: Iedefe5320d8bdc442a87e03698a20daf6a0ebf4f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1014415
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943149Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65256}
      48367856
    • Sigurd Schneider's avatar
      [exceptions] Don't re-request interrupt in InvokeWithTryCatch · 4ed9d48f
      Sigurd Schneider authored
      This CL changes InvokeWithTryCatch to not re-request the terminate
      execution interrupt, but instead schedule the termination exception.
      This ensures that leaving the outermost TryCatch scope will clear
      the exception, and no interrupt remains.
      
      Previously, the interrupt request could remain and prevent further
      JavaScript execution even after the TryCatch scope was left.
      
      Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
      Bug: chromium:1014415
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65255}
      4ed9d48f
  3. 30 Jul, 2019 1 commit
  4. 26 Jun, 2019 1 commit
  5. 24 May, 2019 1 commit
  6. 23 May, 2019 1 commit
  7. 22 May, 2019 1 commit
  8. 17 May, 2019 1 commit
  9. 16 May, 2019 2 commits
  10. 12 Mar, 2019 1 commit
  11. 31 Jan, 2019 1 commit
  12. 23 Jan, 2019 1 commit
  13. 30 Nov, 2018 1 commit
    • Yang Guo's avatar
      Make termination exception more consistent. · 7e5cac2c
      Yang Guo authored
      Termination exceptions tear down V8 to the bottom-most V8 call. If there is a
      v8::TryCatch scope around that call, it returns true for HasTerminated() and
      HasCaught(). However, Isolate::IsExecutionTerminating() returns false and we
      can call into V8 from still inside the v8::TryCatch scope.
      
      Changes that this patch introduces:
       - You need to leave the v8::TryCatch scope around the bottom-most call to
         reset the termination state, in order to resume.
       - Explicitly check for termination exception and reporting it through the
         DevTools protocol after Runtime.evaluate and Debugger.evaluateOnCallFrame.
      
      Bug: v8:8455
      Change-Id: I1f36f7a365985469813c2619bf16f18ee69aa4b8
      Reviewed-on: https://chromium-review.googlesource.com/c/1337582Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57963}
      7e5cac2c
  14. 29 Nov, 2018 1 commit
    • tzik's avatar
      Deprecate v8::Isolate::GetEnteredContext · 29ad898c
      tzik authored
      This CL marks v8::Isolate::GetEnteredContext as deprecated in favor of
      replacing it with GetEnteredOrMicrotaskContext. Blink no longer uses it,
      and Node.js does not use this too.
      
      GetEnteredOrMicrotaskContext() is relevant for all known cases over
      GetEnteredContext(), and it costs 2% of a benchmark score to maintain
      the entered contexts under the nestable microtask context.
      https://crrev.com/c/1322290 is a context for the bencmark and nestable
      microtask contexts.
      
      Bug: v8:8124
      Change-Id: I260e32daadf34dc587926a1e20ab950ff2e31699
      Reviewed-on: https://chromium-review.googlesource.com/c/1353025
      Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57927}
      29ad898c
  15. 17 Sep, 2018 1 commit
  16. 23 Jul, 2018 1 commit
  17. 26 Apr, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      Reland "[inspector] added timeout for Debugger.evaluateOnCallFrame method" · c1e4885f
      Alexey Kozyatinskiy authored
      This is a reland of 436faae0
      
      Original change's description:
      > [inspector] added timeout for Debugger.evaluateOnCallFrame method
      > 
      > R=dgozman@chromium.org,yangguo@chromium.org
      > 
      > Bug: none
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5
      > Reviewed-on: https://chromium-review.googlesource.com/1023035
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52798}
      
      Bug: none
      Change-Id: I91219382b5dc45b54dd8e5c64d9f0d11c849b9c8
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/1030510
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52818}
      c1e4885f
  18. 25 Apr, 2018 1 commit
  19. 23 Apr, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      [runtime] implemented SafeForInterruptsScope · d3f6c647
      Alexey Kozyatinskiy authored
      This CL introduced SafeForInterruptsScope. This scope overrides
      outer PostponeInterruptsScopes:
      - reschedule postponed interrupts if needed,
      - allow requesting new interrupts.
      As soon as scope removed interrupts are posponed if needed.
      
      This scope will be:
      - used to allow inspector to interrupt and terminate
        DebugeEvaluate::Local,
      - exposed with new flag on Isolate to implement SafeForTerminationScope
        in blink.
      
      R=yangguo@chromium.org
      
      Bug: chromium:820640
      Change-Id: I15befc10c2cee393d1e3be48cecb31ee14dae638
      Reviewed-on: https://chromium-review.googlesource.com/1022969
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52743}
      d3f6c647
  20. 19 Mar, 2018 1 commit
  21. 26 Feb, 2018 1 commit
  22. 22 Feb, 2018 1 commit
  23. 19 Dec, 2017 1 commit
  24. 13 Oct, 2017 1 commit
  25. 31 Aug, 2017 1 commit
  26. 17 Jan, 2017 1 commit
  27. 09 Jan, 2017 1 commit
  28. 01 Sep, 2016 1 commit
  29. 20 Jul, 2016 2 commits
  30. 19 Jul, 2016 1 commit
  31. 07 Jun, 2016 1 commit
  32. 04 Mar, 2016 3 commits
  33. 09 Dec, 2015 1 commit
  34. 23 Oct, 2015 1 commit