1. 27 Oct, 2020 1 commit
    • Mike Stanton's avatar
      [TurboFan] Provide concurrent access to feedback vector · 2288b1f6
      Mike Stanton authored
      This CL provides synchronized get/set to feedback vector slots.
      The FeedbackNexus is set up to use order preserving reads when used
      on the background thread, and a lock to ensure coherent read
      of information for ICKinds with two slots. The main thread takes
      the lock on sets.
      
      This test provides patterns to be followed by concurrent TurboFan.
      
      We don't yet access the FeedbackVector on the background thread.
      This CL only makes it safe to do so. The next step will come when
      the optimizing compiler begins to query the the vector from the
      background thread. Currently, with --concurrent-inlining turned on
      this is done in bytecode serialization on the main thread. Without
      concurrent inlining, it's also done on the main thread, in both
      cases using the FeedbackNexus.
      
      Bug: v8:7790
      Change-Id: I49d8b8031190f91a0da1c24f375b6b6d8a9fe038
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276210
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
      Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70797}
      2288b1f6
  2. 09 Oct, 2020 1 commit
    • Mythri A's avatar
      [handles] Fix is_identical_to to correctly work with Smis · 1f858b3f
      Mythri A authored
      HandleBase::is_identical_to() is_identical_to in handle base is used to
      do the exact comparison by just comparing the locations. When the
      locations are different the values are compared. For Smis it
      compares 64 bits which might lead to incorrect behaviour. Smis loaded as
      a TaggedField has the root address added. It is expexted that we don't
      use higher order bits on Smi. Hence, is_identical_to shouldn't use these
      bits when comparing Smis. This cl fixes it by comparing the objects
      created from the given location. That takes care of correctly comparing
      the required bits.
      
      Change-Id: I574dfbea4c1fffc7a9e3a6a10ad7631d40c518ce
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461743
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70422}
      1f858b3f
  3. 18 Mar, 2020 1 commit
  4. 04 Mar, 2020 1 commit
  5. 24 May, 2019 1 commit
  6. 23 May, 2019 1 commit
  7. 26 Dec, 2018 1 commit
  8. 17 Dec, 2018 1 commit
  9. 14 Dec, 2018 1 commit
  10. 25 Nov, 2018 1 commit
  11. 13 Nov, 2018 1 commit
  12. 06 Nov, 2018 1 commit
  13. 05 Nov, 2018 1 commit
  14. 26 Oct, 2018 1 commit
  15. 14 Sep, 2018 1 commit
  16. 23 Jul, 2018 1 commit