- 08 Jan, 2019 1 commit
-
-
Toon Verwaest authored
This is a reland of part of https://chromium-review.googlesource.com/c/v8/v8/+/1397664. It drops the explicit fni_.Infer() call after parsing arrow functions. We'll want to avoid inferring if the arrow function is an argument to a function call. It also avoids adding the single argument of "name => " to the inferred name. Bug: chromium:916975 Change-Id: I96a934408113483d73eba14073fe21e8cfe2ada6 Reviewed-on: https://chromium-review.googlesource.com/c/1397665 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58613}
-
- 21 Dec, 2018 1 commit
-
-
Maya Lekova authored
This reverts commit 3411e7c3. Reason for revert: Breaks test expecations - https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/260731 Original change's description: > [parser] Create arrow function scopes while parsing the head > > This simplifies NextArrowFunctionInfo, allows us to Scope::Snapshot::Reparent > directly rather than moving it, and allows us to skip reparenting in the simple > parameter arrow function cases. > > This CL additionally fixes arrow function name inferring. > > Change-Id: Ie3e5ea778f3d7b84b2a10d4f4ff73931cfc9384a > Reviewed-on: https://chromium-review.googlesource.com/c/1386147 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58405} TBR=ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8f31b96f844f0673364bf435fa6c809e40d62fa3 Reviewed-on: https://chromium-review.googlesource.com/c/1388541Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58446}
-
- 20 Dec, 2018 1 commit
-
-
Toon Verwaest authored
This simplifies NextArrowFunctionInfo, allows us to Scope::Snapshot::Reparent directly rather than moving it, and allows us to skip reparenting in the simple parameter arrow function cases. This CL additionally fixes arrow function name inferring. Change-Id: Ie3e5ea778f3d7b84b2a10d4f4ff73931cfc9384a Reviewed-on: https://chromium-review.googlesource.com/c/1386147Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58405}
-
- 30 Apr, 2018 1 commit
-
-
Andreas Haas authored
assertPromiseResult caused tests to timeout when the result of the promise was unexpected, e.g. rejected instead of the expected fulfillment. This CL cleans up the implementation of assertPromiseResult, adds better stack traces, and adds tests for all the important cases I can think of. R=mathias@chromium.org CC=clemensh@chromium.org Bug: v8:7570 Change-Id: I6ecb94fd3e5151502edf73c3bcdeb518b80fc81c Reviewed-on: https://chromium-review.googlesource.com/1032786 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#52882}
-