- 13 Jan, 2017 1 commit
-
-
zhengxing.li authored
The CL #42279 (https://codereview.chromium.org/2619353006 ) caused a gcc error (-Werror=strict-overflow). Here is the error message: In file included from .././src/globals.h:15:0, from .././src/allocation.h:9, from .././src/profiler/profile-generator.h:9, from ../src/profiler/profile-generator.cc:5: .././src/base/logging.h: In member function ‘void v8::internal::ProfileTree::TraverseDepthFirst(Callback*) [with Callback = v8::internal::DeleteNodesCallback]’: .././src/base/logging.h:179:70: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Werror=strict-overflow] : MakeCheckOpString<Lhs, Rhs>(lhs, rhs, msg); \ ^ .././src/base/logging.h:191:1: note: in expansion of macro ‘DEFINE_CHECK_OP_IMPL’ DEFINE_CHECK_OP_IMPL(GT, > ) ^ CXX(target) /home/zxli/work/google-v8/v8/out/x87.optdebug/obj.target/v8_base/src/regexp/regexp-macro-assembler.o cc1plus: all warnings being treated as errors This CL fix it. BUG= Review-Url: https://codereview.chromium.org/2632633002 Cr-Commit-Position: refs/heads/master@{#42318}
-
- 12 Jan, 2017 1 commit
-
-
clemensh authored
Wasm frames can be either compiled or interpreted. For interpreted wasm frames, there is only one physical stack frame representing an arbitrary stack of interpreted functions. Hence the physical stack frame needs to provide a summary of the underlying functions. Summaries were tailored for JavaScript frames before. Now they are universal. The refactored FrameSummaries are now also used in the FrameInspector, and from the StackFrame objects themselves, to avoid code duplication. All dispatch is implemented "manually", making the FrameSummary still stack-allocatable. BUG=v8:5822 R=yangguo@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2619353006 Cr-Commit-Position: refs/heads/master@{#42279}
-
- 11 Jan, 2017 1 commit
-
-
rmcilroy authored
This CL modifies the ast-numbering phase to collect function literals which should be compiled eagerly. This is then used to eagerly compile the inner functions before compiling the outer function. This will be used to queue compilation jobs on the CompilerDispatcher in a later CL. This CL moves the compilation of eager inner functions out of the GetSharedFunctionInfo function and instead compiles them explicitly. This simplifies GetSharedFunctionInfo and also means there is no need to pass a LazyCompilationMode to the function, so this concept has been removed. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2618553004 Cr-Commit-Position: refs/heads/master@{#42221}
-
- 06 Oct, 2016 1 commit
-
-
heimbuef authored
because ownership over it is not obviously clear and leads to errors. Review-Url: https://codereview.chromium.org/2366283003 Cr-Commit-Position: refs/heads/master@{#40024}
-
- 26 Jan, 2016 1 commit
-
-
jarin authored
This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map. The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1636013002 Cr-Commit-Position: refs/heads/master@{#33521}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 12 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1289553002 Cr-Commit-Position: refs/heads/master@{#30126}
-
- 15 Jul, 2015 1 commit
-
-
epertoso authored
R=jochen@chromium.org LOG=y BUG= Review URL: https://codereview.chromium.org/1209403005 Cr-Commit-Position: refs/heads/master@{#29680}
-
- 25 Jun, 2015 1 commit
-
-
erikcorry authored
Previous code review https://codereview.chromium.org/1182783009/ R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1204123003 Cr-Commit-Position: refs/heads/master@{#29290}
-
- 24 Jun, 2015 2 commits
-
-
machenbach authored
Revert of Extend big-disjunction optimization to case-independent regexps (patchset #5 id:80001 of https://codereview.chromium.org/1182783009/) Reason for revert: [Sheriff] Test times out now on msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2947 Original issue's description: > Extend big-disjunction optimization to case-independent regexps > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/d2135603bcf462e15a1284d8ed969f6692610dda > Cr-Commit-Position: refs/heads/master@{#29264} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1204013003 Cr-Commit-Position: refs/heads/master@{#29266}
-
erikcorry authored
R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1182783009 Cr-Commit-Position: refs/heads/master@{#29264}
-
- 10 Jun, 2015 1 commit
-
-
erikcorry authored
This change rewrites regexps like (ab|ac|z|ad|ae|af) into (a[b-f]|z). We can only reorder disjunctions like this for case-dependent regexps. For case-independent regexps, the disjunctions should be pre-sorted for best results. R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1180433003 Cr-Commit-Position: refs/heads/master@{#28902}
-
- 09 Jun, 2015 4 commits
-
-
erikcorry authored
Revert of Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 (patchset #2 id:20001 of https://codereview.chromium.org/1174713002/) Reason for revert: Tree looks like a Christmas tree and this isn't helping Original issue's description: > Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 > > Original code review: https://codereview.chromium.org/1176453002/ > > TBR=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/85fab0fa092e8d979413f6a61baec3abe26e568d > Cr-Commit-Position: refs/heads/master@{#28884} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1172893002 Cr-Commit-Position: refs/heads/master@{#28885}
-
erikcorry authored
Original code review: https://codereview.chromium.org/1176453002/ TBR=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1174713002 Cr-Commit-Position: refs/heads/master@{#28884}
-
erikcorry authored
Revert of Optimize trivial regexp disjunctions (patchset #10 id:180001 of https://codereview.chromium.org/1176453002/) Reason for revert: ASAN failure Original issue's description: > Optimize trivial regexp disjunctions > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/5f1f7c15b3207f6c51d187692690aeb09d3e36b5 > Cr-Commit-Position: refs/heads/master@{#28871} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1174603002 Cr-Commit-Position: refs/heads/master@{#28878}
-
erikcorry authored
R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1176453002 Cr-Commit-Position: refs/heads/master@{#28871}
-
- 12 Jan, 2015 1 commit
-
-
jochen authored
All builders that used level 1 should meanwhile define v8_enable_slow_dchecks, and so they can use level 2 without losing coverage. Level 2, however, is considerably faster, so we want to use it on those builders as well. The make optdebug setting is not affected by this change. BUG=none R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/847753002 Cr-Commit-Position: refs/heads/master@{#26019}
-
- 15 Oct, 2014 1 commit
-
-
yangguo@chromium.org authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/653033002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 2 commits
-
-
marja@chromium.org authored
- Missing includes / forward declaration - Parser: Simplifying calling error reporting funcs. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/307393002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21652 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Feb, 2014 1 commit
-
-
danno@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/157443002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jan, 2014 1 commit
-
-
rossberg@chromium.org authored
Clean up some zone/isolate handling in AST and its visitors on the way. (Based on https://codereview.chromium.org/103743004/) R=jkummerow@chromium.org, titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/102563004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jan, 2014 1 commit
-
-
rossberg@chromium.org authored
The only thing different now is line types.h:208/236, which had a static_cast<Type*> before. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/133683002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18533 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Jan, 2014 3 commits
-
-
machenbach@chromium.org authored
This reverts commit r18521 and r18522 for breaking mac and win builders. BUG= TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/132493002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18524 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/132263002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18522 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
This is to support both heap- and zone-allocated types in the future (the latter not yet implemented). Also, handlify the type API some more. R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/107933005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18521 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Dec, 2013 1 commit
-
-
yurys@chromium.org authored
The class added unecessary level of indirection to the heap profiler implementation. I merged some of its implementation into HeapProfiler and deleted the rest. This refactoring is also a prerequisite for keeping HeapObjectsMap alive even when all snapshots are deleted. BUG=None LOG=N R=alph@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/101393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Nov, 2013 1 commit
-
-
verwaest@chromium.org authored
R=rossberg@chromium.org Review URL: https://chromiumcodereview.appspot.com/75413002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Oct, 2013 1 commit
-
-
danno@chromium.org authored
Thereby ensuring there is only a minimal performance regression vs. NDEBUG (now it's only about 10% slower rather than ~2x). R=jkummerow@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/39183004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Sep, 2013 2 commits
-
-
dcarney@chromium.org authored
This reverts 16467 for breaking windows build TBR=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/23824005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/23479015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 May, 2013 1 commit
-
-
verwaest@chromium.org authored
InsertAt apparently inserts by moving the other elements... that does not work. Review URL: https://chromiumcodereview.appspot.com/14566007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jan, 2013 1 commit
-
-
yangguo@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/11880018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Dec, 2012 1 commit
-
-
yangguo@chromium.org authored
R=ulan@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11678006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13279 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Dec, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:2340 Review URL: https://chromiumcodereview.appspot.com/11377158 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Jun, 2012 1 commit
-
-
sanjoy@chromium.org authored
BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10556038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Jun, 2012 1 commit
-
-
sanjoy@chromium.org authored
This CL changes some parts of the code to explicitly pass around a Zone. Not passing in a zone is okay too (in fact most of v8 still doesn't), but that may incur a TLS lookup. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10443114 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-