- 09 Apr, 2018 11 commits
-
-
jgruber authored
Builtins::IsOffHeapSafe is unused now that embedded builtins are shipped in the snapshot. A longer explanation: there used to be a difference between IsOffHeapSafe and IsIsolateIndependent back at an earlier stage when we still copied off-heap-safe builtins off the heap on isolate startup. At that point, off-heap builtins didn't need to be isolate-independent, e.g. they could still contain embedded external references. Now that embedded builtins are shipped in the snapshot, this distinction is no longer needed. Bug: v8:6666 Change-Id: I0be6120b94b01480262f472f0904ea9037941e2a Reviewed-on: https://chromium-review.googlesource.com/1002652Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52473}
-
Michael Achenbach authored
NOTRY=true NOTREECHECKS=true TBR=sergiyb@chromium.org Bug: v8:7339 Change-Id: Ie408680f3185f58cd023dcfdb14565e49c28ad0c Reviewed-on: https://chromium-review.googlesource.com/1002559Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52472}
-
Kim-Anh Tran authored
The prologue checks if optimized code exists, and if not, continues execution of the current function. Otherwise, it jumps to the address specified in the native module's code_table. Also-by: clemensh@chromium.org Change-Id: If3e76de02115f44ab7758590a949c3f0965a11ca Reviewed-on: https://chromium-review.googlesource.com/985837 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52471}
-
Peter Marshall authored
We hardcoded this accidentally in the original CL for the turbofan case, instead we need to call JSConstructStubGeneric() which will return the correct construct stub based on the harmony_restrict_constructor_return flag. Bug: chromium:829899 Change-Id: I6776a5daebd57d8881d926ad68595141312a877d Reviewed-on: https://chromium-review.googlesource.com/1001893Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52470}
-
Simon Zünd authored
Also removes the JS constructor. R=jgruber@chromium.org Bug: v8:7624 Change-Id: I33493ab2fafb35f95fb1822d46d3f249568c0a56 Reviewed-on: https://chromium-review.googlesource.com/999534 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52469}
-
Andreas Haas authored
R=titzer@chromium.org Bug: v8:7581 Change-Id: Ib100a45ad51ec6b6a0400cfe97fe918089c04ead Reviewed-on: https://chromium-review.googlesource.com/998095 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52468}
-
Vlad Tsyrklevich authored
Replace direct calls to generated code with calls using GeneratedCode to match the rest of v8. BUG=v8:7164 Change-Id: I5d90bcb6e90d99e105be18886d4844b83f611b95 Reviewed-on: https://chromium-review.googlesource.com/1000416Reviewed-by:
-
jgruber authored
Remaining tests also lead to OOM, skip all of them on tsan stress modes. Bug: v8:7626 Change-Id: Ie2c128b9a718c7c34c974e628ba60e5549ea04fc Reviewed-on: https://chromium-review.googlesource.com/1002552 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Currently a WeakMap key edge shows up as '<id> / WeakMap'. This patch changes it to '<id> / key <KeyName> in WeakMap'. Bug: chromium:827713 Change-Id: I0306bacdc331ab69739be88cf29d16a21187625f Reviewed-on: https://chromium-review.googlesource.com/992035Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52465}
-
Michael Achenbach authored
Bug: chromium:653569 Change-Id: I2fa288d3281c75d3e5d483fb94d29efe454c633b Reviewed-on: https://chromium-review.googlesource.com/1000773Reviewed-by:
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: Ia3b6221cdc54c5102760665076f1cb2541d16fb4 Reviewed-on: https://chromium-review.googlesource.com/999634Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
- 08 Apr, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/30e8660..6ae4520 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5361d68..1e3e74d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5055341de21a09bc3dd221b52b8d655221b0c654 Reviewed-on: https://chromium-review.googlesource.com/1001652Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52462}
-
- 07 Apr, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d1cd744..30e8660 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aaeb23e..5361d68 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cd83d95..d7c36b0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2f99649c97e5e83616822d442c60bcbd1ca9e9b9 Reviewed-on: https://chromium-review.googlesource.com/1000489Reviewed-by:
-
- 06 Apr, 2018 27 commits
-
-
Daniel Clifford authored
Currently these new functions are unused and untested, but will be used once Torque is checked in. They are split off into this separate CL to ease rollback of Torque if required. Change-Id: If2b96f342011592ae7cd88a4f6d9a4f2acc3643e Reviewed-on: https://chromium-review.googlesource.com/998171 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52460}
-
Eric Holk authored
Bug: v8:5277 Change-Id: I47ad0b7dbd9471e350b7aa1b6dd5ad122b97021a Reviewed-on: https://chromium-review.googlesource.com/990239Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52459}
-
Myles Borins authored
A DCHECK in TimeTicks::HighResolutionNow was replaced with a warning to stop systems from crashing. This warning broke parts of the Node.js test-suite on certain systems. The warning has been replaced with a comment documenting this situation and a TODO to ensure we don't lose track of this code path. Bug: v8:7617 Bug: chromium:809016 Change-Id: I5e3af8c31817291d264af861514f34e3e1af9af2 Reviewed-on: https://chromium-review.googlesource.com/997153Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Myles Borins <mborins@google.com> Cr-Commit-Position: refs/heads/master@{#52458}
-
Clemens Hammacher authored
Replace all uses with V8_WARN_UNUSED_RESULT. WARN_UNUSED_RESULT was defined in src/base/compiler-specific.h, which includes include/v8config.h, which already defined V8_WARN_UNUSED_RESULT. R=mstarzinger@chromium.org Bug: v8:7570 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I662072294605036ca5aa0c8fdaa0218ac5d95f23 Reviewed-on: https://chromium-review.googlesource.com/998893Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=hablich@chromium.org Bug: v8:7632 Change-Id: I42e6b3f3585c8a98750ac39de06934174f2a2fa4 Reviewed-on: https://chromium-review.googlesource.com/999417Reviewed-by:
-
Daniel Clifford authored
Change-Id: If2a207d97b16bd74c2fd75e2ad9be1ecc921f492 Reviewed-on: https://chromium-review.googlesource.com/998169Reviewed-by:
-
Leszek Swirski authored
Merge the outer_scope_info and feedback_metadata fields on SharedFunctionInfo. outer_scope_info is only used during parsing, and feedback_metadata is only available after compilation, so the two never exist at the same time. Thus, they can share a field slot. The exception is un-compiling and re-compiling a function, where we need the outer_scope_info again. Fortunately, the outer_scope_info can be re-calculated from the SFI's scope_info. Bug: v8:7606 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6b97fefe859e89df75ad870da4a0bfa4b869772a Reviewed-on: https://chromium-review.googlesource.com/992432Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52454}
-
jgruber authored
Bug: v8:7626 Change-Id: Ifd6908941b7bc62357c3577bea4a097c45903129 Reviewed-on: https://chromium-review.googlesource.com/998167Reviewed-by:
-
Alexey Kozyatinskiy authored
This is a reland of 0340874b Original change's description: > [debug] add runtime side effect check for StaCurrentContextSlot > > R=yangguo@chromium.org > > Bug: v8:7588 > Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c > Reviewed-on: https://chromium-review.googlesource.com/996236 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52398} Bug: v8:7588 Change-Id: Ife6b039ea3291103a54ae04c3007fe4610371c3f Reviewed-on: https://chromium-review.googlesource.com/998801Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52452}
-
Clemens Hammacher authored
The maximum number of background tasks to spawn can be computed right in the constructor of the CompilationState, and is constant afterwards. Additionally, we ensure to never start more background tasks than the number of available compilation units. R=ahaas@chromium.org Change-Id: I430e9a28a0bd15166ed05d120782f182d10c3e44 Reviewed-on: https://chromium-review.googlesource.com/997652 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=mstarzinger@chromium.org Bug: v8:7424 Change-Id: I5a854d334957c285eebe850024c25d1cdcf71f7f Reviewed-on: https://chromium-review.googlesource.com/995772 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port b158bfdc Original Commit Message: This is a reland of 63ecddc8 Original change's description: > [runtime] Remove the construct_stub field of the SFI > > Don't dispatch based on the construct_stub field anymore. Rather than > read it out and jump to the construct stub, we can switch on the > builtin_id. > > Builtins will always have builtin_id as a Smi, so this signals we need > to jump to JSBuiltinsConstructStub. The only exception is for uncompiled > functions, which will have kCompileLazy as the builtin_id, but need to > jump to the generic stub instead. > > API function calls will have a FunctionTemplateInfo in the SFI > function_data field, and need to go to the builtins stub as well. > > The final case is everything else, which should go to the generic stub. > > Bug: v8:7503 > Change-Id: I14790a5f9784dc0d940bf10a05f5310026e1d482 > Reviewed-on: https://chromium-review.googlesource.com/980941 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52345} R=petermarshall@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I53d92ea7326c5a0ffec25eef0972cdeb659848b6 Reviewed-on: https://chromium-review.googlesource.com/998018Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
-
Igor Sheludko authored
1) Add exit point parameter to EmitGenericPropertyStore(), 2) carve TryLookupPropertyInSimpleObject() out of TryLookupProperty(). Bug: v8:5988 Change-Id: I6cef48731c27e5bb72dce5eaa0169fbf59787ed7 Reviewed-on: https://chromium-review.googlesource.com/997747Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52448}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/647f86b..d1cd744 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/3748a2a..10d701f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b1c9ad5..aaeb23e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/82ac1c9..cd83d95 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6e4745827cc54412062558c1f7272fc56143518 Reviewed-on: https://chromium-review.googlesource.com/999329 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in favor of SelectConstant(). Bug: chromium:829679 Change-Id: Ic7cc887254b4f6b29339b06c5782d71f77d3c9a5 Reviewed-on: https://chromium-review.googlesource.com/999601Reviewed-by:
-
Clemens Hammacher authored
If --wasm-num-compilation-tasks is set to 0, we spawn all background tasks as foreground tasks. Semantically, they are still treated like background tasks, but they will execute interleaved with the foreground tasks. This should not deadlong since all foreground tasks eventually return to the event loop. R=ahaas@chromium.org Bug: chromium:829681 Change-Id: Id57cbb10157c085acd57a3d30a0a43c824a64591 Reviewed-on: https://chromium-review.googlesource.com/999594Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Change-Id: I45a6b7ef7b185c0bc05185672383c682b6e1e798 Reviewed-on: https://chromium-review.googlesource.com/998153 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Change-Id: Icbba06aefb728ebc7e2f04fa9992d51e0589a33b Reviewed-on: https://chromium-review.googlesource.com/999596Reviewed-by:
-
Igor Sheludko authored
Given that we got a store transition handler for free (because it's just a transition map) there's no need to wait for a second "use" of that transition in order to install a normal store transition handler. Bug: v8:5988 Change-Id: Iecdcfdd096a8efffdd0662f1b1d604943e57d85a Reviewed-on: https://chromium-review.googlesource.com/997553Reviewed-by:
-
Peter Marshall authored
Also changed the order of params so that context comes first to be more consistent with other CSA helpers. Change-Id: Ibf602dc7f3a148bed7fc0f93cc3dbc714febd786 Reviewed-on: https://chromium-review.googlesource.com/999513Reviewed-by:
-
Michael Achenbach authored
This reverts commit f8ae62fe. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/14825 Original change's description: > [heap] Move initial objects into RO_SPACE > > This moves: > * the main oddballs (null, undefined, hole, true, false) as well as > their supporting maps (also adds hole as an internalized string to make > this work). > * most of the internalized strings > * the struct maps > * empty array > * empty enum cache > * the contents of the initial string table > * the weak_cell_cache for any map in RO_SPACE (and eagerly creates the > value avoid writing to it during run-time) > > The StartupSerializer stats change as follows: > > RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE > old 0 0 270264 32608 12144 0 > new 21776 0 253168 32608 8184 0 > Overall memory usage has increased by 720 bytes due to the eager > initialization of the Map weak cell caches. > > Also extends --serialization-statistics to print out separate instance > type stats for objects in RO_SPACE as shown here: > > Read Only Instance types (count and bytes): > 404 16736 ONE_BYTE_INTERNALIZED_STRING_TYPE > 2 32 HEAP_NUMBER_TYPE > 5 240 ODDBALL_TYPE > 45 3960 MAP_TYPE > 1 16 BYTE_ARRAY_TYPE > 1 24 TUPLE2_TYPE > 1 16 FIXED_ARRAY_TYPE > 1 32 DESCRIPTOR_ARRAY_TYPE > 45 720 WEAK_CELL_TYPE > > Bug: v8:7464 > Change-Id: I12981c39c82a7057f68bbbe03f89fb57b0b4c6a6 > Reviewed-on: https://chromium-review.googlesource.com/973722 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52435} TBR=rmcilroy@chromium.org,yangguo@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,delphick@chromium.org Change-Id: Ie62a73a5be3b21a15bb46e342acb3e808fbaa4f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/999653Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=clemensh@chromium.org Change-Id: Ifc171886d122ca19230a3099cf14f13a4bfcabb1 Reviewed-on: https://chromium-review.googlesource.com/999515Reviewed-by:
-
Clemens Hammacher authored
Test that Managed objects get collected if they are not referenced any more. R=ulan@chromium.org Bug: v8:7628 Change-Id: I4a594ebe835071d76d7a6e2ddee6a6092b3e4a31 Reviewed-on: https://chromium-review.googlesource.com/999482Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: chromium:829681 Change-Id: Iccf9b190e77b1c27fedec74d67f5948803dd1fa9 Reviewed-on: https://chromium-review.googlesource.com/998355Reviewed-by:
-
Ben L. Titzer authored
This change makes lifetime management of WasmCode much simpler. By using the WasmInstanceObject as the context for WASM code execution, including the pointer to the memory base and indirect function tables, this keeps the instance alive when WASM code is on the stack, since the instance object is passed as a parameter and spilled onto the stack. This is in preparation of sharing the code between instances and isolates. Bug: v8:7424 R=mstarzinger@chromium.org Change-Id: Ia35a3ce91a8f6135767fa764e185cde8bbc889f4 Reviewed-on: https://chromium-review.googlesource.com/997932 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Dan Elphick authored
This moves: * the main oddballs (null, undefined, hole, true, false) as well as their supporting maps (also adds hole as an internalized string to make this work). * most of the internalized strings * the struct maps * empty array * empty enum cache * the contents of the initial string table * the weak_cell_cache for any map in RO_SPACE (and eagerly creates the value avoid writing to it during run-time) The StartupSerializer stats change as follows: RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE old 0 0 270264 32608 12144 0 new 21776 0 253168 32608 8184 0 Overall memory usage has increased by 720 bytes due to the eager initialization of the Map weak cell caches. Also extends --serialization-statistics to print out separate instance type stats for objects in RO_SPACE as shown here: Read Only Instance types (count and bytes): 404 16736 ONE_BYTE_INTERNALIZED_STRING_TYPE 2 32 HEAP_NUMBER_TYPE 5 240 ODDBALL_TYPE 45 3960 MAP_TYPE 1 16 BYTE_ARRAY_TYPE 1 24 TUPLE2_TYPE 1 16 FIXED_ARRAY_TYPE 1 32 DESCRIPTOR_ARRAY_TYPE 45 720 WEAK_CELL_TYPE Bug: v8:7464 Change-Id: I12981c39c82a7057f68bbbe03f89fb57b0b4c6a6 Reviewed-on: https://chromium-review.googlesource.com/973722 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:829774 Change-Id: I85ea46a68f620dfd7db04e881b6363ef260392f7 Reviewed-on: https://chromium-review.googlesource.com/999490Reviewed-by:
-
