- 05 May, 2015 1 commit
-
-
danno authored
By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. Review URL: https://codereview.chromium.org/1053143005 Cr-Commit-Position: refs/heads/master@{#28215}
-
- 30 Apr, 2015 1 commit
-
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for the binary + operator. Test suite is also cleaned up/refactored to allow easier testing of the comparison operators in the future. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1109223004 Cr-Commit-Position: refs/heads/master@{#28159}
-
- 28 Apr, 2015 1 commit
-
-
conradw authored
See https://codereview.chromium.org/1092353002/ Due to parser rewrites, also implements restrictions for unary ~. Still to come, implementing restrictions for binary + and comparison. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1102923002 Cr-Commit-Position: refs/heads/master@{#28104}
-
- 27 Apr, 2015 2 commits
-
-
dcarney authored
R=verwaest@chromium.org BUG=468620 LOG=N Review URL: https://codereview.chromium.org/1102543002 Cr-Commit-Position: refs/heads/master@{#28081}
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1107843002 Cr-Commit-Position: refs/heads/master@{#28060}
-
- 24 Apr, 2015 2 commits
-
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for binary arithmetic operations, not including the + special case. Adds some infrastructure for future implementation of the restrictions for other operators. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1092353002 Cr-Commit-Position: refs/heads/master@{#28045}
-
jochen authored
Revert of Reland "Remove the weak list of views from array buffers" (patchset #2 id:20001 of https://codereview.chromium.org/1093183004/) Reason for revert: still working on perf Original issue's description: > Reland "Remove the weak list of views from array buffers" > > Original description: > > Instead, views have to check their array buffer for whether > > it's neutered or not. > > > > BUG=v8:3996 > > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f > Cr-Commit-Position: refs/heads/master@{#28029} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1053203007 Cr-Commit-Position: refs/heads/master@{#28038}
-
- 23 Apr, 2015 1 commit
-
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1093183004 Cr-Commit-Position: refs/heads/master@{#28029}
-
- 21 Apr, 2015 2 commits
-
-
machenbach authored
Revert of track global accesses to constant types (patchset #15 id:280001 of https://codereview.chromium.org/1062163005/) Reason for revert: [Sheriff] Speculative revert for maybe breaking layout tests, e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2589 Will reland if it doesn't help. Original issue's description: > track global accesses to constant types > > BUG= TBR=verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1094313003 Cr-Commit-Position: refs/heads/master@{#27982}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1062163005 Cr-Commit-Position: refs/heads/master@{#27966}
-
- 15 Apr, 2015 1 commit
-
-
mvstanton authored
This needs "Pass load ic state through the Oracle" (https://codereview.chromium.org/1083933002/) to land first. BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/1083083002 Cr-Commit-Position: refs/heads/master@{#27827}
-
- 13 Apr, 2015 2 commits
-
-
machenbach authored
Revert of VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (patchset #3 id:40001 of https://codereview.chromium.org/1067573003/) Reason for revert: [Sheriff] Speculative revert for windows failure... will reland if it doesn't help: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%202/builds/2891 Original issue's description: > VectorICs: megamorphic keyed loads in crankshaft don't need a vector. > > They are content with a dummy vector, as MISSES won't result in > changing the real vector/slot at all. > > BUG= > > Committed: https://crrev.com/c8e4d57d3b3036a05902f5b916cb5d853a57393c > Cr-Commit-Position: refs/heads/master@{#27788} TBR=dcarney@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1060263003 Cr-Commit-Position: refs/heads/master@{#27790}
-
mvstanton authored
They are content with a dummy vector, as MISSES won't result in changing the real vector/slot at all. BUG= Review URL: https://codereview.chromium.org/1067573003 Cr-Commit-Position: refs/heads/master@{#27788}
-
- 30 Mar, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1034393002 Cr-Commit-Position: refs/heads/master@{#27519}
-
- 18 Mar, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/962613002 Cr-Commit-Position: refs/heads/master@{#27271}
-
- 17 Mar, 2015 2 commits
-
-
dcarney authored
additionally, remove unnecessary deopts when transitioning to global accessor properties from data properties R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/996133002 Cr-Commit-Position: refs/heads/master@{#27239}
-
mvstanton authored
A hydrogen code stub is not the best approach because it builds a frame and doesn't have the technology to discard roots at tail call exits. Platform-specific stubs provide much better performance at this point. R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/988653003 Cr-Commit-Position: refs/heads/master@{#27235}
-
- 13 Mar, 2015 2 commits
-
-
dslomov authored
We have been shipping harmony scoping for 2 Chrome releases now (M41 and M42). Time to remove the flag. R=rossberg@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1007783002 Cr-Commit-Position: refs/heads/master@{#27187}
-
dslomov authored
StoreIC::Store was missing a check present in LoadIC::Load. R=rossberg@chromium.org BUG=v8:3941 LOG=Y Review URL: https://codereview.chromium.org/1001323002 Cr-Commit-Position: refs/heads/master@{#27182}
-
- 10 Mar, 2015 1 commit
-
-
dcarney authored
the implementation doesn't yet throw on strict mode assignment BUG= Review URL: https://codereview.chromium.org/992913002 Cr-Commit-Position: refs/heads/master@{#27121}
-
- 09 Mar, 2015 1 commit
-
-
Jaroslav Sevcik authored
BUG=chromium:460937 R=ishell@chromium.org LOG=n Review URL: https://codereview.chromium.org/989093002 Cr-Commit-Position: refs/heads/master@{#27064}
-
- 05 Mar, 2015 1 commit
-
-
rossberg authored
R=dslomov@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/976053002 Cr-Commit-Position: refs/heads/master@{#27014}
-
- 04 Mar, 2015 1 commit
-
-
mvstanton authored
Until this is addressed, we can simply use the regular IC, as we do in times of serialization. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/974853002 Cr-Commit-Position: refs/heads/master@{#26977}
-
- 02 Mar, 2015 1 commit
-
-
Toon Verwaest authored
BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/969733003 Cr-Commit-Position: refs/heads/master@{#26941}
-
- 26 Feb, 2015 2 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/942963004 Cr-Commit-Position: refs/heads/master@{#26874}
-
jarin authored
Bad scenario: - Enter a binop IC miss handler from optimized code object C from call site S, - From the binop IC, invoke arbitrary javascript that lazy deopts C, so all relocation info is nuked and replaced with lazy deopt entries' reloc info. In particular, there is no reloc info for S. - Still from the arbitrary JavaScript, make IC target's code object move. Note that the call site S is not updated. - Return to the miss handler and inspect the IC's target. This will try to get the target from S, but that is a potentially invalid pointer. It is quite possible that we will have to do a similar fix for other ICs, but we will have to find a reliable repro first. I am not submitting a repro here because it is quite long running and brittle (it relies on code compaction happening while in the binop IC). BUG=v8:3910 LOG=n R=ishell@chromium.org Review URL: https://codereview.chromium.org/958473004 Cr-Commit-Position: refs/heads/master@{#26872}
-
- 25 Feb, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/945313003 Cr-Commit-Position: refs/heads/master@{#26862}
-
- 23 Feb, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/892383003 Cr-Commit-Position: refs/heads/master@{#26796}
-
- 19 Feb, 2015 1 commit
-
-
ulan authored
BUG=chromium:454619 LOG=NO Review URL: https://codereview.chromium.org/926293004 Cr-Commit-Position: refs/heads/master@{#26748}
-
- 17 Feb, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/935603002 Cr-Commit-Position: refs/heads/master@{#26696}
-
- 11 Feb, 2015 4 commits
-
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:3834 LOG=N Committed: https://crrev.com/8aed43e82c6d2742fe5988603cb8841324cc942b Cr-Commit-Position: refs/heads/master@{#26560} Review URL: https://codereview.chromium.org/908883002 Cr-Commit-Position: refs/heads/master@{#26572}
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/911713003 Cr-Commit-Position: refs/heads/master@{#26569}
-
dslomov authored
Revert of new classes: implement new.target passing to superclass constructor. (patchset #9 id:150001 of https://codereview.chromium.org/908883002/) Reason for revert: Breaks Linux64 release Original issue's description: > new classes: implement new.target passing to superclass constructor. > > R=arv@chromium.org,rossberg@chromium.org > BUG=v8:3834 > LOG=N > > Committed: https://crrev.com/8aed43e82c6d2742fe5988603cb8841324cc942b > Cr-Commit-Position: refs/heads/master@{#26560} TBR=arv@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3834 Review URL: https://codereview.chromium.org/911363002 Cr-Commit-Position: refs/heads/master@{#26561}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:3834 LOG=N Review URL: https://codereview.chromium.org/908883002 Cr-Commit-Position: refs/heads/master@{#26560}
-
- 09 Feb, 2015 2 commits
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/906463002 Cr-Commit-Position: refs/heads/master@{#26522}
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/904423002 Cr-Commit-Position: refs/heads/master@{#26518}
-
- 05 Feb, 2015 3 commits
-
-
dslomov authored
R=rossberg@chromium.org BUG=chromium:452510 LOG=Y Review URL: https://codereview.chromium.org/893993007 Cr-Commit-Position: refs/heads/master@{#26466}
-
mvstanton authored
Looking up and passing this argument is unnecessary. R=ulan@chromium.org Review URL: https://codereview.chromium.org/898013003 Cr-Commit-Position: refs/heads/master@{#26464}
-
Benedikt Meurer authored
This reverts commit f578d35b because (immutable) heap numbers are surprisingly mutable in V8. Someone else might want to cleanup the mess, otherwise we'll just keep it this way. TBR=jkummerow@chromium.org BUG=chromium:454894 LOG=y Review URL: https://codereview.chromium.org/898973003 Cr-Commit-Position: refs/heads/master@{#26447}
-
- 04 Feb, 2015 1 commit
-
-
mvstanton authored
The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. R=ulan@chromium.org Review URL: https://codereview.chromium.org/866493003 Cr-Commit-Position: refs/heads/master@{#26420}
-