- 31 Jul, 2015 1 commit
-
-
bmeurer authored
This is the initial (big) step towards a more uniform implementation of the ToObject abstract operation (ES6 7.1.13), where we have a fallback implementation in JSReceiver::ToObject() and a fast (hydrogen) CodeStub to deal with the fast case (we should be able to do more cleanup on this in a followup CL). For natives we expose the abstract operation via a %_ToObject intrinsic, also exposed via a macro TO_OBJECT, that unifies the previous confusion with TO_OBJECT_INLINE, ToObject, TO_OBJECT, $toObject and %$toObject. Now the whole implementation of the abstract operation is context independent, meaning we don't need any magic in the builtins object nor the native context. R=mvstanton@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1266013006 Cr-Commit-Position: refs/heads/master@{#29953}
-
- 08 Jul, 2015 1 commit
-
-
littledan authored
The breakage to Chrome seems to be based on @@isConcatSpreadable and turning that part off with this patch fixes the Maps Tips & Tricks test case. BUG=chromium:507553 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1226063002 Cr-Commit-Position: refs/heads/master@{#29545}
-
- 11 Jun, 2015 2 commits
-
-
dehrenberg authored
%AddElement is not intended for objects which are not arrays, and its behavior may go away with future refactorings. This patch gets rid of it if the receiver of from or of is not the intrinsic Array object. Array.of and Array.from previously papered over failures in calling [[DefineOwnProperty]] when setting array elements. This patch makes them lead to exceptions, and adds tests to assert that the appropriate exceptions are thrown. BUG=v8:4168 R=adamk CC=rossberg,verwaest LOG=Y Review URL: https://codereview.chromium.org/1181623003 Cr-Commit-Position: refs/heads/master@{#28969}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1172683003 Cr-Commit-Position: refs/heads/master@{#28946}
-
- 05 Jun, 2015 1 commit
-
-
arv authored
We should not skip holes for these 2 functions. BUG=v8:3895 LOG=N R=adamk Review URL: https://codereview.chromium.org/1165003005 Cr-Commit-Position: refs/heads/master@{#28814}
-
- 26 May, 2015 1 commit
-
-
yangguo authored
Revert of Revert of Hook up more import/exports in natives. (patchset #1 id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} TBR=jkummerow@chromium.org,erik.corry@gmail.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}
-
- 22 May, 2015 4 commits
-
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154743003 Cr-Commit-Position: refs/heads/master@{#28584}
-
yangguo authored
R=jkummerow@chromium.org Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 Cr-Commit-Position: refs/heads/master@{#28573} Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28578}
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #2 id:20001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6943 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154793003 Cr-Commit-Position: refs/heads/master@{#28574}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28573}
-
- 21 May, 2015 1 commit
-
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521} Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28533}
-
- 20 May, 2015 2 commits
-
-
jkummerow authored
Revert of Use shared container to manage imports/exports. (patchset #2 id:20001 of https://codereview.chromium.org/1143993003/) Reason for revert: Breaks nosnap bots Original issue's description: > Use shared container to manage imports/exports. > > Also changed string.js and math.js to adapt this change. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd > Cr-Commit-Position: refs/heads/master@{#28521} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1144163002 Cr-Commit-Position: refs/heads/master@{#28523}
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28521}
-
- 18 May, 2015 1 commit
-
-
dehrenberg authored
This function creates a new way to make TypedArrays based on existing iterable or Array-like objects, analogous to Array.from. The patch implements the function and adds tests. R=arv@chromium.org BUG=v8:3578 LOG=Y Review URL: https://codereview.chromium.org/1132163011 Cr-Commit-Position: refs/heads/master@{#28456}
-
- 13 May, 2015 1 commit
-
-
dehrenberg authored
This patch adds three methods to TypedArrays which are already implemented for arrays. The implementations are made by calling out to the underlying code used by Arrays. R=adamk@chromium.org BUG=v8:3578 LOG=Y Review URL: https://codereview.chromium.org/1136663005 Cr-Commit-Position: refs/heads/master@{#28382}
-
- 12 May, 2015 4 commits
-
-
dehrenberg authored
This patch adds the copyWithin method to TypedArrays. For the first pass, the internals of Array.copyWithin are used. Eventually, a more efficient form based on memcpy could be used instead. BUG=v8:3578 LOG=Y R=adamk@chromium.org, arv@chromium.org, caitpotter88@gmail.com Review URL: https://codereview.chromium.org/1131113002 Cr-Commit-Position: refs/heads/master@{#28381}
-
yangguo authored
Review URL: https://codereview.chromium.org/1138173002 Cr-Commit-Position: refs/heads/master@{#28367}
-
yangguo authored
Revert of Use function wrapper argument to expose internal arrays to native scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1127983003/) Reason for revert: custom snapshot builder failing. Original issue's description: > Use function wrapper argument to expose internal arrays to native scripts. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/a9b5a1795449d94387218d25baed2c2b3c4fbadc > Cr-Commit-Position: refs/heads/master@{#28354} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1123353008 Cr-Commit-Position: refs/heads/master@{#28355}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1127983003 Cr-Commit-Position: refs/heads/master@{#28354}
-
- 11 May, 2015 1 commit
-
-
yangguo authored
For the moment, we only pass the global object (the one we are setting up). A few smaller changes were necessary to avoid failures in test-object-observe/DontLeakContextOnObserve. Otherwise the global object would be retained by being context allocated, leading to test failure. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1132513003 Cr-Commit-Position: refs/heads/master@{#28331}
-
- 07 May, 2015 1 commit
-
-
yangguo authored
Revert of Revert of Wrap runtime.js in a function. (patchset #1 id:1 of https://codereview.chromium.org/1123353004/) Reason for revert: Failing test has been fixed. Original issue's description: > Revert of Wrap runtime.js in a function. (patchset #2 id:20001 of https://codereview.chromium.org/1126213002/) > > Reason for revert: > [Sheriff] Breaks nosnap: > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2872 > > Original issue's description: > > Wrap runtime.js in a function. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 > > Cr-Commit-Position: refs/heads/master@{#28275} > > TBR=jkummerow@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/62bd294f909ff448d0f876a3d745966a24cdc3f7 > Cr-Commit-Position: refs/heads/master@{#28277} TBR=jkummerow@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1131843002 Cr-Commit-Position: refs/heads/master@{#28287}
-
- 06 May, 2015 3 commits
-
-
machenbach authored
Revert of Wrap runtime.js in a function. (patchset #2 id:20001 of https://codereview.chromium.org/1126213002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2872 Original issue's description: > Wrap runtime.js in a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 > Cr-Commit-Position: refs/heads/master@{#28275} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1123353004 Cr-Commit-Position: refs/heads/master@{#28277}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1126213002 Cr-Commit-Position: refs/heads/master@{#28275}
-
verwaest authored
Review URL: https://codereview.chromium.org/1116003005 Cr-Commit-Position: refs/heads/master@{#28255}
-
- 05 May, 2015 2 commits
-
-
yangguo authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1127693006 Cr-Commit-Position: refs/heads/master@{#28217}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1122033002 Cr-Commit-Position: refs/heads/master@{#28216}
-
- 04 May, 2015 2 commits
-
-
machenbach authored
Revert of Reland "Wrap v8natives.js into a function." (patchset #2 id:20001 of https://codereview.chromium.org/1123703002/) Reason for revert: [Sheriff] Speculative revert for braking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314 (reverted already titzer's CL which didn't help) Original issue's description: > Reland "Wrap v8natives.js into a function." > > Committed: https://crrev.com/72ab42172979b60a1b784ea0c6a495d7ee2bba67 > Cr-Commit-Position: refs/heads/master@{#28193} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1127543003 Cr-Commit-Position: refs/heads/master@{#28208}
-
yangguo authored
Review URL: https://codereview.chromium.org/1123703002 Cr-Commit-Position: refs/heads/master@{#28193}
-
- 30 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Wrap v8natives.js into a function. (patchset #2 id:20001 of https://codereview.chromium.org/1109343004/) Reason for revert: [Sheriff] Speculative revert for breaking layout tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2682 See. e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/3130/layout-test-results/http/tests/websocket/workers/worker-reload-diff.txt Original issue's description: > Wrap v8natives.js into a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a > Cr-Commit-Position: refs/heads/master@{#28174} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1121453003 Cr-Commit-Position: refs/heads/master@{#28182}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1109343004 Cr-Commit-Position: refs/heads/master@{#28174}
-
- 24 Apr, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1096243003 Cr-Commit-Position: refs/heads/master@{#28040}
-
- 22 Apr, 2015 1 commit
-
-
machenbach authored
Revert of Revert of [es6] implement Array.prototype.copyWithin() (patchset #1 id:1 of https://codereview.chromium.org/1084183004/) Reason for revert: Check if this CL fails independently of https://chromium.googlesource.com/v8/v8/+/580d66bcda66220d2f3062ac58daf925436df74c Original issue's description: > Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/376623004/) > > Reason for revert: > [Sheriff] This causes test failures on mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 > > Original issue's description: > > [es6] implement Array.prototype.copyWithin() > > > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > > > BUG=v8:4039 > > R=adamk@chromium.org > > LOG=N > > TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4039 > > Committed: https://crrev.com/9283fc89710e59445bdc4479454fba97ab9ebdd7 > Cr-Commit-Position: refs/heads/master@{#27984} TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Review URL: https://codereview.chromium.org/1072193005 Cr-Commit-Position: refs/heads/master@{#27997}
-
- 21 Apr, 2015 3 commits
-
-
machenbach authored
Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/376623004/) Reason for revert: [Sheriff] This causes test failures on mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 Original issue's description: > [es6] implement Array.prototype.copyWithin() > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > BUG=v8:4039 > R=adamk@chromium.org > LOG=N TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Review URL: https://codereview.chromium.org/1084183004 Cr-Commit-Position: refs/heads/master@{#27984}
-
caitpotter88 authored
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin BUG=v8:4039 R=adamk@chromium.org LOG=N Review URL: https://codereview.chromium.org/376623004 Cr-Commit-Position: refs/heads/master@{#27983}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1100673002 Cr-Commit-Position: refs/heads/master@{#27955}
-
- 17 Apr, 2015 1 commit
-
-
yangguo authored
Review URL: https://codereview.chromium.org/1083083004 Cr-Commit-Position: refs/heads/master@{#27907}
-
- 16 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Migrate error messages, part 2. (patchset #1 id:1 of https://codereview.chromium.org/1086313003/) Reason for revert: [Sheriff]: This changes layout test expectations e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2964 Original issue's description: > Migrate error messages, part 2. > > Motivation for this is reducing the size of the native context. > > Committed: https://crrev.com/d3b788df0a4ccfedbe6e1df5e214cb6ba2792a65 > Cr-Commit-Position: refs/heads/master@{#27878} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1095573002 Cr-Commit-Position: refs/heads/master@{#27889}
-
yangguo authored
Motivation for this is reducing the size of the native context. Review URL: https://codereview.chromium.org/1086313003 Cr-Commit-Position: refs/heads/master@{#27878}
-
- 10 Apr, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1065863003 Cr-Commit-Position: refs/heads/master@{#27760}
-
- 13 Mar, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1009443002 Cr-Commit-Position: refs/heads/master@{#27185}
-