- 24 May, 2018 12 commits
-
-
Simon Zünd authored
R=petermarshall@chromium.org Change-Id: Id27cae79dcd82b6dd7790736169c76e89ae8881d Reviewed-on: https://chromium-review.googlesource.com/1071428 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53332}
-
Simon Zünd authored
R=tebbi@chromium.org Change-Id: Id524c8239f99fc26ac5cd19cbdea39dba62f2c3f Reviewed-on: https://chromium-review.googlesource.com/1071650Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#53331}
-
Peter Marshall authored
We store deopt inline frames for all functions when we receive the code creation event. We only ever use this information for code which is deoptimized. Given that we receive code deopt events, we can just store this information when the code is deoptimized. At the time of the code deopt event, we also know the associated deopt_id. That means we don't need to store a map of deopt_ids to vectors of frames, because we will only ever access the frames for the deopt_id that is already set. This means we store way less data, particularly for long-running processes which see fewer deopts. This saves 10MiB peak memory on the node server example. Bug: v8:7719 Change-Id: If6cf5ec413848e4c9f3c1e2106366ae2adae6fb1 Reviewed-on: https://chromium-review.googlesource.com/1050289 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53330}
-
Peter Marshall authored
This distinction doesn't matter, they aren't treated any differently to other strings. Change-Id: I524a0a1c4089284af97aa507afc5bd5985fe6631 Reviewed-on: https://chromium-review.googlesource.com/1071628Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53329}
-
Marja Hölttä authored
Moving them away was a mistake. Fixing this enables getting rid of a bunch of includes. BUG=v8:5402 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5482eab4281c7450350f058fe0a04a6f375ea082 Reviewed-on: https://chromium-review.googlesource.com/1070188Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53328}
-
Jaroslav Sevcik authored
Currently, we context allocate all parameters for generators. With this CL, we keep arguments on stack (unless they escape to inner closure) and copy them between the stack and the generator's register file on suspend/resume. This will save context allocation in most cases. Note: There is an asymmetry between suspend and resume. - Suspend copies arguments and registers to the generator. - Resume copies only the registers from the generator, the arguments are copied by the ResumeGenerator trampoline. Bug: v8:5164 Change-Id: I6333898c60abf461b1ab1b5c6d3dc7188fa95649 Reviewed-on: https://chromium-review.googlesource.com/1063712 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53327}
-
Dan Elphick authored
Removes uses of HeapObject::GetIsolate()/GetHeap() from VerifyPointersVisitor by adding it to the visitor at construction time. Bug: v8:7786 Change-Id: I28388f2eadbaf9947eafe0c62492c9a4781be250 Reviewed-on: https://chromium-review.googlesource.com/1071575Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53325}
-
Stephan Herhut authored
This adds basic support to emit wasm disassembly to the json files digested by turbolizer. Change-Id: Icd8fc92e9539dc336879ef6da76e31890b95e40e Reviewed-on: https://chromium-review.googlesource.com/1069275 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53323}
-
Simon Zünd authored
This CL uses the new function pointers and generic features of Torque to improve the performance of TypedArray.p.sort. Instead of one Load/Store builtin that dispatches at runtime based on the element kind, there are now many small builtins (one for each element kind). The sorting algorithm then uses function pointers to those small builtins, which get set once. Changes in the relevant benchmarks: Benchmark Original (JS) Current This CL IntTypes 83.9 202.3 240.7 BigIntTypes 32.1 47.2 53.3 FloatTypes 99.3 109.3 129.3 Bug: v8:7382 Change-Id: I8684410524d546615b19f6edcbfdc615068196aa Reviewed-on: https://chromium-review.googlesource.com/1070069 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7754 Change-Id: Ifa329efa1ccbae3d4cf6251f43b11b697ddf76f8 Reviewed-on: https://chromium-review.googlesource.com/1068678 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Instead use the canonical empty fixed array. Some code assumes that this is the only fixed array of length 0. Bug: chromium:843062 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If780acf50147c061a81f2ff2b31779fbd1c78559 Reviewed-on: https://chromium-review.googlesource.com/1064052Reviewed-by:
-
Michael Lippautz authored
Bug: v8:7760 Change-Id: I5589b873845d614a4751b12319c61c91aae04a84 Reviewed-on: https://chromium-review.googlesource.com/1070829Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#53318}
-
- 23 May, 2018 16 commits
-
-
Aseem Garg authored
R=gdeepti@chromium.org,bbudge@chromium.org,clemensh@chromium.org,titzer@chromium.org BUG=v8:6020 Change-Id: I671d74b49206a3612764c7b9cb63591e7e81e857 Reviewed-on: https://chromium-review.googlesource.com/1069933 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53316}
-
Alexei Filippov authored
The patch makes it manage a free list of released code_entries_ slots, and reuse the slots as needed. BUG=v8:7719 Change-Id: I07df1ce983fe00e0ca3d1a1ea20e1a141aabad99 Reviewed-on: https://chromium-review.googlesource.com/1062769Reviewed-by:
-
Alexei Filippov authored
BUG=chromium:844150 Change-Id: I0f7e10fb9778b3de76591ad4819be45c8c50c8d4 Reviewed-on: https://chromium-review.googlesource.com/1064815Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53313}
-
Théotime Grohens authored
This CL adds a baseline Torque implementation of the DataView getters and setters. Right now, the Torque code just calls the C++ implementation, which has moved to runtime. Change-Id: Ic96fde7ea908c628af9586e84511037c237c4d3b Reviewed-on: https://chromium-review.googlesource.com/1061520Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53312}
-
Marja Hölttä authored
Since the StubCache it's cleared at the end of the GC, it doesn't matter if it contains weak or strong pointers. BUG=v8:7308 Change-Id: Ib141e3d411523c67ccb8f8979845a88488d6e4ee Reviewed-on: https://chromium-review.googlesource.com/1064053 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: v8:7760 Change-Id: I975b467e46bed684e141c2a78a396de1072125f1 Reviewed-on: https://chromium-review.googlesource.com/1068894Reviewed-by:
-
Simon Zünd authored
This CL replaces the default ConsoleErrorListener with a custom one. The only difference is that the error message now also includes the file name where the lexer/parser error happened. R=tebbi@chromium.org Change-Id: Ifa22501a55066b82b32234c76df180db41ee8b62 Reviewed-on: https://chromium-review.googlesource.com/1069137 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Simon Zünd authored
This CL stops torque from crashing when a function pointer call site uses wrong parameters. R=tebbi@chromium.org Change-Id: If097d0882ca5370e525097c68014f7ec051b3fe8 Reviewed-on: https://chromium-review.googlesource.com/1068181Reviewed-by:
-
Camillo Bruni authored
This reverts commit 05bcb12e. Reason for revert: Causes isolate startup regressions (https://crbug.com/845508) Original change's description: > Flush ICache on startup deserialization after marking memory executable > > Tentative fix for Android invoke crashers with write protection code > enabled. > > Bug: chromium:842862 > Change-Id: If238b25b239b50c597f3745aa683f564a717434f > Reviewed-on: https://chromium-review.googlesource.com/1061513 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53209} TBR=mstarzinger@chromium.org,cbruni@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:842862, chromium:845508, chromium:845877 Change-Id: Iff002e1ac75aca48c696053dddf1b413f372629e Reviewed-on: https://chromium-review.googlesource.com/1068048 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This is based on https://chromium-review.googlesource.com/c/v8/v8/+/940174. It is fine to use the more complex addressing modes here because our poisoning does not poison indexes anymore (it poisons value instead). Bug: chromium:839789 Change-Id: I818a060f835f7dea842cb855d077e871a95b2c01 Reviewed-on: https://chromium-review.googlesource.com/1065773 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: I1b4568123a8ad55804266c40b988b39362ba7aa4 Reviewed-on: https://chromium-review.googlesource.com/1070157Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I04c21ed1919f9bc9c68312c15d1e1229aaba32b5 Reviewed-on: https://chromium-review.googlesource.com/1061013Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Starzinger authored
By now we no longer call {CodeStub} targets directly from WebAssembly code and hence can remove support for serializing and deserializing such call sites. R=clemensh@chromium.org Change-Id: Ibfea9fce178d49f4e739a049a6767031da3c9569 Reviewed-on: https://chromium-review.googlesource.com/1066013 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53299}
-
Peter Marshall authored
The current profiling mode (called kLeafNodeLineNumbers in this CL) produces a tree, with each node representing a stack frame that is seen in one or more samples taken during profiling. These nodes refer to a particular function in a stack trace, but not to a particular line or callsite within that function. This CL adds a new more (called kCallerLineNumbers) which produces a different profile tree, where each stack trace seen during profiling, including the line number, has a unique path in the tree. The profile tree was previously keyed on CodeEntry*. Now it is keyed on the pair of CodeEntry* and line_number, meaning it has distinct nodes for those combinations which exist, and each distinct stack trace that was sampled is represented in the tree. For optimized code where we have inline frames, there are no line numbers for the inline frames in the stack trace, causing duplicate branches in the tree with kNoLineNumberInfo as the reported line number. This will be addressed in follow-ups. Bug: v8:7018 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I512e221508f5b50ec028306d212263b514a9fb24 Reviewed-on: https://chromium-review.googlesource.com/1013493 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53298}
-
Marja Hölttä authored
Previous version: https://chromium-review.googlesource.com/1049606 This version is exactly the same as the previous; a bugfix ( https://chromium-review.googlesource.com/c/v8/v8/+/1069127 ) makes relanding possible. BUG=v8:7308 TBR=ishell@chromium.org, tebbi@chromium.org, leszeks@chromium.org, ulan@chromium.org Change-Id: If7d455ceb6af0505a44b4fc52c52143e51cd115a Reviewed-on: https://chromium-review.googlesource.com/1070027Reviewed-by:
-
Mathias Bynens authored
The TC39 committee reached consensus to rename `flatten` to `flat` during the May 22nd meeting. The corresponding patch to the proposal is here: https://github.com/tc39/proposal-flatMap/commit/093eacc7fe0906e70f7626bf6c7d6e9dfc53cce9 Bug: v8:7220 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie8049ae4d4589a4ae7fe3d203053cef798c135e4 Reviewed-on: https://chromium-review.googlesource.com/1069467Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53294}
-
- 22 May, 2018 12 commits
-
-
Tobias Tebbi authored
Change-Id: Ie61c8fa51c7c13ab74c4c97ed6803be7f879a549 Reviewed-on: https://chromium-review.googlesource.com/1069088 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Change-Id: I80dd313ac3a5809d363adff9cf11ac31b04648dd Reviewed-on: https://chromium-review.googlesource.com/1068876 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I97cdf61a15c2141d3c552a792ac08c9865f272ff Reviewed-on: https://chromium-review.googlesource.com/1066307 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53291}
-
Junliang Yan authored
Port 813094ac Original Commit Message: This is not web compatible, so let's delete the code. R=gsathya@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I8cbe561b176c25900d4e40eb8912e5c0b4c44410 Reviewed-on: https://chromium-review.googlesource.com/1069170Reviewed-by:
-
Hannes Payer authored
Replaces the anchor page circular doubly linked list with a doubly linked list pointing to nullptr on its ends. Fixes a memory leak when rewinding pages. The large pages list will move to the new list implementation in a follow-up CL. Change-Id: I2933a5e222d4ca768f4b555c47ed0d7a7027aa73 Reviewed-on: https://chromium-review.googlesource.com/1060973 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Marja Hölttä authored
If it points to a new space object which doesn't get scavenged, we need to drop the reference. BUG=v8:7308, v8:7768 Change-Id: I4485a7abcac3a26781811cc9bf134fd80e5f35b5 Reviewed-on: https://chromium-review.googlesource.com/1069127 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Change-Id: I488b47a51ef79c97545576fcc7d58e9147deb664 Reviewed-on: https://chromium-review.googlesource.com/1067677Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#53285}
-
Simon Zünd authored
This CL adds grammar support for function pointers to generic builtins. It also instantiates generic specializations when they are only used in an assignment to a function pointer. Example: builtin GenericBuiltinTest<T: type>(c: Context, param: T): Object { return Null; } let fnptr: builtin(Context, Smi) => Object = GenericBuiltinTest<Smi>; Change-Id: Ib7e5f47ffc05f14eb5d0b789936587263dfb961d Reviewed-on: https://chromium-review.googlesource.com/1068731 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by: -
Tobias Tebbi authored
We already had to introduce TypeAlias to allow types to be const. With TypeAlias, there is no need for types to be declarable themselves. Change-Id: Ia718482f6c121b5316aca819368e6d048283e5e8 Reviewed-on: https://chromium-review.googlesource.com/1068734 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
The wrappers for imports are not accessible through the code() accessor, so avoid tracing them for now. BUG=chromium:844745 R=ahaas@chromium.org Change-Id: I63fe447091ba3c202e3ffcfddfa645049a0b83cf Reviewed-on: https://chromium-review.googlesource.com/1068739 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ic1c4a10a251a8243fc337dc149eb057a29cace2b Reviewed-on: https://chromium-review.googlesource.com/1065670 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Peter Marshall authored
This map is often quite small and holds small items (ints) so wastes quite a bit of overhead in the backing tree representation. This CL changes the std::map to a sorted vector of pairs. This reduces the size significantly (2.13 MiB -> 598 KiB on the node server example). Bug: v8:7719 Change-Id: Ic829693f007732ae145fae02850a1ed913cd941e Reviewed-on: https://chromium-review.googlesource.com/1064233 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
