1. 24 Oct, 2018 1 commit
  2. 12 Oct, 2018 1 commit
  3. 03 Jul, 2018 1 commit
  4. 27 Jun, 2018 4 commits
    • Dominik Inführ's avatar
      Reland "Reland "[heap] Visit individual ephemerons instead of collections"" · 5cb08217
      Dominik Inführ authored
      This is a reland of 91f113e2
      
      Original change's description:
      > Reland "[heap] Visit individual ephemerons instead of collections"
      > 
      > This is a reland of 9aba0159
      > 
      > Original change's description:
      > > [heap] Visit individual ephemerons instead of collections
      > > 
      > > When marking ephemerons visit individual ephemerons with key and value
      > > unreachable instead of simply iterating all ephemerons in all weak
      > > collections. Also visit ephemerons at end of concurrent marking to do
      > > work we would otherwise need to do in the atomic pause.
      > > 
      > > Bug: chromium:844008
      > > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7
      > > Reviewed-on: https://chromium-review.googlesource.com/1113934
      > > Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#54039}
      > 
      > Bug: chromium:844008
      > Change-Id: I4c44e74c7cf5fe380ffa4ce9f106bebb57bc023d
      > Reviewed-on: https://chromium-review.googlesource.com/1116438
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      > Cr-Commit-Position: refs/heads/master@{#54046}
      
      Bug: chromium:844008
      Change-Id: Ie9d606c51aacdfa9ffe77fe4cf780e30dd445d52
      Reviewed-on: https://chromium-review.googlesource.com/1116639Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      Cr-Commit-Position: refs/heads/master@{#54053}
      5cb08217
    • Dominik Inführ's avatar
      Revert "Reland "[heap] Visit individual ephemerons instead of collections"" · 265d5c24
      Dominik Inführ authored
      This reverts commit 91f113e2.
      
      Reason for revert: still causes breakage on Chromium-integrated builds, failing here:
      
        CHECK_EQ(0, heap()->local_embedder_heap_tracer()->NumberOfWrappersToTrace());
      
      Original change's description:
      > Reland "[heap] Visit individual ephemerons instead of collections"
      >
      > This is a reland of 9aba0159
      >
      > Original change's description:
      > > [heap] Visit individual ephemerons instead of collections
      > >
      > > When marking ephemerons visit individual ephemerons with key and value
      > > unreachable instead of simply iterating all ephemerons in all weak
      > > collections. Also visit ephemerons at end of concurrent marking to do
      > > work we would otherwise need to do in the atomic pause.
      > >
      > > Bug: chromium:844008
      > > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7
      > > Reviewed-on: https://chromium-review.googlesource.com/1113934
      > > Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#54039}
      >
      > Bug: chromium:844008
      > Change-Id: I4c44e74c7cf5fe380ffa4ce9f106bebb57bc023d
      > Reviewed-on: https://chromium-review.googlesource.com/1116438
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      > Cr-Commit-Position: refs/heads/master@{#54046}
      
      TBR=ulan@chromium.org,dinfuehr@google.com
      
      Change-Id: I4a059e86ba06e0b2562afc311b12d397cd78e857
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:844008
      Reviewed-on: https://chromium-review.googlesource.com/1116718Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54047}
      265d5c24
    • Dominik Inführ's avatar
      Reland "[heap] Visit individual ephemerons instead of collections" · 91f113e2
      Dominik Inführ authored
      This is a reland of 9aba0159
      
      Original change's description:
      > [heap] Visit individual ephemerons instead of collections
      > 
      > When marking ephemerons visit individual ephemerons with key and value
      > unreachable instead of simply iterating all ephemerons in all weak
      > collections. Also visit ephemerons at end of concurrent marking to do
      > work we would otherwise need to do in the atomic pause.
      > 
      > Bug: chromium:844008
      > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7
      > Reviewed-on: https://chromium-review.googlesource.com/1113934
      > Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54039}
      
      Bug: chromium:844008
      Change-Id: I4c44e74c7cf5fe380ffa4ce9f106bebb57bc023d
      Reviewed-on: https://chromium-review.googlesource.com/1116438Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      Cr-Commit-Position: refs/heads/master@{#54046}
      91f113e2
    • Jakob Kummerow's avatar
      Revert "[heap] Visit individual ephemerons instead of collections" · 4b429b10
      Jakob Kummerow authored
      This reverts commit 9aba0159.
      
      Reason for revert: causes widespread breakage on Chromium-integrated builds, failing here:
      
        CHECK_EQ(0, heap()->local_embedder_heap_tracer()->NumberOfWrappersToTrace());
      
      in MarkCompactCollector::ProcessEphemeronMarking(). See e.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8.fyi%2FV8-Blink_Linux_64__dbg_%2F12321%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Fstdout and more on https://ci.chromium.org/p/v8/g/fyi/console
      
      Original change's description:
      > [heap] Visit individual ephemerons instead of collections
      > 
      > When marking ephemerons visit individual ephemerons with key and value
      > unreachable instead of simply iterating all ephemerons in all weak
      > collections. Also visit ephemerons at end of concurrent marking to do
      > work we would otherwise need to do in the atomic pause.
      > 
      > Bug: chromium:844008
      > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7
      > Reviewed-on: https://chromium-review.googlesource.com/1113934
      > Commit-Queue: Dominik Inführ <dinfuehr@google.com>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54039}
      
      TBR=ulan@chromium.org,dinfuehr@google.com
      
      Change-Id: Ib44bfe8c49e8fc30c3d0f2beba03a2895530dfd6
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:844008
      Reviewed-on: https://chromium-review.googlesource.com/1116118Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54045}
      4b429b10
  5. 26 Jun, 2018 1 commit
  6. 08 Jun, 2018 1 commit
  7. 02 Feb, 2018 1 commit
  8. 10 Oct, 2017 1 commit
    • Michael Lippautz's avatar
      [heap] Introduce on-hold concurrent marking work list · b7e6eb92
      Michael Lippautz authored
      When hitting objects that are allocated in the most recent lienar
      allocation area, the concurrent marker currently has to bail out to the
      main thread.
      
      However, we only have to delay processing those objects until we are at
      a safepoint, e.g. IM::Step(). With this change we flush those
      on-hold-objects back to the shared queue upon performing an incremental
      marking step.
      
      Bug: chromium:694255
      Change-Id: I25647d0fc581a5c4de0346bc394dc51062f65f70
      Reviewed-on: https://chromium-review.googlesource.com/707315
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48424}
      b7e6eb92
  9. 25 Aug, 2017 1 commit
  10. 07 Aug, 2017 1 commit
  11. 24 Jul, 2017 1 commit
  12. 14 Jul, 2017 1 commit
  13. 12 Jul, 2017 2 commits
  14. 06 Jul, 2017 1 commit
  15. 05 Jul, 2017 2 commits
  16. 04 Jul, 2017 1 commit
  17. 26 Jun, 2017 2 commits
  18. 23 Jun, 2017 2 commits
  19. 22 Jun, 2017 1 commit