Skip to content

V
V8
Switch branch/tag
  1. 14 Oct, 2016 2 commits
    • verwaest's avatar
      Drop Lazy from parser method names and events · 7899fcc5
      verwaest authored 
      BUG=

Review-Url: https://codereview.chromium.org/2414383002
Cr-Commit-Position: refs/heads/master@{#40318}
      7899fcc5
    • marja's avatar
      Remove "is function lazy" logic from Preparser + tiny error reporting refactoring. · 97fe83c7
      marja authored 
      It doesn't need to have this logic.

ParseLazyFunctionLiteralBody is basically just ParseStatementList
+ log the function position. But PreParser doesn't need to have
the "which functions to log" logic, since logging the function is
always done exactly when Parser falls back to PreParser. (See
PreParseLazyFunction.)

So in the current state, PreParser would log several functions in
a SingletonLogger, and only the last one would take
effect (that's the one Parser also logs in SkipLazyFunctionBody).

Also updated test-parsing/Regress928 to produce the preparse data
the way we do now (i.e., not running the PreParser directly, but
running the Parser).

Error reporting: when PreParser finds an error, it doesn't need
to ReportUnexpectedToken in PreParseLazyFunction, since it
already has reported the error whenever it found it.

BUG=v8:5515

Review-Url: https://codereview.chromium.org/2421833002
Cr-Commit-Position: refs/heads/master@{#40315}
      97fe83c7
  3. 13 Oct, 2016 2 commits
  5. 10 Oct, 2016 1 commit
  7. 07 Oct, 2016 1 commit
  9. 04 Oct, 2016 1 commit
  11. 30 Sep, 2016 1 commit
  13. 28 Sep, 2016 4 commits
  15. 27 Sep, 2016 4 commits
  17. 26 Sep, 2016 4 commits
  19. 21 Sep, 2016 1 commit
  21. 20 Sep, 2016 1 commit
  23. 19 Sep, 2016 1 commit
  25. 16 Sep, 2016 5 commits
  27. 12 Sep, 2016 1 commit
    • nikolaos's avatar
      [parser] Refactor of Parse*Statement*, part 6 · e850ed2a
      nikolaos authored 
      This patch moves the following parsing method to ParserBase:

- ParseSwitchStatement

It also removes ParseCaseClause and merges it with ParseSwitchStatement,
mainly to avoid the complexity of introducing one more abstract typedef
to be shared between parser implementations, but also because the merged
ParseSwitchStatement is now only 59 lines.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2324843005
Cr-Commit-Position: refs/heads/master@{#39337}
      e850ed2a
  29. 10 Sep, 2016 2 commits
  31. 09 Sep, 2016 2 commits
  33. 08 Sep, 2016 1 commit
    • nikolaos's avatar
      [parser] Refactor of Parse*Statement*, part 3 · 6874978c
      nikolaos authored 
      This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2318263002
Cr-Commit-Position: refs/heads/master@{#39272}
      6874978c
  35. 07 Sep, 2016 1 commit
  37. 06 Sep, 2016 2 commits
    • bakkot's avatar
      [parser] Simplify parse-time function name inference for properties · 2aab10f5
      bakkot authored 
      Move the code to perform function name inference for properties into
parsing the properties themselves, instead of the containing object.

This allows us to avoid unnecessary calls when parsing shorthand
properties and methods and simplifies the logic in the remaining cases.

Also fixes an edge case bug: inferring the name of the getter in
`class { static get constructor(){} }`.

Review-Url: https://codereview.chromium.org/2313723005
Cr-Commit-Position: refs/heads/master@{#39222}
      2aab10f5
    • bakkot's avatar
      Split the AST representation of class properties from object properties. · 7bc200c7
      bakkot authored 
      This introduces ClassLiteralProperty and a supertype LiteralProperty of
it and ObjectLiteralProperty. It also splits the parsing of the two.
This substiantially clarifies some logic, especially as classes
continue to evolve, and is also about a 2% performance improvement to
parsing either kind of property (since no work is wasted on logic
only necessary for the other kind). Also, it saves a word on
ObjectLiteralProperties.

Review-Url: https://codereview.chromium.org/2302643002
Cr-Commit-Position: refs/heads/master@{#39219}
      7bc200c7
  39. 05 Sep, 2016 3 commits