Skip to content

V
V8
Switch branch/tag
  1. 01 Oct, 2014 1 commit
  3. 04 Aug, 2014 1 commit
  5. 09 Jul, 2014 1 commit
  7. 20 Jun, 2014 1 commit
  9. 03 Jun, 2014 1 commit
  11. 23 May, 2014 1 commit
  13. 29 Apr, 2014 1 commit
  15. 21 Mar, 2014 1 commit
  17. 14 Mar, 2014 1 commit
  19. 12 Feb, 2014 1 commit
  21. 23 Jul, 2013 1 commit
    • yurys@chromium.org's avatar
      Fix call stack sampling for the case when native callback invokes JS function · 97f8f91b
      yurys@chromium.org authored 
      The SafeStackFrameIterator used by CPU profiler checked if Isolate::c_entry_fp is null and if it is not it would think that the control flow currently is in some native code. This assumption is wrong because the native code could have called a JS function but JSEntryStub would not reset c_entry_fp to NULL in that case. This CL adds a check in SafeStackFrameIterator::IsValidTop for the case when there is a JAVA_SCRIPT frame on top of EXIT frame.

Also this CL changes ExternalCallbackScope behavior to provide access to the whole stack of the scope objects instead of only top one. This allowed to provide exact callback names for those EXIT frames where external callbacks are called. Without this change it was possible only for the top most native call.

BUG=None
R=loislo@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/19775017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15832 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      97f8f91b
  23. 11 Jul, 2013 1 commit
  25. 28 Jun, 2013 1 commit
  27. 27 Jun, 2013 3 commits
  29. 25 Jun, 2013 1 commit
  31. 24 Jun, 2013 1 commit
    • yurys@chromium.org's avatar
      Simplify stack iterators implementation · f830fbea
      yurys@chromium.org authored 
      In order to fix https://code.google.com/p/chromium/issues/detail?id=252097 I
need to change SafeStackTraceFrameIterator. Stack iterators hierarchy looks
excessively complicated and I'd like to flatten it a bit by removing some
intermediate classes. In particular there are two hierarchies sharing
JavaScriptFrameIteratorTemp<T> template for no good reason.

This change extracts some of JavaScriptFrameIteratorTemp functionality directly
into SafeStackTraceFrameIterator. This made it obvious that a few checks were
performed twice.

The rest of JavaScriptFrameIteratorTemp<T> is merged with
JavaScriptFrameIterator. Now that the class is not a template some of its
implementation is moved from frames-inl.h into frames.cc

So in this change I removed JavaScriptFrameIterator and
SafeJavaScriptFrameIterator. As the next step I'm going to merge
SafeStackFrameIterator into SafeStackTraceFrameIterator.

BUG=None
R=loislo@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/16917004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15275 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      f830fbea
  33. 08 May, 2013 1 commit
  35. 26 Apr, 2013 2 commits
  37. 05 Feb, 2013 1 commit
  39. 29 Jan, 2013 1 commit
  41. 18 Dec, 2012 1 commit
  43. 10 Dec, 2012 1 commit
  45. 05 Dec, 2012 1 commit
  47. 03 Dec, 2012 2 commits
  49. 30 Nov, 2012 2 commits
  51. 28 Feb, 2012 1 commit
  53. 09 Feb, 2012 1 commit
  55. 11 Nov, 2011 3 commits
  57. 12 Oct, 2011 1 commit
  59. 03 Oct, 2011 1 commit
  61. 20 Sep, 2011 1 commit
  63. 12 Aug, 2011 1 commit
  65. 06 Apr, 2011 1 commit