- 03 Sep, 2018 13 commits
-
-
Florian Sattler authored
PreParser types, e.g., PreParserExpression, PreParserList, PreParserFormalParameter. This also enhances ThreadedLists to be used on the same class more than once. Bug: v8:7926 Change-Id: Ied204120e5d12ab1f1c4192f6b3c05971a12683b Reviewed-on: https://chromium-review.googlesource.com/1199262 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55584}
-
Michael Starzinger authored
R=titzer@chromium.org TEST=mjsunit/wasm/anyref Change-Id: Ia79c78038f6cc92f657ee1b48474323bde981155 Reviewed-on: https://chromium-review.googlesource.com/1201784Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55583}
-
Dan Elphick authored
Bug: v8:8068 Change-Id: Iaa89311441305cfe938a938b456045b40dec3943 Reviewed-on: https://chromium-review.googlesource.com/1199463Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55582}
-
Dan Elphick authored
When v8_enable_embedded_bytecode_handlers is true, initialize the bytecode dispatch table from the builtins table. Also stops creating the handlers more than once as the SetupInterpreter will now always do nothing even when not starting from a snapshot. In the short term, with the flag enabled all the bytecode handlers are eagerly deserialized. Finally, the bytecode handlers are marked as non-isolate independent to prevent them being embedded in the binary until they can be converted. Bug: v8:8068 Change-Id: I9e5ef7f1dce1b2d11c7aa26526f06b53f8939697 Reviewed-on: https://chromium-review.googlesource.com/1188477Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I93ecb8540a002b6bfca857c2938920ac52308df1 Reviewed-on: https://chromium-review.googlesource.com/1193874Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55580}
-
Alexander Timokhin authored
After https://chromium-review.googlesource.com/c/v8/v8/+/1101323 some AllocationSites can have dropped weak_next field, but this doesn't suported in serializer/deserializer. This CL adds support for such AllocationSites. Change-Id: Ibf495ae4effdf4e127892d906967d8e30eebfc87 Reviewed-on: https://chromium-review.googlesource.com/1183238 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55579}
-
Simon Zünd authored
This CL replaces occurrences of "length" with the CSA macro LengthStringConstant(). R=jgruber@chromium.org Bug: v8:8015 Change-Id: Idf095587940f859e4c634865560abae325cd9fb4 Reviewed-on: https://chromium-review.googlesource.com/1201782Reviewed-by:
-
Simon Zünd authored
This CL does two things: It adds a CSA helper to determine whether the debug_execution_mode is kSideEffects. And it adds a runtime function that exposes PerformSideEffectCheckForObject. This will be needed for the Array.p.unshift Torque version. R=jgruber@chromium.org Change-Id: Idc1ae077956e0862e613a2c28af3f2cf4d5c3762 Reviewed-on: https://chromium-review.googlesource.com/1196362 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Simon Zünd authored
This CL replaces the JavaScript fall-back for Array.p.shift with a baseline C++ implementation. R=jgruber@chromium.org Bug: v8:7624 Change-Id: Ib55e04e18e4e69089fc541636d3cad7fcb4c7245 Reviewed-on: https://chromium-review.googlesource.com/1186327 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: Ie2024c5425b657ba1779f1cd2108c7cf406ffade Reviewed-on: https://chromium-review.googlesource.com/1174431 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Yang Guo authored
New steps would be - `tools/dev/v8gen.py x64.release.sample` - `ninja -C out.gn/x64.release.sample v8_monolith` - `g++ -I. -Iinclude samples/hello-world.cc -o hello_world lv8_monolith -Lout.gn/x64.release.sample/obj/ -pthread -std=c++0x` - `./hello_world` (no more worrying about .bin files) R=jkummerow@chromium.org, mths@chromium.org Change-Id: I3bba03b4c3ed34daf242a570f420b90f94ec6de0 Reviewed-on: https://chromium-review.googlesource.com/1179663 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#55574}
-
Yang Guo authored
These are now direct dependencies in Node.js. R=lushnikov@chromium.org Change-Id: I01a68394e2e22a1024b6c21b8222ac8b113fc693 Reviewed-on: https://chromium-review.googlesource.com/1179143 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Bug: None Change-Id: I26f136ff20f67b3eebc4374c9ac380d63f720ba9 Reviewed-on: https://chromium-review.googlesource.com/1192802 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
- 02 Sep, 2018 2 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:826280 Change-Id: I1ffaa592c686e07f13426d4f8459d50ff59b4d3c Reviewed-on: https://chromium-review.googlesource.com/1171239 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55571}
-
Benedikt Meurer authored
The typing rules for NumberMax and NumberMin didn't properly deal with -0 up until now, leading to suboptimal typing, i.e. for a simple case like Math.max(Math.round(x), 1) TurboFan was unable to figure out that the result is definitely going to be a positive integer in the range [1,inf] or NaN (assuming that NumberOrOddball feedback is used for the value x). Bug: v8:8015 Change-Id: I06e14a9c9b0b813eb214ace7749fcc6ab36bb66a Reviewed-on: https://chromium-review.googlesource.com/1199304 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
- 01 Sep, 2018 2 commits
-
-
Benedikt Meurer authored
Printing of both union and tuple types was broken such that the first type was always skipped due to a bug. Bug: v8:8015 Change-Id: I4bd215a9d8fa5bc7e017dd28e66512f4961228d1 Reviewed-on: https://chromium-review.googlesource.com/1199365Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1a26c15..6773a0d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cd6bcbe..5167fb3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e7f9302..e323bd9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/58f7169..3aa6139 Rolling v8/tools/gyp: https://chromium.googlesource.com/external/gyp/+log/d61a939..81286d3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iada5a1194eef2052e0915b7bcf3c6e1576739fa1 Reviewed-on: https://chromium-review.googlesource.com/1199912Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55568}
-
- 31 Aug, 2018 23 commits
-
-
Sathya Gunasekaran authored
This makes us spec compliant. Bug: chromium:875643 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I489870495fe1d326991c99f0551fe3329268c984 Reviewed-on: https://chromium-review.googlesource.com/1199910 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55567}
-
Sathya Gunasekaran authored
Instead of creating the SFIs during bootstrapping and storing on the context, this patch just creates the SFIs on demand. This patch saves 8 words per context, and several words per bound function by not storing the SFI. The created bound JSFunction is cached on the instance anyway, so it's totally fine to take a small hit when creating the bound JSFunction. Previously in the JS implementation, the creation of a bound function was even slower as it was a lazy function that would have to parsed, compiled and executed. So this is a step up in terms up perf and memory. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If3b8461d00e5b37567b34b236d44e14576b630ff Reviewed-on: https://chromium-review.googlesource.com/1200006Reviewed-by:
-
Frank Tang authored
Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie3005cc93e582ea4d8d501a8a4a194d7ae35c129 Reviewed-on: https://chromium-review.googlesource.com/1198682 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55565}
-
🎉 Michael Achenbach authoredThis reverts commit 4dac9872. Reason for revert: Speculative revert for layout test failures: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25970 E.g.: virtual/service-worker-servicification/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html Original change's description: > Ship globalThis
🎉 > > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > Bug: v8:5537 > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > Reviewed-on: https://chromium-review.googlesource.com/1195494 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55543} TBR=adamk@chromium.org,gsathya@chromium.org,mathias@chromium.org Change-Id: Iacb484d36ba2c8002336038660450b240006e0ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5537 Reviewed-on: https://chromium-review.googlesource.com/1199743Reviewed-by:Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55564}
-
Marijn Kruisselbrink authored
Bug: chromium:872465 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I75eccab304405569b40c5dcc18177354372a02c9 Reviewed-on: https://chromium-review.googlesource.com/1199464Reviewed-by:
-
Wez authored
Updates zx_vmar_*_old() callers back to the zx_vmar_*() equivalents, which have a new parameter order. Change-Id: I1662b4fbb866cef4eedc13e0db3e9389d4375d1e Reviewed-on: https://chromium-review.googlesource.com/1199903 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:7961 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1d7f0a9e6e44cb34799f074ffa9fe8ca39bcef2b Reviewed-on: https://chromium-review.googlesource.com/1198766Reviewed-by:
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: chromium:879604 Change-Id: I051837bae866f391ec5f1555b845cd66cc9f777a Reviewed-on: https://chromium-review.googlesource.com/1199285 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:8110 Change-Id: I7531ca961d0a0ed612ea3571c2bbef290b87c035 Reviewed-on: https://chromium-review.googlesource.com/1196689Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ed29828..1a26c15 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d0d714d..cd6bcbe Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5cc2afd..e7f9302 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/3ec92c8..e0c4613 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/d526632..2e68926 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/bb4146f..58f7169 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8e0b4d715ddd47e8779c1300422e462b3470b373 Reviewed-on: https://chromium-review.googlesource.com/1199902 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
jgruber authored
This reorders arguments in preparation for removing ebx from its calling convention (in a follow-up some args will be passed on the stack). Drive-by: Improve readability in the code handling different cases (array,spread,...). Bug: v8:6666 Change-Id: I0160f8efafd0fd0e841739578e01c32b38adb66e Reviewed-on: https://chromium-review.googlesource.com/1196884Reviewed-by:
-
Benedikt Meurer authored
We can safely lower ToNumeric(x) to ToNumber(x) as long as we can guarantee that x is any primitive except BigInt (as ToNumeric would return that unchanged while ToNumber will throw). Bug: v8:8015 Change-Id: I66573cc204c7c919095ca7598a027fabef7d71a8 Reviewed-on: https://chromium-review.googlesource.com/1199665Reviewed-by:
-
Michael Achenbach authored
This ports https://crrev.com/c/1185020 [Fuchsia] Add Mac build support. This also rolls v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9f16b23..ed29828 TBR=yangguo@chromium.org Bug: chromium:707030 Change-Id: Ib74df070fa4a2b77c4837f82e4e4d8666a3166e5 Reviewed-on: https://chromium-review.googlesource.com/1199404 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
jgruber authored
In preparation for kRootRegister support on ia32. For both descriptors we simply shuffle registers around to remove ebx from the calling convention. Possible follow-up work: The ApiCallbackDescriptor could be simplified by passing call_data (and the Undefined constant) on the stack. This currently happens in the builtin body. Drive-by: Minor refactoring in InterpreterPushArgsMode to deobfuscate the different paths (spread/no-spread). Also use {Push,Pop}ReturnAddress helpers. Bug: v8:6666 Change-Id: I25fd738501fff71c038a0745cec04363f90df660 Reviewed-on: https://chromium-review.googlesource.com/1196552Reviewed-by: -
Benedikt Meurer authored
Bug: chromium:879560 Change-Id: Ia2d2699851358641d50f9997875810f8cb1100ff Reviewed-on: https://chromium-review.googlesource.com/1199742Reviewed-by:
-
Alexey Kozyatinskiy authored
We can use Seek + Advance instead on source stream. TBR=verwaest@chromium.org Bug: chromium:879550 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic6ad12a86105ce68ea404e313b74d11417928cf0 Reviewed-on: https://chromium-review.googlesource.com/1196686 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55552}
-
Alexey Kozyatinskiy authored
GetIdentityHashHelper function can return hash from GlobalDictionary, but SetHashAndUpdateProperties crashes on DCHECK on attempt to set this hash (it works when DCHECKs are disabled because SetHash is defined on base class for NameDictionary and GlobalDictionary). R=yangguo@chromium.org Bug: none Change-Id: I740fa6a3232f7db8e4396b9a5e4664b8ab81969a Reviewed-on: https://chromium-review.googlesource.com/1198765Reviewed-by:
-
Alexey Kozyatinskiy authored
DebugEvaluate contains code since 2009 that bypasses JSGlobalProxy and returns JSGlobalObject when result of expression is global proxy. This behavior may be dangerous: - JSGlobalObject does not perform security checks, - some parts of V8 code do not ready for JSGlobalObject, e.g., SetHashAndUpdateProperties function will crash on DCHECK if we will try to store JSGlobalObject to map. At the same time it looks like there is no any valid use case for it. R=yangguo@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib0e35d5ae9ef47318c866e44c5c6856e34ed05a5 Reviewed-on: https://chromium-review.googlesource.com/1198764Reviewed-by:
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dd6b994..9f16b23 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bc2c0a9..d0d714d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2d0e03c..5cc2afd TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I292ecb01b67446d985dc7070f9f7c453395e7981 Reviewed-on: https://chromium-review.googlesource.com/1192237 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Mike Stanton authored
Change-Id: Ibfddd236dbe8b6a205a457aea1cb9eb00b0a3572 Reviewed-on: https://chromium-review.googlesource.com/1199403Reviewed-by:
-
Benedikt Meurer authored
As noticed by jkummerow@ there's probably not really a point in keeping two separate runtime functions that perform the same operation, but one has a different fast-path (which is not available to the other). So %KeyedGetProperty is now effectively %GetProperty and used consistently as fallback from both the ICs as well as other callers like the GetProperty builtin. Bug: v8:8015 Change-Id: Ib46b13da739229e2eb820ecf87923ac99c6971d3 Reviewed-on: https://chromium-review.googlesource.com/1199105 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL fixes an issue where getters/setters would get called on a prototype with the wrong receiver. This happens in the pre-processing for Array.p.sort when values get copied down from the prototype chain. R=jgruber@chromium.org Bug: v8:7682 Change-Id: I0d8ff1dc721c33bd721aaca54ffd357b3d2a2096 Reviewed-on: https://chromium-review.googlesource.com/1198767Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7717, chromium:879304 Change-Id: I524a9cf45f6a69efe0445b4ffaddfffc85c5560d Reviewed-on: https://chromium-review.googlesource.com/1199282 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55545}
-
