1. 12 Apr, 2017 1 commit
  2. 06 Apr, 2017 1 commit
  3. 05 Apr, 2017 1 commit
  4. 04 Apr, 2017 2 commits
  5. 03 Apr, 2017 2 commits
  6. 24 Mar, 2017 1 commit
  7. 23 Mar, 2017 1 commit
    • yangguo's avatar
      [debug] introduce precise binary code coverage. · d71ef941
      yangguo authored
      With precise binary code coverage, the reported count is either 0 or 1.
      We only report 1 the first time we collect coverage data after the
      function has been executed.
      
      Since we do not care about the accurate execution count, we can optimize
      the function once it has been executed once.
      
      Also change best effort coverage to be implicitly binary.
      
      R=caseq@chromium.org, jgruber@chromium.org, pfeldman@chromium.org
      BUG=v8:5808
      
      Review-Url: https://codereview.chromium.org/2766573003
      Cr-Commit-Position: refs/heads/master@{#44074}
      d71ef941
  8. 21 Mar, 2017 1 commit
  9. 13 Mar, 2017 1 commit
  10. 09 Mar, 2017 1 commit
  11. 08 Mar, 2017 1 commit
  12. 06 Mar, 2017 2 commits
  13. 28 Feb, 2017 1 commit
  14. 27 Feb, 2017 1 commit
  15. 22 Feb, 2017 1 commit
  16. 16 Feb, 2017 1 commit
  17. 13 Feb, 2017 1 commit
  18. 09 Feb, 2017 1 commit
  19. 07 Feb, 2017 2 commits
  20. 03 Feb, 2017 1 commit
  21. 30 Jan, 2017 1 commit
  22. 27 Jan, 2017 1 commit
    • clemensh's avatar
      [inspector] Expose GetPossibleBreakpoints for wasm · c6663ef1
      clemensh authored
      and add an inspector test for it. Also test that a breakpoint can be
      set on each reported position, and that it is also hit during
      execution.
      This CL also fixes two little things which were uncovered by the new
      test.
      
      R=yangguo@chromium.org, titzer@chromium.org, kozyatinskiy@chromium.org
      BUG=v8:5822
      
      Review-Url: https://codereview.chromium.org/2655653003
      Cr-Commit-Position: refs/heads/master@{#42722}
      c6663ef1
  23. 25 Jan, 2017 1 commit
    • kozyatinskiy's avatar
      [inspector] change target promise for kDebugWillHandle & kDebugDidHandle · cb545a8c
      kozyatinskiy authored
      - kDebugPromiseCreated(task, parent_task)
      This event occurs when promise is created (PromiseHookType::Init). V8Debugger uses this event to maintain task -> parent task map.
      
      - kDebugEnqueueAsyncFunction(task)
      This event occurs when first internal promise for async function is created. V8Debugger collects stack trace at this point.
      
      - kDebugEnqueuePromiseResolve(task),
      This event occurs when Promise fulfills with resolved status. V8Debugger collects stack trace at this point.
      
      - kDebugEnqueuePromiseReject(task),
      This event occurs when Promise fulfills with rejected status. V8Debugger collects stack trace at this point.
      
      - kDebugPromiseCollected,
      This event occurs when Promise is collected and no other chained callbacks can be added. V8Debugger removes information about async task for this promise.
      
      - kDebugWillHandle,
      This event occurs when chained promise function (either resolve or reject handler) is called. V8Debugger installs parent promise's stack (based on task -> parent_task map) as current if available or current promise's scheduled stack otherwise.
      
      - kDebugDidHandle,
      This event occurs after chained promise function has finished. V8Debugger restores asynchronous call chain to previous one.
      
      With this change all instrumentation calls are related to current promise (before WillHandle and DidHandle were related to next async task).
      
      Before V8Debugger supported only the following:
      - asyncTaskScheduled(task1)
      - asyncTaskStarted(task1)
      - asyncTaskFinished(task1)
      
      Now V8Debugger supports the following:
      - asyncTaskScheduled(parent_task)
      ..
      - asyncTaskCreated(task, parent_task),
      - asyncTaskStarted(task), uses parent_task scheduled stack
      - asyncTaskScheduled(task)
      - asyncTaskFinished(task)
      
      Additionally: WillHandle and DidHandle were migrated to PromiseHook API.
      
      More details: https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE
      
      BUG=v8:5738
      R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2650803003
      Cr-Commit-Position: refs/heads/master@{#42644}
      cb545a8c
  24. 24 Jan, 2017 1 commit
    • kozyatinskiy's avatar
      [inspector] implemented blackboxing inside v8 · ac50c79a
      kozyatinskiy authored
      V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation.
      Advantages:
      - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step),
      - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps,
      - simplification of debugger agent logic.
      Disadvtanges:
      - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side.
      
      Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing
      
      BUG=v8:5842
      R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org
      
      Review-Url: https://codereview.chromium.org/2633803002
      Cr-Commit-Position: refs/heads/master@{#42614}
      ac50c79a
  25. 18 Jan, 2017 2 commits
  26. 13 Jan, 2017 1 commit
  27. 11 Jan, 2017 1 commit
  28. 12 Dec, 2016 1 commit
  29. 06 Dec, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce debug::WasmScript · 12cdb31b
      clemensh authored
      *and* report all "virtual" wasm scripts right when the wasm script is
      registered at the inspector.
      
      WasmScript is a subtype of Script, with the cast checking that it is
      actually a wasm script.
      This layout makes it quite easy to implement functionality that is only
      available for wasm scripts, and allows to later directly use the
      WasmCompiledModule instead of the i::Script for backing the
      debug::WasmScript. We might also add virtual methods to
      provide different implementations for GetSourcePosition, Source and
      others.
      
      DisassembleWasmFunction now also becomes a method of this class instead
      of a static function on the DebugInterface.
      
      The WasmTranslation now uses the new WasmScript type instead of the
      Script wrapper, and also registers all virtual wasm scripts immediately
      when the wasm script is made public to the inspector (when the wasm
      module is created).
      
      R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
      BUG=chromium:613110,chromium:659715
      
      Review-Url: https://codereview.chromium.org/2531163010
      Cr-Commit-Position: refs/heads/master@{#41519}
      12cdb31b
  30. 05 Dec, 2016 2 commits
    • clemensh's avatar
      [debug] Remove DebugInterface class · e6bd3063
      clemensh authored
      It only contained type definitions and static functions, so we
      can also just make it a namespace.
      
      R=kozyatinskiy@chromium.org, yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2549133002
      Cr-Commit-Position: refs/heads/master@{#41501}
      e6bd3063
    • clemensh's avatar
      [inspector] Split off interface-types.h · f5fb2da6
      clemensh authored
      This CL adds a new header src/debug/interface-types.h, moves the
      definition of Location from the debug-interface.h to this new header,
      and adds a new definition for the WasmDisassembly types.
      This allows to use the types in other implementation files or headers
      without having to include the entire debug-interface.h, reducing build
      dependencies and compile time (especially for incremental builds).
      
      The WasmDisassembly type replaces the old
      std::pair<std::string, std::vector<std::tuple<...>>>, which was a bit
      hard to unravel.
      
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2529383002
      Cr-Commit-Position: refs/heads/master@{#41488}
      f5fb2da6
  31. 17 Nov, 2016 1 commit
    • kozyatinskiy's avatar
      [inspector] introduced Script::TYPE_INSPECTOR · 6808ec1f
      kozyatinskiy authored
      Inspector uses this type for all internal scripts, e.g. injected-script-source.js. Scripts with new type are not reported by remote debugging protocol, frames from them are ignored.
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
      BUG=none
      R=yangguo@chromium.org,dgozman@chromium.org
      
      Review-Url: https://codereview.chromium.org/2499273003
      Cr-Commit-Position: refs/heads/master@{#41056}
      6808ec1f
  32. 16 Nov, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce translation of wasm frames · d4a42a5f
      clemensh authored
      This allows to show wasm source (disassembled wasm code) in DevTools.
      See design doc for details.
      
      More tests for the disassembly will have to follow. Also, the text
      format (generated by V8) will be changed.
      
      BUG=chromium:659715
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org
      
      Review-Url: https://codereview.chromium.org/2493773003
      Cr-Commit-Position: refs/heads/master@{#41055}
      d4a42a5f
  33. 04 Nov, 2016 1 commit
  34. 29 Oct, 2016 1 commit