- 25 Aug, 2020 1 commit
-
-
Andreas Haas authored
This CL is the start to implement reference types support in Liftoff. As a first step this CL implements the ref.null instruction, and allows reference types as return values. This allows register allocation to be extended to support reference types, and also adds an easy way to get a reference type value for tests. Additionally with ref.null we don't have to worry about garbage collection because 'null' is an immovable object and therefore does not have to be scanned by the GC. R=thibaudm@chromium.org Bug: v8:7581 Change-Id: I5785dcf522c0d9881e1386f2d8b5d8560a16225c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352784 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#69556}
-
- 14 Aug, 2020 1 commit
-
-
Manos Koukoutos authored
Drive-by: Add flag implications for wasm experimental features: gc -> typed_funcref, typed_funcref -> reftypes. Bug: v8:9495 Change-Id: Ia6054886935d68e79b8f463289aa9e1e9d6484f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352777Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69403}
-
- 13 Aug, 2020 1 commit
-
-
Manos Koukoutos authored
Changes: - Move some helper functions into WasmGraphBuilder. - Introduce call_mode and null_check as additional arguments to WasmGraphBuilderInterface::DoCall/DoReturnCall. - Introduce ValueType::is_strict_reference_type. - Improve usage of ValueType API. Bug: v8:9495 Change-Id: Id3fb9f0d7a4770475ac895b03b38bfa7f2fec252 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343083 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69372}
-
- 10 Aug, 2020 1 commit
-
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: If876c9499373f091067299fe333e7b59d6cefb41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343077Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69305}
-
- 27 Jul, 2020 1 commit
-
-
Manos Koukoutos authored
Change-Id: I29ab5285b3284ebecb97902703f5f1c0cc8f8961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317354Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69067}
-
- 22 Jul, 2020 1 commit
-
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I6e226888d84a790efc36ac6e7c2a32bc3426bd84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308341 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69002}
-
- 21 Jul, 2020 2 commits
-
-
Manos Koukoutos authored
They have been replaced with {array,struct}.new_with_rtt. Also, rework tests that used those instructions. Bug: v8:7748 Change-Id: I2aaccb1958bf2b8d6cad4969abc612216856393d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307318 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68961}
-
Manos Koukoutos authored
Also remove traces of array.new_sub Bug: v8:7748 Change-Id: I96a922a16406960a80af0788e9cad5aa5692000a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307237 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68956}
-
- 16 Jul, 2020 1 commit
-
-
Jakob Kummerow authored
We must perform "smi-checks" before loading an object's map whenever the object might be an i31ref. Bug: v8:7748 Change-Id: I2d9839ddcb0c2e8c35b9bea38afe50d55dd084cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299370Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68893}
-
- 10 Jul, 2020 2 commits
-
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I43384d10805b62745a4bc19fa0a4174e6ee94f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289777 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68804}
-
Igor Sheludko authored
... by migrating old-style code MyObject* obj = new (zone) MyObject(...) to the new style MyObject* obj = zone->New<MyObject>(...) Bug: v8:10689 Change-Id: I2fc4a44ea05e4d087565811f343893f0e97dc660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288857 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68789}
-
- 02 Jul, 2020 1 commit
-
-
Deepti Gandluri authored
- Add wasm opcode, decode and compiler code for v128.const - Add codegen implementations for v128.const on x64/Arm64 - Reuse/Rename some shuffle specific methods to handle generic 128-bit immediates - Tests Bug: v8:8460 Change-Id: Idc365c8f6402c13259400eac92e0b75bd0f991a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276176 Commit-Queue: Deepti Gandluri (OOO Till November) <gdeepti@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68643}
-
- 01 Jul, 2020 3 commits
-
-
Jakob Kummerow authored
No changes, just rebasing. Original review: https://chromium-review.googlesource.com/c/v8/v8/+/2277889 Bug: v8:7748 Change-Id: Iea3bc881eaab28b14d4e2af9892ee74848c59f04 Tbr: ahaas@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278463Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68642}
-
Jakob Kummerow authored
This reverts commit 3f74ece9. Reason for revert: build breakage, rebasing issue Original change's description: > [wasm-gc] Implement ref.test and ref.cast > > Bug: v8:7748 > Change-Id: If0023edf2f27448c605bd8aa6402bf76c7983a6e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277889 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68640} TBR=jkummerow@chromium.org,ahaas@chromium.org Change-Id: Idd4eee1711aed3c0a9f89a36793738c72a34c783 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278462Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68641}
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: If0023edf2f27448c605bd8aa6402bf76c7983a6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277889Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68640}
-
- 30 Jun, 2020 2 commits
-
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I6bbb73ceb397b102783ecfcc553264d83e926df2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273126 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68620}
-
Jakob Kummerow authored
This patch does not include support for RTTs for i31ref yet. Bug: v8:7748 Change-Id: Ifbeb8e305c2d0a57e4d5d6be761d046e330e0da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273135 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68613}
-
- 29 Jun, 2020 1 commit
-
-
Jakob Kummerow authored
Relanding without changes, revert reason was fixed by: https://chromium-review.googlesource.com/c/v8/v8/+/2272564 Originally reviewed at: https://chromium-review.googlesource.com/c/v8/v8/+/2260566 Original description: RTTs are internally represented as Maps. To store supertype information, this patch introduces a WasmTypeInfo object, which is installed on Wasm objects' Maps and points at both the off-heap type information and the parent RTT. In this patch, rtt.sub always creates a fresh RTT. The canonicalization that the proposal requires will be implemented later. Bug: v8:7748 Change-Id: I7fd4986efa3153ac68037ec418ea617f3f7636e8 Tbr: ulan@chromium.org Tbr: tebbi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273123Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68581}
-
- 26 Jun, 2020 2 commits
-
-
Shu-yu Guo authored
This reverts commit 04ce88ea. Reason for revert: TSAN failure: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/32135 Original change's description: > [wasm-gc] Implement rtt.sub > > RTTs are internally represented as Maps. To store supertype information, > this patch introduces a WasmTypeInfo object, which is installed on Wasm > objects' Maps and points at both the off-heap type information and the > parent RTT. > In this patch, rtt.sub always creates a fresh RTT. The canonicalization > that the proposal requires will be implemented later. > > Bug: v8:7748 > Change-Id: I8286dd11f520966155cd95c2bd844ec34fccd131 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260566 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68564} TBR=ulan@chromium.org,jkummerow@chromium.org,tebbi@chromium.org Change-Id: I311732e1ced4de7a58b87d4a9b6056e0d62aa986 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270734Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68567}
-
Jakob Kummerow authored
RTTs are internally represented as Maps. To store supertype information, this patch introduces a WasmTypeInfo object, which is installed on Wasm objects' Maps and points at both the off-heap type information and the parent RTT. In this patch, rtt.sub always creates a fresh RTT. The canonicalization that the proposal requires will be implemented later. Bug: v8:7748 Change-Id: I8286dd11f520966155cd95c2bd844ec34fccd131 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260566 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68564}
-
- 25 Jun, 2020 1 commit
-
-
Clemens Backes authored
Local type information was stored in the {WasmFullDecoder}, and a pointer to that vector was handed to {WasmDecoder}. Since {WasmFullDecoder} inherits from {WasmDecoder}, we can just move the vector to the {WasmDecoder} class, and save an indirection and an unnecessary nullptr check. Drive-by: Rename {GetLocalType} to {local_type}, since it's a simple accessor. Drive-by 2: Move fields of {WasmDecoder} to the end of the class, as mandated in the style guide. Drive-by 3: Rename some locals in the 'let' decoding to make the meaning more clear. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I6ab9831f0c1955e47562e84c5fbf15807439b024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264360Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68541}
-
- 24 Jun, 2020 3 commits
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ic55c1aeb2bceb72dff1338c4d9cbde9aa799f25a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2262914 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68525}
-
Manos Koukoutos authored
Some operations require an immediate argument that represents a heap type. This CL introduces a class to represent it and uses it where appropriate. Also, the redundant TypeIndexImmediate is removed. Bug: v8:7748 Change-Id: Ib4b1d50764a79f5dd3240688f8165c39745eaad8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260874 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68522}
-
Clemens Backes authored
This allows the compiler to eliminate more unneeded branches. Since all functions just do a lookup in a static table (either directly, or via compiling a switch to such a lookup), they are also good candidates for inlining, which is made possible by this change. One DCHECK is removed instead of pulling in the inl header, which would require more refactoring since the check is in a non-inl header. R=thibaudm@chromium.org TBR=jkummerow@chromium.org Bug: v8:10576 Change-Id: If0fd25fd62c5f30b896fc67a5458a5ae475a6351 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259944 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68508}
-
- 23 Jun, 2020 1 commit
-
-
Jakob Kummerow authored
along with a very basic test case. Bug: v8:7748 Change-Id: I93d4b280922dd9eba8defc1a83ca08a2a957376a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2254023 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68485}
-
- 18 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
Motivation: Changes to the typed function references and gc proposals solidified the notion of heap type, clarified nullable vs. non-nullable reference types, and introduced rtts, which contain an integer depth field in addition to a heap type. This required us to overhaul our ValueType representation, which results in extensive changes. To keep this CL "small", we do not try to implement the binary encoding as described in the proposals, but rather devise a simpler one of our own (see below). Also, we do not try to implement additional functionality for the new types. Changes: - Introduce HeapType. Move heap types from ValueType to HeapType. - Introduce Nullability for reference types. - Rework ValueType helper methods. - Introduce rtts in ValueType with an integer depth field. Include depth in the ValueType encoding. - Make the constructor of ValueType private, instead expose static functions which explicitly state what they create. - Change every switch statement on ValueType::Kind. Sometimes, we need nested switches. - Introduce temporary constants in ValueTypeCode for nullable types, use them for decoding. - In WasmGlobalObject, split 'flags' into 'raw_type' and 'is_mutable'. - Change IsSubtypeOfRef to IsSubtypeOfHeap and implement changes in subtyping. - kWasmFuncRef initializers are now non-nullable. Initializers are only required to be subtypes of the declared global type. - Change tests and fuzzers as needed. Bug: v8:7748 Change-Id: If41f783bd4128443b07e94188cea7dd53ab0bfa5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247657 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68408}
-
- 10 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
As per the latest update to the 'reference types' wasm proposal, the nullref type is removed. Following that, all its uses in V8 were also removed. This CL: - Removes now dead code referencing nullref. - Changes names of functions/exceptions containing 'nullref' to 'null'. - Changes nullref to the corresponding nullable type in some tests. Bug: v8:7748 Change-Id: I5b4606671d7b24dd48a45a3341e8a1c056fcd1d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238026 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68283}
-
- 09 Jun, 2020 2 commits
-
-
Manos Koukoutos authored
The reference types wasm proposal dropped all subtyping. Subsequently, the 'anyref' type was renamed to externref. This changes all references of the *type* anyref to externref. Additionally, the flag that permits this extension is renamed to "reftypes" to mirror the proposal name. Bug: v8:7748 Change-Id: Icf323f13b9660fd10540e65125af053fca3a03f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232941 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68270}
-
Arnaud Robin authored
Added wasm tracing support for turbofan with the flag --trace-wasm. The test suite was updated accordingly. R=clemensb@chromium.org Bug: v8:10559 Change-Id: Ie6ee2a05142081416d8572d4d72dcd315e0bf285 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235536Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Arnaud Robin <arobin@google.com> Cr-Commit-Position: refs/heads/master@{#68253}
-
- 05 Jun, 2020 2 commits
-
-
Manos Koukoutos authored
This change is needed to implement {struct,array}.get_{s,u}. Some functionality in wasm-compiler was factored out to helper functions LoadWithAlignment and StoreWithValueType. Bug: v8:7748 Change-Id: I2a04d09d40532f2389cc82b4c9ee3d8e003c5101 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231347Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68215}
-
Clemens Backes authored
Most interface calls are preceded by a reachability check, such that we only generate code if the current instruction is actually reachable. This is particularly important for Liftoff (TurboFan would throw out dead parts of the graph anyway). In order to speed up this check, this CL introduces a boolean flag directly on the {WasmFullDecoder}. This avoids checking whether an error has been set *plus* checking the reachability of the top-most control block. This provides 5-6% speedup on Liftoff compilation locally. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: Idcff623fb9c23473b06ebf91b3caee65cc6ca28b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230521Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68200}
-
- 27 May, 2020 1 commit
-
-
Manos Koukoutos authored
Motivation: In the wasm-gc proposal, structs and arrays are allowed to store elements of packed types i8 and i16. Changes: - Add i8 and i16 to ValueType. - Fix all case switches to handle the new cases. - Add a couple helper methods to ValueType and improve the implementation/usage of a couple more. Bug: v8:7748 Change-Id: I527cfe5acf5d877fc38e4212174ba9f9de5c40ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215046Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#67994}
-
- 20 May, 2020 1 commit
-
-
Manos Koukoutos authored
Changes: - Implement the 'let' opcode, as per https://github.com/WebAssembly/function-references/blob/master/proposals/function-references/Overview.md#local-bindings - Use a WasmDecoder in place of a plain decoder in OpcodeLength and AnalyzeLoopAssignment. - Change ControlBase to accept an additional 'locals_count' parameter. - Implement required test infrastructure and write some simple tests. Bug: v8:7748 Change-Id: I39d60d1f0c26016c8f89c009dc5f4119b0c73c87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204107 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67937}
-
- 18 May, 2020 3 commits
-
-
Manos Koukoutos authored
- Add a default, move, and copy constructor for SsaEnv and use them when possible. - Bring the Split method signature in line with Steal and Unimplemented. Changes: Change-Id: I626142fbd1c1ed15c1852b9bfc8b39a0e936b839 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204278 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67871}
-
Jakob Kummerow authored
When the intention is to handle every case, *and* when we can be reasonably sure that no invalid enum values will occur (e.g. from reading untrusted data), then we shouldn't have a "default:" case in a switch statement so that the compiler will warn us when a case is missing. Bug: v8:10506 Change-Id: Iefdebd54802611e7ec3479afa3c4e6506f97a095 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204284 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67854}
-
Manos Koukoutos authored
Also, change its 'locals' field to a ZoneVector. This is needed for 'let' as per [wasm-gc]. Bug: v8:7748 Change-Id: I9e6ca7f7e483b4bc13b64643107297be31af0e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202995 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67847}
-
- 15 May, 2020 1 commit
-
-
Jakob Kummerow authored
in function-body-decoder-impl.h. Bug: v8:10506 Change-Id: If31aa9e35cc34f6c1c191bd487b1b01727e01dc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204204 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67838}
-
- 12 May, 2020 1 commit
-
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I736aaebb08be1d43662058f0ffde8b877b025017 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193852Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67745}
-
- 11 May, 2020 2 commits
-
-
Jakob Kummerow authored
With bounds checks, null checks, and a test case. Bug: v8:7748 Change-Id: I9e7d68ecd883bd0279f22d11c1dc73cc8716a4cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192659 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67714}
-
Manos Koukoutos authored
Add br_on_null opcode, encoding, decoding, and elementary tests. Bug: v8:7748 Change-Id: Id771ea7f57694e1c1bffc83c4232132bf9ad9dbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190424 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67712}
-