Fix stale pointer issue in heap snapshot generator

Review URL: https://codereview.chromium.org/1109153002 Cr-Commit-Position: refs/heads/master@{#28124}

Fix stale pointer issue in heap snapshot generator
Review URL: https://codereview.chromium.org/1109153002 Cr-Commit-Position: refs/heads/master@{#28124}
fefe91ce · jkummerow · Commit bot · 98390a07 · fefe91ce
Commit fefe91ce authored Apr 29, 2015 by jkummerow Committed by Commit bot Apr 29, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

heap-snapshot-generator.cc src/heap-snapshot-generator.cc +3 -0

No files found.
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -2471,6 +2471,9 @@ void NativeObjectsExplorer::SetNativeRootReference(
      FindOrAddGroupInfo(info->GetGroupLabel());
  HeapEntry* group_entry =
      filler_->FindOrAddEntry(group_info, synthetic_entries_allocator_);
+  // |FindOrAddEntry| can move and resize the entries backing store. Reload
+  // potentially-stale pointer.
+  child_entry = filler_->FindEntry(info);
  filler_->SetNamedAutoIndexReference(
      HeapGraphEdge::kInternal,
      group_entry->index(),