Commit fee82d7f authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[build] Fix gn check errors for v8windbg

Bug: v8:7330
Change-Id: I4bb602a41f127d4e3201defa3176f7e99e6d3753
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851894
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#74254}
parent 6ad860b3
...@@ -2284,9 +2284,8 @@ if (v8_generate_external_defines_header) { ...@@ -2284,9 +2284,8 @@ if (v8_generate_external_defines_header) {
v8_header_set("v8_shared_internal_headers") { v8_header_set("v8_shared_internal_headers") {
visibility = [ visibility = [
":*", ":*",
"test/cctest:*", "test/*",
"test/unittests:*", "tools/*",
"tools/debug_helper/:*",
] ]
configs = [ ":internal_config" ] configs = [ ":internal_config" ]
...@@ -2303,7 +2302,10 @@ v8_header_set("v8_shared_internal_headers") { ...@@ -2303,7 +2302,10 @@ v8_header_set("v8_shared_internal_headers") {
} }
v8_header_set("v8_flags") { v8_header_set("v8_flags") {
visibility = [ ":*" ] visibility = [
":*",
"tools/*",
]
configs = [ ":internal_config" ] configs = [ ":internal_config" ]
......
...@@ -55,6 +55,9 @@ v8_shared_library("v8windbg") { ...@@ -55,6 +55,9 @@ v8_shared_library("v8windbg") {
deps = [ deps = [
":v8windbg_base", ":v8windbg_base",
"../debug_helper:v8_debug_helper", "../debug_helper:v8_debug_helper",
"//:v8_flags",
"//:v8_libbase",
"//:v8_shared_internal_headers",
] ]
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment