Commit fcc8399d authored by ofrobots's avatar ofrobots Committed by Commit bot

v8.gyp: fix mkpeephole on Windows for Node.js

The mkpeephole step was failing on Windows (only) for Node.js [1].
It seems that gyp was not creating the dependency graph correctly for
Windows. Work-around the problem by exposing the dependency directly
(as opposed to exposing it in the action), similar to how `mksnapshot`
works.

[1]: https://ci.nodejs.org/job/node-compile-windows/3798/label=win-vcbt2015/console

R=oth@chromium.org, rmcilroy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2276733002
Cr-Commit-Position: refs/heads/master@{#38869}
parent 615aea66
......@@ -401,15 +401,6 @@
'outputs': ['<(INTERMEDIATE_DIR)/bytecode-peephole-table.cc'],
'action': ['<(mkpeephole_exec)', '<(INTERMEDIATE_DIR)/bytecode-peephole-table.cc' ],
'process_outputs_as_sources': 1,
'conditions': [
['want_separate_host_toolset_mkpeephole==1', {
'dependencies': ['mkpeephole#host'],
'toolsets': ['host'],
}, {
'dependencies': ['mkpeephole'],
'toolsets': ['target'],
}],
],
}],
'sources': [ ### gcmole(all) ###
'../include/v8-debug.h',
......@@ -1278,6 +1269,13 @@
}, {
'toolsets': ['target'],
}],
['want_separate_host_toolset_mkpeephole==1', {
'toolsets': ['host', 'target'],
'dependencies': ['mkpeephole#host'],
}, {
'toolsets': ['target'],
'dependencies': ['mkpeephole'],
}],
['v8_target_arch=="arm"', {
'sources': [ ### gcmole(arch:arm) ###
'arm/assembler-arm-inl.h',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment