Skip to content

V
V8
Commit fa5a65ad authored by Zeynep Cankara's avatar Zeynep Cankara Committed by Commit Bot
Browse files
Options

[tools][system-analyzer] Clarify tool Instructions 

This CL updates the tool instructions to reflect changes in the tool.
Removes the empty <br> tags from the tool's panel templates.

Bug: v8:10644, v8:10727

Change-Id: I0b3db6adcd37518f9cdaf2839094ef86eff52dfb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2413253Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Commit-Queue: Zeynep Cankara <zcankara@google.com>
Cr-Commit-Position: refs/heads/master@{#69963}
parent eec34b40
Hide whitespace changes
Inline Side-by-side
Showing with 36 additions and 15 deletions
tools/system-analyzer/ic-panel-template.html
View file @ fa5a65ad
......@@ -55,7 +55,6 @@ found in the LICENSE file. -->
</style>
<div class="panel">
<h2>IC Panel</h2>
<h3>IC Explorer</h3>
<div id="legend">
<dl>
<dt>0</dt>
......@@ -74,11 +73,8 @@ found in the LICENSE file. -->
<dd>generic</dd>
</dl>
</div>
<h3>Data</h3>
<p>Trace Count: <span id="count">0</span></p>
<h3>Result</h3>
<p>
Group-Key:
......@@ -86,7 +82,6 @@ found in the LICENSE file. -->
</p>
<p>
Filter by Time
<br></br>
<input type="search" id="filter-time-start" placeholder="start"></input> :
<input type="search" id="filter-time-end" placeholder="end"></input>
<button id="filterICTimeBtn">Filter</button>
......
tools/system-analyzer/index.html
View file @ fa5a65ad
......@@ -111,6 +111,14 @@ found in the LICENSE file. -->
grid-column: span 2;
overflow: scroll;
}
a {
color: var(--primary-color);
}
a:hover {
color: var(--secondary-color);
}
</style>
<script type="module">
import { App } from './index.mjs';
......@@ -124,9 +132,7 @@ found in the LICENSE file. -->
<body>
<div id="content">
<section id="file-reader">
<br></br>
<log-file-reader id="log-file-reader"></log-file-reader>
<br></br>
</section>
<div class="theme-switch-wrapper">
<label class="theme-switch" for="checkbox">
......@@ -147,15 +153,36 @@ found in the LICENSE file. -->
<div id="instructions">
<h2>Instructions</h2>
<p>
Unified web interface for analyzing the trace information of the Maps/ICs
Unified web interface to analyse runtime information stored in the v8 log.
</p>
For generating log file from
<a href="https://v8.dev/docs/build" target="_blank">d8</a>:
<p>
Log Options:
</p>
<dl>
<dt>--trace-maps:</dt>
<dd>Log<a href="https://v8.dev/blog/fast-properties" target="_blank">
Maps</a></dd>
<dt>--trace_ic:</dt>
<dd>Log
<a href="https://mathiasbynens.be/notes/shapes-ics" target="_blank">
ICs</a></dd>
<dt>--log-source-code:</dt>
<dd>Log source code</dd>
</dl>
Usage:
<ul>
<li><code>/path/do/d8 --trace-maps --trace_ic --log-source-code $FILE
</code></li>
</ul>
For generating a log file from Chrome:
<ul>
<li> Visualize Map trees that have gathered</li>
<li><code> /path/to/d8 --trace-maps $FILE</code></li>
<li> Visualize IC events that have gathered</li>
<li><code> /path/to/d8 --trace_ic $FILE (your_script.js) </code></li>
<li><code>/path/to/chrome --user-data-dir=/var/tmp/chr1 --no-sandbox
--js-flags='--trace-ic --trace-maps --log-source-code’
$WEBSITE_URL</code></li>
</ul>
<h3>Keyboard Shortcuts</h3>
<h3>Keyboard Shortcuts for Navigation</h3>
<dl>
<dt><kbd>SHIFT</kbd> + <kbd>Arrow Up</kbd></dt>
<dd>Follow Map transition forward (first child)</dd>
......
tools/system-analyzer/map-panel-template.html
View file @ fa5a65ad
......@@ -16,8 +16,7 @@ found in the LICENSE file. -->
<map-transitions id="map-transitions"></map-transitions>
<h3>Search Map by Address</h3>
<section id="searchBar"></section>
<input type="search" id="searchBarInput" placeholder="Search maps by address.."></input>
<input type="search" id="searchBarInput"></input>
<button id="searchBarBtn">Search</button>
<map-details id="map-details"></map-details>
</div>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment