Commit ef88cefa authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

Skip protecting data memory on fuchsia

The {vmar.protect} API used for {SetPermissions} fails when called on
data memory with error -10 (ZX_ERR_INVALID_ARGS).
Skip fuchsia until we figure out the right API to use there.

R=cbruni@chromium.org

Bug: v8:13194
Change-Id: I20754f7212a892b8440f29658bf3db40f7745fe9
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3833820
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82494}
parent 30691690
......@@ -293,7 +293,9 @@ bool OS::SetPermissions(void* address, size_t size, MemoryPermission access) {
}
void OS::SetDataReadOnly(void* address, size_t size) {
CHECK(OS::SetPermissions(address, size, MemoryPermission::kRead));
// TODO(v8:13194): Figure out which API to use on fuchsia. {vmar.protect}
// fails.
// CHECK(OS::SetPermissions(address, size, MemoryPermission::kRead));
}
// static
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment