Skip to content

V
V8
Commit eaac00b4 authored by machenbach's avatar machenbach Committed by Commit bot
Browse files
Options

Revert of MIPS: Enable v8 compilation with CLANG. (patchset #1 id:1 of... 

Revert of MIPS: Enable v8 compilation with CLANG. (patchset #1 id:1 of https://codereview.chromium.org/1519493002/ )

Reason for revert:
[Sheriff] This seems to break chromium runhooks for android:
https://build.chromium.org/p/client.v8.fyi/builders/Android%20Builder/builds/1794

Original issue's description:
> MIPS: Enable v8 compilation with CLANG.
>
> Updated toolchain.gypi to support v8 using CLANG on MIPS. These changes
> include using integrated assembler with CLANG, and disabling options
> used by GCC which are not supported by CLANG.
>
> TEST=
> BUG=
>
> Committed: https://crrev.com/0bae3c393575de4503cb179faa220e597e35dd8f
> Cr-Commit-Position: refs/heads/master@{#32780}

TBR=paul.lind@imgtec.com,akos.palfi@imgtec.com,balazs.kilvady@imgtec.com,ivica.bogosavljevic@imgtec.com,jkummerow@chromium.org,Ilija.Pavlovic@imgtec.com,Ilija.Pavlovic@imgtec.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1520823002

Cr-Commit-Position: refs/heads/master@{#32781}
parent 0bae3c39
Hide whitespace changes
Inline Side-by-side
Showing with 11 additions and 69 deletions
build/toolchain.gypi
View file @ eaac00b4
...@@ -357,9 +357,6 @@ ...@@ -357,9 +357,6 @@
['ld_r_path!=""', { ['ld_r_path!=""', {
'ldflags': ['-Wl,--rpath=<(ld_r_path)'], 'ldflags': ['-Wl,--rpath=<(ld_r_path)'],
}], }],
[ 'clang==1', {
'cflags': ['-integrated-as'],
}],
], ],
}], }],
], ],
...@@ -409,12 +406,7 @@ ...@@ -409,12 +406,7 @@
'FPU_MODE_FP64', 'FPU_MODE_FP64',
], ],
'cflags!': ['-mfp32', '-mfpxx'], 'cflags!': ['-mfp32', '-mfpxx'],
'conditions': [ 'cflags': ['-mips32r6', '-Wa,-mips32r6'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32r6'],
}],
],
'cflags': ['-mips32r6'],
'ldflags': ['-mips32r6'], 'ldflags': ['-mips32r6'],
}], }],
['mips_arch_variant=="r2"', { ['mips_arch_variant=="r2"', {
...@@ -441,12 +433,7 @@ ...@@ -441,12 +433,7 @@
'cflags': ['-mfp32'], 'cflags': ['-mfp32'],
}], }],
], ],
'conditions': [ 'cflags': ['-mips32r2', '-Wa,-mips32r2'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32r2'],
}],
],
'cflags': ['-mips32r2'],
'ldflags': ['-mips32r2'], 'ldflags': ['-mips32r2'],
}], }],
['mips_arch_variant=="r1"', { ['mips_arch_variant=="r1"', {
...@@ -454,12 +441,7 @@ ...@@ -454,12 +441,7 @@
'FPU_MODE_FP32', 'FPU_MODE_FP32',
], ],
'cflags!': ['-mfp64', '-mfpxx'], 'cflags!': ['-mfp64', '-mfpxx'],
'conditions': [ 'cflags': ['-mips32', '-Wa,-mips32'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32'],
}],
],
'cflags': ['-mips32'],
'ldflags': ['-mips32'], 'ldflags': ['-mips32'],
}], }],
['mips_arch_variant=="rx"', { ['mips_arch_variant=="rx"', {
...@@ -468,12 +450,7 @@ ...@@ -468,12 +450,7 @@
'FPU_MODE_FPXX', 'FPU_MODE_FPXX',
], ],
'cflags!': ['-mfp64', '-mfp32'], 'cflags!': ['-mfp64', '-mfp32'],
'conditions': [ 'cflags': ['-mips32', '-Wa,-mips32', '-mfpxx'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32'],
}],
],
'cflags': ['-mips32', '-mfpxx'],
'ldflags': ['-mips32'], 'ldflags': ['-mips32'],
}], }],
], ],
...@@ -612,12 +589,7 @@ ...@@ -612,12 +589,7 @@
'FPU_MODE_FP64', 'FPU_MODE_FP64',
], ],
'cflags!': ['-mfp32', '-mfpxx'], 'cflags!': ['-mfp32', '-mfpxx'],
'conditions': [ 'cflags': ['-mips32r6', '-Wa,-mips32r6'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32r6'],
}],
],
'cflags': ['-mips32r6'],
'ldflags': ['-mips32r6'], 'ldflags': ['-mips32r6'],
}], }],
['mips_arch_variant=="r2"', { ['mips_arch_variant=="r2"', {
...@@ -644,22 +616,12 @@ ...@@ -644,22 +616,12 @@
'cflags': ['-mfp32'], 'cflags': ['-mfp32'],
}], }],
], ],
'conditions': [ 'cflags': ['-mips32r2', '-Wa,-mips32r2'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32r2'],
}],
],
'cflags': ['-mips32r2'],
'ldflags': ['-mips32r2'], 'ldflags': ['-mips32r2'],
}], }],
['mips_arch_variant=="r1"', { ['mips_arch_variant=="r1"', {
'cflags!': ['-mfp64', '-mfpxx'], 'cflags!': ['-mfp64', '-mfpxx'],
'conditions': [ 'cflags': ['-mips32', '-Wa,-mips32'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32'],
}],
],
'cflags': ['-mips32'],
'ldflags': ['-mips32'], 'ldflags': ['-mips32'],
}], }],
['mips_arch_variant=="rx"', { ['mips_arch_variant=="rx"', {
...@@ -668,12 +630,7 @@ ...@@ -668,12 +630,7 @@
'FPU_MODE_FPXX', 'FPU_MODE_FPXX',
], ],
'cflags!': ['-mfp64', '-mfp32'], 'cflags!': ['-mfp64', '-mfp32'],
'conditions': [ 'cflags': ['-mips32', '-Wa,-mips32', '-mfpxx'],
[ 'clang==0', {
'cflags': ['-Wa,-mips32'],
}],
],
'cflags': ['-mips32', '-mfpxx'],
'ldflags': ['-mips32'], 'ldflags': ['-mips32'],
}], }],
['mips_arch_variant=="loongson"', { ['mips_arch_variant=="loongson"', {
...@@ -682,12 +639,7 @@ ...@@ -682,12 +639,7 @@
'FPU_MODE_FP32', 'FPU_MODE_FP32',
], ],
'cflags!': ['-mfp64', '-mfpxx'], 'cflags!': ['-mfp64', '-mfpxx'],
'conditions': [ 'cflags': ['-mips3', '-Wa,-mips3', '-mfp32'],
[ 'clang==0', {
'cflags': ['-Wa,-mips3'],
}],
],
'cflags': ['-mips3', '-mfp32'],
}], }],
], ],
}, { }, {
...@@ -848,22 +800,12 @@ ...@@ -848,22 +800,12 @@
}], }],
['mips_arch_variant=="r6"', { ['mips_arch_variant=="r6"', {
'defines': ['_MIPS_ARCH_MIPS64R6',], 'defines': ['_MIPS_ARCH_MIPS64R6',],
'conditions': [ 'cflags': ['-mips64r6', '-mabi=64', '-Wa,-mips64r6'],
[ 'clang==0', {
'cflags': ['-Wa,-mips64r6'],
}],
],
'cflags': ['-mips64r6', '-mabi=64'],
'ldflags': ['-mips64r6', '-mabi=64'], 'ldflags': ['-mips64r6', '-mabi=64'],
}], }],
['mips_arch_variant=="r2"', { ['mips_arch_variant=="r2"', {
'defines': ['_MIPS_ARCH_MIPS64R2',], 'defines': ['_MIPS_ARCH_MIPS64R2',],
'conditions': [ 'cflags': ['-mips64r2', '-mabi=64', '-Wa,-mips64r2'],
[ 'clang==0', {
'cflags': ['-Wa,-mips64r2'],
}],
],
'cflags': ['-mips64r2', '-mabi=64'],
'ldflags': ['-mips64r2', '-mabi=64'], 'ldflags': ['-mips64r2', '-mabi=64'],
}], }],
], ],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment