Commit ea8cfa92 authored by brettw's avatar brettw Committed by Commit bot

Optionally use new GN optimization config.

The GN default optimization flag is changing from being specific to the
debug/release status of the build to always being "default_optimization" so
it's easier to override without being conditional on the exact setup in
BUILDCONFIG.gn. See https://codereview.chromium.org/1324623005/

Since V8 is DEPS-ed in, it will need to support both modes to allow a landing.
This patch uses a temporary transitional flag I added to BUILDCONFIG to
indicate which variant should be used. After the patch is landed, we can remove
the new conditions and just remove default_optimization.

Review URL: https://codereview.chromium.org/1333963002

Cr-Commit-Position: refs/heads/master@{#30703}
parent 6ed90e6d
...@@ -1534,7 +1534,11 @@ source_set("v8_base") { ...@@ -1534,7 +1534,11 @@ source_set("v8_base") {
] ]
if (!is_debug) { if (!is_debug) {
configs -= [ "//build/config/compiler:optimize" ] if (using_new_optimization_config) {
configs -= [ "//build/config/compiler:default_optimization" ]
} else {
configs -= [ "//build/config/compiler:optimize" ]
}
configs += [ "//build/config/compiler:optimize_max" ] configs += [ "//build/config/compiler:optimize_max" ]
} }
...@@ -1633,7 +1637,11 @@ source_set("v8_libbase") { ...@@ -1633,7 +1637,11 @@ source_set("v8_libbase") {
] ]
if (!is_debug) { if (!is_debug) {
configs -= [ "//build/config/compiler:optimize" ] if (using_new_optimization_config) {
configs -= [ "//build/config/compiler:default_optimization" ]
} else {
configs -= [ "//build/config/compiler:optimize" ]
}
configs += [ "//build/config/compiler:optimize_max" ] configs += [ "//build/config/compiler:optimize_max" ]
} }
...@@ -1700,7 +1708,11 @@ source_set("v8_libplatform") { ...@@ -1700,7 +1708,11 @@ source_set("v8_libplatform") {
] ]
if (!is_debug) { if (!is_debug) {
configs -= [ "//build/config/compiler:optimize" ] if (using_new_optimization_config) {
configs -= [ "//build/config/compiler:default_optimization" ]
} else {
configs -= [ "//build/config/compiler:optimize" ]
}
configs += [ "//build/config/compiler:optimize_max" ] configs += [ "//build/config/compiler:optimize_max" ]
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment