Commit e819e241 authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

[gcc] Fix some more gcc-only warnings

Bug: chromium:1307180
Change-Id: Ia279086ec3df9d64bd6a0255ebe27d9e583014c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732937Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81433}
parent 50d22763
...@@ -545,7 +545,7 @@ int DisassemblerIA32::F7Instruction(byte* data) { ...@@ -545,7 +545,7 @@ int DisassemblerIA32::F7Instruction(byte* data) {
byte modrm = *++data; byte modrm = *++data;
int mod, regop, rm; int mod, regop, rm;
get_modrm(modrm, &mod, &regop, &rm); get_modrm(modrm, &mod, &regop, &rm);
const char* mnem = nullptr; const char* mnem = "";
switch (regop) { switch (regop) {
case 0: case 0:
mnem = "test"; mnem = "test";
...@@ -587,7 +587,7 @@ int DisassemblerIA32::D1D3C1Instruction(byte* data) { ...@@ -587,7 +587,7 @@ int DisassemblerIA32::D1D3C1Instruction(byte* data) {
int mod, regop, rm; int mod, regop, rm;
get_modrm(modrm, &mod, &regop, &rm); get_modrm(modrm, &mod, &regop, &rm);
int imm8 = -1; int imm8 = -1;
const char* mnem = nullptr; const char* mnem = "";
switch (regop) { switch (regop) {
case kROL: case kROL:
mnem = "rol"; mnem = "rol";
...@@ -2075,7 +2075,7 @@ int DisassemblerIA32::InstructionDecode(v8::base::Vector<char> out_buffer, ...@@ -2075,7 +2075,7 @@ int DisassemblerIA32::InstructionDecode(v8::base::Vector<char> out_buffer,
data++; data++;
int mod, regop, rm; int mod, regop, rm;
get_modrm(*data, &mod, &regop, &rm); get_modrm(*data, &mod, &regop, &rm);
const char* mnem = nullptr; const char* mnem = "";
switch (regop) { switch (regop) {
case esi: case esi:
mnem = "push"; mnem = "push";
...@@ -2122,7 +2122,7 @@ int DisassemblerIA32::InstructionDecode(v8::base::Vector<char> out_buffer, ...@@ -2122,7 +2122,7 @@ int DisassemblerIA32::InstructionDecode(v8::base::Vector<char> out_buffer,
data++; data++;
int mod, regop, rm; int mod, regop, rm;
get_modrm(*data, &mod, &regop, &rm); get_modrm(*data, &mod, &regop, &rm);
const char* mnem = nullptr; const char* mnem = "";
switch (regop) { switch (regop) {
case 5: case 5:
mnem = "subb"; mnem = "subb";
......
...@@ -11561,7 +11561,7 @@ Handle<BigInt> RoundNumberToIncrement(Isolate* isolate, Handle<BigInt> x, ...@@ -11561,7 +11561,7 @@ Handle<BigInt> RoundNumberToIncrement(Isolate* isolate, Handle<BigInt> x,
// 1. Let quotient be x / increment. // 1. Let quotient be x / increment.
bool is_negative; bool is_negative;
// 2. If quotient < 0, then // 2. If quotient < 0, then
if (x->IsNegative() != increment < 0) { if (x->IsNegative() != (increment < 0)) {
// a. Let isNegative be true. // a. Let isNegative be true.
is_negative = true; is_negative = true;
// b. Set quotient to -quotient. // b. Set quotient to -quotient.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment