Commit e72aa7bf authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by Commit Bot

[x64] Remove unnecessary CanCover from instruction selector

Change-Id: Ieabacfd183370ee09bcb6126e16fbf3135d48134
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2011836Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65952}
parent c4906f6e
...@@ -433,8 +433,7 @@ void InstructionSelector::VisitStore(Node* node) { ...@@ -433,8 +433,7 @@ void InstructionSelector::VisitStore(Node* node) {
opcode | AddressingModeField::encode(addressing_mode); opcode | AddressingModeField::encode(addressing_mode);
if ((ElementSizeLog2Of(store_rep.representation()) < if ((ElementSizeLog2Of(store_rep.representation()) <
kSystemPointerSizeLog2) && kSystemPointerSizeLog2) &&
(value->opcode() == IrOpcode::kTruncateInt64ToInt32) && value->opcode() == IrOpcode::kTruncateInt64ToInt32) {
CanCover(node, value)) {
value = value->InputAt(0); value = value->InputAt(0);
} }
InstructionOperand value_operand = InstructionOperand value_operand =
...@@ -669,8 +668,7 @@ void VisitWord32Shift(InstructionSelector* selector, Node* node, ...@@ -669,8 +668,7 @@ void VisitWord32Shift(InstructionSelector* selector, Node* node,
Node* left = m.left().node(); Node* left = m.left().node();
Node* right = m.right().node(); Node* right = m.right().node();
if (left->opcode() == IrOpcode::kTruncateInt64ToInt32 && if (left->opcode() == IrOpcode::kTruncateInt64ToInt32) {
selector->CanCover(node, left)) {
left = left->InputAt(0); left = left->InputAt(0);
} }
...@@ -1818,13 +1816,11 @@ void VisitWordCompare(InstructionSelector* selector, Node* node, ...@@ -1818,13 +1816,11 @@ void VisitWordCompare(InstructionSelector* selector, Node* node,
// The 32-bit comparisons automatically truncate Word64 // The 32-bit comparisons automatically truncate Word64
// values to Word32 range, no need to do that explicitly. // values to Word32 range, no need to do that explicitly.
if (opcode == kX64Cmp32 || opcode == kX64Test32) { if (opcode == kX64Cmp32 || opcode == kX64Test32) {
if (left->opcode() == IrOpcode::kTruncateInt64ToInt32 && if (left->opcode() == IrOpcode::kTruncateInt64ToInt32) {
selector->CanCover(node, left)) {
left = left->InputAt(0); left = left->InputAt(0);
} }
if (right->opcode() == IrOpcode::kTruncateInt64ToInt32 && if (right->opcode() == IrOpcode::kTruncateInt64ToInt32) {
selector->CanCover(node, right)) {
right = right->InputAt(0); right = right->InputAt(0);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment