Commit e57f4bb3 authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[API] Deprecate OOMErrorCallback

Deprecate the OOMErrorCallback such that we can add a new parameter for
OOM details.

R=mlippautz@chromium.org

Bug: chromium:1323177
Change-Id: I72c931ad0d1b75cda46e8815387098acbe091c68
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632106Reviewed-by: 's avatarLutz Vahl <vahl@chromium.org>
Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80453}
parent 338c12b3
...@@ -220,7 +220,7 @@ using LegacyOOMErrorCallback = void (*)(const char* location, bool is_heap_oom); ...@@ -220,7 +220,7 @@ using LegacyOOMErrorCallback = void (*)(const char* location, bool is_heap_oom);
// TODO(chromium:1323177): Add a parameter for details, once this is deprecated // TODO(chromium:1323177): Add a parameter for details, once this is deprecated
// for at least one branch. // for at least one branch.
using OOMErrorCallback V8_DEPRECATE_SOON( using OOMErrorCallback V8_DEPRECATED(
"Use LegacyOOMErrorCallback; OOMErrorCallback will be changed " "Use LegacyOOMErrorCallback; OOMErrorCallback will be changed "
"(https://crbug.com/1323177)") = void (*)(const char* location, "(https://crbug.com/1323177)") = void (*)(const char* location,
bool is_heap_oom); bool is_heap_oom);
......
...@@ -287,7 +287,7 @@ class V8_EXPORT Isolate { ...@@ -287,7 +287,7 @@ class V8_EXPORT Isolate {
*/ */
FatalErrorCallback fatal_error_callback = nullptr; FatalErrorCallback fatal_error_callback = nullptr;
LegacyOOMErrorCallback legacy_oom_error_callback = nullptr; LegacyOOMErrorCallback legacy_oom_error_callback = nullptr;
V8_DEPRECATE_SOON( V8_DEPRECATED(
"Use legacy_oom_error_callback; OOMErrorCallback will be changed soon " "Use legacy_oom_error_callback; OOMErrorCallback will be changed soon "
"(https://crbug.com/1323177)") "(https://crbug.com/1323177)")
OOMErrorCallback oom_error_callback = nullptr; OOMErrorCallback oom_error_callback = nullptr;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment