Unify naming convention for tests and filter them in TestLoader for cctest

Bug: v8:12802
Change-Id: I2573ed6b59fe51a135bbec5734ff1b7414316b0a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596163Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80056}

test/cctest/BUILD.gn

@@ -83,8 +83,6 @@ v8_source_set("cctest_sources") {
     "compiler/c-signature.h",
     "compiler/call-tester.h",
     "compiler/code-assembler-tester.h",
-    "compiler/codegen-tester.cc",
-    "compiler/codegen-tester.h",
     "compiler/function-tester.cc",
     "compiler/function-tester.h",
     "compiler/node-observer-tester.h",
@@ -94,6 +92,8 @@ v8_source_set("cctest_sources") {
     "compiler/test-calls-with-arraylike-or-spread.cc",
     "compiler/test-code-assembler.cc",
     "compiler/test-code-generator.cc",
+    "compiler/test-codegen.cc",
+    "compiler/test-codegen.h",
     "compiler/test-concurrent-shared-function-info.cc",
     "compiler/test-gap-resolver.cc",
     "compiler/test-graph-visualizer.cc",
@@ -127,8 +127,6 @@ v8_source_set("cctest_sources") {
     "compiler/test-verify-type.cc",
     "compiler/value-helper.cc",
     "compiler/value-helper.h",
-    "disasm-regex-helper.cc",
-    "disasm-regex-helper.h",
     "expression-type-collector-macros.h",
     "gay-fixed.cc",
     "gay-fixed.h",
@@ -168,8 +166,8 @@ v8_source_set("cctest_sources") {
     "interpreter/test-interpreter.cc",
     "interpreter/test-source-positions.cc",
     "libplatform/test-tracing.cc",
-    "libsampler/signals-and-mutexes.cc",
     "libsampler/test-sampler.cc",
+    "libsampler/test-signals-and-mutexes.cc",
     "manually-externalized-buffer.h",
     "parsing/test-parse-decision.cc",
     "parsing/test-preparser.cc",
@@ -221,6 +219,8 @@ v8_source_set("cctest_sources") {
     "test-deoptimization.cc",
     "test-descriptor-array.cc",
     "test-dictionary.cc",
+    "test-disasm-regex-helper.cc",
+    "test-disasm-regex-helper.h",
     "test-diy-fp.cc",
     "test-double.cc",
     "test-dtoa.cc",

test/cctest/cctest.status

@@ -626,7 +626,7 @@
   'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP],
 
   # Tests that generate code at runtime.
-  'codegen-tester/*': [SKIP],
+  'test-codegen/*': [SKIP],
   'test-accessor-assembler/*': [SKIP],
   'test-assembler-*': [SKIP],
   'test-atomic-load-store-codegen/*': [SKIP],

test/cctest/compiler/test-atomic-load-store-codegen.cc

@@ -5,7 +5,7 @@
 #include "src/base/bits.h"
 #include "src/objects/objects-inl.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 namespace v8 {

test/cctest/compiler/test-basic-block-profiler.cc

@@ -5,7 +5,7 @@
 #include "src/diagnostics/basic-block-profiler.h"
 #include "src/objects/objects-inl.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 
 namespace v8 {
 namespace internal {

test/cctest/compiler/test-branch-combine.cc

@@ -5,7 +5,7 @@
 #include "src/base/overflowing-math.h"
 #include "src/objects/objects-inl.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 namespace v8 {

test/cctest/compiler/test-code-generator.cc

@@ -16,8 +16,8 @@
 #include "src/objects/smi.h"
 #include "test/cctest/cctest.h"
 #include "test/cctest/compiler/code-assembler-tester.h"
-#include "test/cctest/compiler/codegen-tester.h"
 #include "test/cctest/compiler/function-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 
 #if V8_ENABLE_WEBASSEMBLY
 #include "src/compiler/wasm-compiler.h"

test/cctest/compiler/codegen-tester.cc → test/cctest/compiler/test-codegen.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 
 #include "src/base/overflowing-math.h"
 #include "src/objects/objects-inl.h"
@@ -277,7 +277,6 @@ TEST(CompareWrapper) {
   CHECK_EQ(false, wFloat64LessThanOrEqual.Float64Compare(-1.8, -2.8));
 }
 
-
 void Int32BinopInputShapeTester::TestAllInputShapes() {
   base::Vector<const int32_t> inputs = ValueHelper::int32_vector();
   int num_int_inputs = static_cast<int>(inputs.size());
@@ -326,7 +325,6 @@ void Int32BinopInputShapeTester::TestAllInputShapes() {
   }
 }
 
-
 void Int32BinopInputShapeTester::Run(RawMachineAssemblerTester<int32_t>* m) {
   FOR_INT32_INPUTS(pl) {
     FOR_INT32_INPUTS(pr) {
@@ -338,7 +336,6 @@ void Int32BinopInputShapeTester::Run(RawMachineAssemblerTester<int32_t>* m) {
   }
 }
 
-
 void Int32BinopInputShapeTester::RunLeft(
     RawMachineAssemblerTester<int32_t>* m) {
   FOR_UINT32_INPUTS(i) {
@@ -348,7 +345,6 @@ void Int32BinopInputShapeTester::RunLeft(
   }
 }
 
-
 void Int32BinopInputShapeTester::RunRight(
     RawMachineAssemblerTester<int32_t>* m) {
   FOR_UINT32_INPUTS(i) {
@@ -358,7 +354,6 @@ void Int32BinopInputShapeTester::RunRight(
   }
 }
 
-
 TEST(ParametersEqual) {
   RawMachineAssemblerTester<int32_t> m(MachineType::Int32(),
                                        MachineType::Int32());
@@ -370,7 +365,6 @@ TEST(ParametersEqual) {
   CHECK_EQ(p1, m.Parameter(1));
 }
 
-
 void RunSmiConstant(int32_t v) {
 // TODO(dcarney): on x64 Smis are generated with the SmiConstantRegister
 #if !V8_TARGET_ARCH_X64
@@ -382,7 +376,6 @@ void RunSmiConstant(int32_t v) {
 #endif
 }
 
-
 void RunNumberConstant(double v) {
   RawMachineAssemblerTester<Object> m;
 #if V8_TARGET_ARCH_X64
@@ -395,14 +388,12 @@ void RunNumberConstant(double v) {
   m.CheckNumber(v, result);
 }
 
-
 TEST(RunEmpty) {
   RawMachineAssemblerTester<int32_t> m;
   m.Return(m.Int32Constant(0));
   CHECK_EQ(0, m.Call());
 }
 
-
 TEST(RunInt32Constants) {
   FOR_INT32_INPUTS(i) {
     RawMachineAssemblerTester<int32_t> m;
@@ -411,7 +402,6 @@ TEST(RunInt32Constants) {
   }
 }
 
-
 TEST(RunSmiConstants) {
   for (int32_t i = 1; i < Smi::kMaxValue && i != 0;
        i = base::ShlWithWraparound(i, 1)) {
@@ -453,14 +443,12 @@ TEST(RunEmptyString) {
   m.CheckString("empty", m.Call());
 }
 
-
 TEST(RunHeapConstant) {
   RawMachineAssemblerTester<Object> m;
   m.Return(m.StringConstant("empty"));
   m.CheckString("empty", m.Call());
 }
 
-
 TEST(RunHeapNumberConstant) {
   RawMachineAssemblerTester<void*> m;
   Handle<HeapObject> number = m.isolate()->factory()->NewHeapNumber(100.5);
@@ -470,7 +458,6 @@ TEST(RunHeapNumberConstant) {
   CHECK_EQ(result, *number);
 }
 
-
 TEST(RunParam1) {
   RawMachineAssemblerTester<int32_t> m(MachineType::Int32());
   m.Return(m.Parameter(0));
@@ -481,7 +468,6 @@ TEST(RunParam1) {
   }
 }
 
-
 TEST(RunParam2_1) {
   RawMachineAssemblerTester<int32_t> m(MachineType::Int32(),
                                        MachineType::Int32());
@@ -496,7 +482,6 @@ TEST(RunParam2_1) {
   }
 }
 
-
 TEST(RunParam2_2) {
   RawMachineAssemblerTester<int32_t> m(MachineType::Int32(),
                                        MachineType::Int32());
@@ -511,7 +496,6 @@ TEST(RunParam2_2) {
   }
 }
 
-
 TEST(RunParam3) {
   for (int i = 0; i < 3; i++) {
     RawMachineAssemblerTester<int32_t> m(
@@ -528,7 +512,6 @@ TEST(RunParam3) {
   }
 }
 
-
 TEST(RunBinopTester) {
   {
     RawMachineAssemblerTester<int32_t> m;
@@ -563,7 +546,6 @@ TEST(RunBinopTester) {
   }
 }
 
-
 #if V8_TARGET_ARCH_64_BIT
 // TODO(ahaas): run int64 tests on all platforms when supported.
 

test/cctest/compiler/codegen-tester.h → test/cctest/compiler/test-codegen.h

@@ -212,7 +212,6 @@ static const bool USE_RESULT_BUFFER = true;
 static const bool USE_RETURN_REGISTER = false;
 static const int32_t CHECK_VALUE = 0x99BEEDCE;
 
-
 // TODO(titzer): use the C-style calling convention, or any register-based
 // calling convention for binop tests.
 template <typename CType, bool use_result_buffer>
@@ -271,7 +270,6 @@ class BinopTester {
   CType result;
 };
 
-
 // A helper class for testing code sequences that take two int parameters and
 // return an int value.
 class Int32BinopTester : public BinopTester<int32_t, USE_RETURN_REGISTER> {
@@ -281,7 +279,6 @@ class Int32BinopTester : public BinopTester<int32_t, USE_RETURN_REGISTER> {
                                                   MachineType::Int32()) {}
 };
 
-
 // A helper class for testing code sequences that take two int parameters and
 // return an int value.
 class Int64BinopTester : public BinopTester<int64_t, USE_RETURN_REGISTER> {
@@ -291,7 +288,6 @@ class Int64BinopTester : public BinopTester<int64_t, USE_RETURN_REGISTER> {
                                                   MachineType::Int64()) {}
 };
 
-
 // A helper class for testing code sequences that take two uint parameters and
 // return an uint value.
 class Uint32BinopTester : public BinopTester<uint32_t, USE_RETURN_REGISTER> {
@@ -307,7 +303,6 @@ class Uint32BinopTester : public BinopTester<uint32_t, USE_RETURN_REGISTER> {
   }
 };
 
-
 // A helper class for testing code sequences that take two float parameters and
 // return a float value.
 class Float32BinopTester : public BinopTester<float, USE_RESULT_BUFFER> {
@@ -316,7 +311,6 @@ class Float32BinopTester : public BinopTester<float, USE_RESULT_BUFFER> {
       : BinopTester<float, USE_RESULT_BUFFER>(tester, MachineType::Float32()) {}
 };
 
-
 // A helper class for testing code sequences that take two double parameters and
 // return a double value.
 class Float64BinopTester : public BinopTester<double, USE_RESULT_BUFFER> {
@@ -326,7 +320,6 @@ class Float64BinopTester : public BinopTester<double, USE_RESULT_BUFFER> {
   }
 };
 
-
 // A helper class for testing code sequences that take two pointer parameters
 // and return a pointer value.
 // TODO(titzer): pick word size of pointers based on V8_TARGET.
@@ -338,7 +331,6 @@ class PointerBinopTester : public BinopTester<Type, USE_RETURN_REGISTER> {
   }
 };
 
-
 // A helper class for testing code sequences that take two tagged parameters and
 // return a tagged value.
 template <typename Type>
@@ -418,7 +410,6 @@ class CompareWrapper {
   IrOpcode::Value opcode;
 };
 
-
 // A small closure class to generate code for a function of two inputs that
 // produces a single output so that it can be used in many different contexts.
 // The {expected()} method should compute the expected output for a given

test/cctest/compiler/test-multiple-return.cc

@@ -20,7 +20,7 @@
 #include "src/wasm/wasm-objects-inl.h"
 #include "src/wasm/wasm-opcodes.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 namespace v8 {

test/cctest/compiler/test-representation-change.cc

@@ -11,8 +11,8 @@
 #include "src/compiler/type-cache.h"
 #include "src/objects/objects-inl.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
 #include "test/cctest/compiler/graph-and-builders.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 namespace v8 {

test/cctest/compiler/test-run-calls-to-external-references.cc

@@ -5,7 +5,7 @@
 #include "src/codegen/external-reference.h"
 #include "src/objects/objects-inl.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 #if V8_ENABLE_WEBASSEMBLY

test/cctest/compiler/test-run-load-store.cc

@@ -11,7 +11,7 @@
 #include "src/base/utils/random-number-generator.h"
 #include "src/objects/objects-inl.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 

test/cctest/compiler/test-run-machops.cc

@@ -16,7 +16,7 @@
 #include "src/utils/boxed-float.h"
 #include "src/utils/utils.h"
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 #include "test/common/flag-utils.h"
 

test/cctest/compiler/test-run-native-calls.cc

@@ -12,10 +12,9 @@
 #include "src/compiler/raw-machine-assembler.h"
 #include "src/objects/objects-inl.h"
 #include "src/wasm/wasm-linkage.h"
-
 #include "test/cctest/cctest.h"
-#include "test/cctest/compiler/codegen-tester.h"
 #include "test/cctest/compiler/graph-and-builders.h"
+#include "test/cctest/compiler/test-codegen.h"
 #include "test/cctest/compiler/value-helper.h"
 
 namespace v8 {

test/cctest/disasm-regex-helper.cc → test/cctest/test-disasm-regex-helper.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "test/cctest/disasm-regex-helper.h"
+#include "test/cctest/test-disasm-regex-helper.h"
 
 #include "include/v8-function.h"
 #include "src/api/api-inl.h"

test/cctest/testcfg.py

@@ -56,7 +56,11 @@ class TestLoader(testsuite.TestLoader):
       print(output.stderr)
       return []
 
-    return sorted(output.stdout.strip().split())
+    filtered_output = [
+        test for test in output.stdout.strip().split()
+        if test.startswith('test-')
+    ]
+    return sorted(filtered_output)
 
 
 class TestSuite(testsuite.TestSuite):