Commit e1e870a3 authored by Reid Kleckner's avatar Reid Kleckner Committed by Commit Bot

Move include of <crtdbg.h> from d8.cc to platform-win32.cc

crtdbg.h provides the declarations for _CrtSetReportMode and the _CRT_*
constants. It should have moved in
https://chromium-review.googlesource.com/968244, but the MSVC C++
headers appear to include crtdbg.h transitively, so we only noticed this
on the libc++ Windows buildbot.

Tbr: mlippautz@chromium.org
Bug: chromium:801780
Change-Id: Ia07f6136e4b8d1f25014e00b0b9f662029ab5a2b
Reviewed-on: https://chromium-review.googlesource.com/981399
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52309}
parent e99b1957
...@@ -27,6 +27,10 @@ ...@@ -27,6 +27,10 @@
#include "src/base/timezone-cache.h" #include "src/base/timezone-cache.h"
#include "src/base/utils/random-number-generator.h" #include "src/base/utils/random-number-generator.h"
#if defined(_MSC_VER)
#include <crtdbg.h> // NOLINT
#endif // defined(_MSC_VER)
// Extra functions for MinGW. Most of these are the _s functions which are in // Extra functions for MinGW. Most of these are the _s functions which are in
// the Microsoft Visual Studio C++ CRT. // the Microsoft Visual Studio C++ CRT.
#ifdef __MINGW32__ #ifdef __MINGW32__
......
...@@ -46,9 +46,6 @@ ...@@ -46,9 +46,6 @@
#include <unistd.h> // NOLINT #include <unistd.h> // NOLINT
#else #else
#include <windows.h> // NOLINT #include <windows.h> // NOLINT
#if defined(_MSC_VER)
#include <crtdbg.h> // NOLINT
#endif // defined(_MSC_VER)
#endif // !defined(_WIN32) && !defined(_WIN64) #endif // !defined(_WIN32) && !defined(_WIN64)
#ifndef DCHECK #ifndef DCHECK
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment