Commit e0e9f741 authored by Maya Lekova's avatar Maya Lekova Committed by V8 LUCI CQ

Revert "[sparkplug] Trigger compilation only when we don't have baseline data"

This reverts commit a93293d9.

Reason for revert: Need to revert a dependency which is blocking the roll - https://chromium-review.googlesource.com/c/v8/v8/+/2953161

Original change's description:
> [sparkplug] Trigger compilation only when we don't have baseline data
>
> If we trigger baseline compilation unconditionally on bytecode budget
> interrupt after we have compiled the function with sparkplug already, we
> will arm back-edges for OSR unconditionally. Since the OSR arming
> mechanism is the same for Sparkplug and TurboFan, this means that we
> will immediately arm back-edges for OSR to TurboFanned code.
>
> Bug: v8:11656
> Change-Id: Ic8e5d1899a3a203321e063ada474d39f2627ea88
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972922
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Patrick Thier <pthier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#75285}

Bug: v8:11656
Change-Id: I2e2910f8882314260ff70a3c996ef74903b6851b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976653
Auto-Submit: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#75286}
parent a93293d9
...@@ -345,7 +345,7 @@ RUNTIME_FUNCTION(Runtime_BytecodeBudgetInterruptFromBytecode) { ...@@ -345,7 +345,7 @@ RUNTIME_FUNCTION(Runtime_BytecodeBudgetInterruptFromBytecode) {
// a non zero invocation count so we can inline functions. // a non zero invocation count so we can inline functions.
function->feedback_vector().set_invocation_count(1); function->feedback_vector().set_invocation_count(1);
} }
if (FLAG_sparkplug && !function->shared(isolate).HasBaselineData()) { if (FLAG_sparkplug) {
CompilationMode compilation_mode = CompilationMode compilation_mode =
FLAG_baseline_batch_compilation ? kCompileBatch : kCompileImmediate; FLAG_baseline_batch_compilation ? kCompileBatch : kCompileImmediate;
if (V8_LIKELY(FLAG_use_osr)) { if (V8_LIKELY(FLAG_use_osr)) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment