Commit e03051ea authored by Victor Gomes's avatar Victor Gomes Committed by V8 LUCI CQ

[bazel] Small patches to reconcile with blaze

No-Try: true
Change-Id: Id8c7aa494bda905aef9cc605e206df685de30233
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983534
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75359}
parent 32593e10
...@@ -2520,6 +2520,8 @@ v8_binary( ...@@ -2520,6 +2520,8 @@ v8_binary(
"src/torque/torque.cc", "src/torque/torque.cc",
], ],
deps = [ ":gtest_prod" ], deps = [ ":gtest_prod" ],
copts = [ "-fexceptions" ],
features = ["-use_header_modules"],
) )
v8_binary( v8_binary(
......
...@@ -43,7 +43,7 @@ v8_custom_config = rule( ...@@ -43,7 +43,7 @@ v8_custom_config = rule(
implementation = _custom_config_impl, implementation = _custom_config_impl,
attrs = { attrs = {
"_v8_typed_array_max_size_in_heap": "_v8_typed_array_max_size_in_heap":
attr.label(default = "//:v8_typed_array_max_size_in_heap"), attr.label(default = ":v8_typed_array_max_size_in_heap"),
} }
) )
...@@ -84,7 +84,7 @@ v8_config = rule( ...@@ -84,7 +84,7 @@ v8_config = rule(
def _default_args(configs): def _default_args(configs):
return struct( return struct(
deps = configs + ["//:define_flags"], deps = configs + [":define_flags"],
copts = [ copts = [
"-fPIC", "-fPIC",
"-Werror", "-Werror",
...@@ -92,6 +92,7 @@ def _default_args(configs): ...@@ -92,6 +92,7 @@ def _default_args(configs):
"-Wno-unused-parameter", "-Wno-unused-parameter",
"-Wno-implicit-int-float-conversion", "-Wno-implicit-int-float-conversion",
"-Wno-deprecated-copy", "-Wno-deprecated-copy",
"-Wno-non-virtual-dtor",
"-std=c++14", "-std=c++14",
"-isystem .", "-isystem .",
# TODO(victorgomes): these should be passed only if x64: # TODO(victorgomes): these should be passed only if x64:
...@@ -185,12 +186,12 @@ v8_torque = rule( ...@@ -185,12 +186,12 @@ v8_torque = rule(
"srcs": attr.label_list(allow_files = True, mandatory = True), "srcs": attr.label_list(allow_files = True, mandatory = True),
"extras": attr.string_list(), "extras": attr.string_list(),
"tool": attr.label( "tool": attr.label(
default = "//:torque", default = ":torque",
allow_files = True, allow_files = True,
executable = True, executable = True,
cfg = "target", cfg = "target",
), ),
"_v8_annotate_torque_ir": attr.label(default = "//:v8_annotate_torque_ir"), "_v8_annotate_torque_ir": attr.label(default = ":v8_annotate_torque_ir"),
}, },
) )
...@@ -217,7 +218,7 @@ v8_mksnapshot = rule( ...@@ -217,7 +218,7 @@ v8_mksnapshot = rule(
implementation = _mksnapshot, implementation = _mksnapshot,
attrs = { attrs = {
"tool": attr.label( "tool": attr.label(
default = "//:mksnapshot", default = ":mksnapshot",
allow_files = True, allow_files = True,
executable = True, executable = True,
cfg = "target", cfg = "target",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment