Commit dff6d864 authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[include] Make Platform::CreateJob abstract

Embedders must override the method, because returning a nullptr will
make V8 crash. Hence the method should be abstract.

Bug: v8:12425
Change-Id: I79e1759acd2a5f41424145637ee1fbd161889ec1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779694Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82058}
parent ce9ca524
...@@ -1071,13 +1071,9 @@ class Platform { ...@@ -1071,13 +1071,9 @@ class Platform {
* return v8::platform::NewDefaultJobHandle( * return v8::platform::NewDefaultJobHandle(
* this, priority, std::move(job_task), NumberOfWorkerThreads()); * this, priority, std::move(job_task), NumberOfWorkerThreads());
* } * }
*
* TODO(etiennep): Make pure virtual once custom embedders implement it.
*/ */
virtual std::unique_ptr<JobHandle> CreateJob( virtual std::unique_ptr<JobHandle> CreateJob(
TaskPriority priority, std::unique_ptr<JobTask> job_task) { TaskPriority priority, std::unique_ptr<JobTask> job_task) = 0;
return nullptr;
}
/** /**
* Monotonically increasing time in seconds from an arbitrary fixed point in * Monotonically increasing time in seconds from an arbitrary fixed point in
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment